linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neil@brown.name>
To: Stefan Roese <sr@denx.de>,
	linux-spi@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	John Crispin <john@phrozen.org>, Mark Brown <broonie@kernel.org>,
	Sankalp Negi <sankalpnegi2310@gmail.com>
Subject: Re: [PATCH 9/9 v3] staging: spi: mt7621: Remove superfluous pre-declaration of struct mt7621_spi
Date: Mon, 04 Feb 2019 09:42:07 +1100	[thread overview]
Message-ID: <87k1igjxz4.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20190201101715.3760-9-sr@denx.de>


[-- Attachment #1.1: Type: text/plain, Size: 1182 bytes --]

On Fri, Feb 01 2019, Stefan Roese wrote:

> This patch removes the superfluous pre-declaration of struct mt7621_spi.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: NeilBrown <neil@brown.name>
> Cc: Sankalp Negi <sankalpnegi2310@gmail.com>
> Cc: Chuanhong Guo <gch981213@gmail.com>
> Cc: John Crispin <john@phrozen.org>
> ---
> v3:
> - New patch, changes spilt into separate patches
>
>  drivers/staging/mt7621-spi/spi-mt7621.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c b/drivers/staging/mt7621-spi/spi-mt7621.c
> index d6385220b796..167d0f09823b 100644
> --- a/drivers/staging/mt7621-spi/spi-mt7621.c
> +++ b/drivers/staging/mt7621-spi/spi-mt7621.c
> @@ -51,8 +51,6 @@
>  #define MT7621_CPOL		BIT(4)
>  #define MT7621_LSB_FIRST	BIT(3)
>  
> -struct mt7621_spi;
> -
>  struct mt7621_spi {
>  	struct spi_master	*master;
>  	void __iomem		*base;
> -- 
> 2.20.1

Thanks,
this and all previous patches in the series
  Review-by: NeilBrown <neil@brown.name>

(compile-tested too :-)

NeilBrown

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2019-02-03 22:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 10:17 [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier Stefan Roese
2019-02-01 10:17 ` [PATCH 2/9 v3] staging: spi: mt7621: Clean up excessive header usage Stefan Roese
2019-02-01 10:17 ` [PATCH 3/9 v3] staging: spi: mt7621: Add return code check on device_reset() Stefan Roese
2019-02-01 10:17 ` [PATCH 4/9 v3] staging: spi: mt7621: Remove superfluous SPI_BPW_MASK definition Stefan Roese
2019-02-01 10:17 ` [PATCH 5/9 v3] staging: spi: mt7621: Minor cosmetic changes Stefan Roese
2019-02-01 10:17 ` [PATCH 6/9 v3] staging: spi: mt7621: Use recommended comment style Stefan Roese
2019-02-01 10:17 ` [PATCH 7/9 v3] staging: spi: mt7621: Sort register definitions Stefan Roese
2019-02-01 10:17 ` [PATCH 8/9 v3] staging: spi: mt7621: Use macros instead of hardcoded values Stefan Roese
2019-02-01 10:17 ` [PATCH 9/9 v3] staging: spi: mt7621: Remove superfluous pre-declaration of struct mt7621_spi Stefan Roese
2019-02-03 22:42   ` NeilBrown [this message]
2019-02-01 13:03 ` [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier Mark Brown
2019-02-03 22:34   ` NeilBrown
2019-02-04  8:53     ` Mark Brown
2019-02-04 23:09       ` NeilBrown
2019-02-05  6:29       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1igjxz4.fsf@notabene.neil.brown.name \
    --to=neil@brown.name \
    --cc=broonie@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john@phrozen.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=sankalpnegi2310@gmail.com \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).