From: NeilBrown <neil@brown.name>
To: Mark Brown <broonie@kernel.org>, Stefan Roese <sr@denx.de>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-spi@vger.kernel.org,
Sankalp Negi <sankalpnegi2310@gmail.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier
Date: Mon, 04 Feb 2019 09:34:56 +1100 [thread overview]
Message-ID: <87muncjyb3.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20190201130355.GG20797@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 737 bytes --]
On Fri, Feb 01 2019, Mark Brown wrote:
> On Fri, Feb 01, 2019 at 11:17:07AM +0100, Stefan Roese wrote:
>
>> @@ -1,3 +1,4 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> /*
>> * spi-mt7621.c -- MediaTek MT7621 SPI controller driver
>> *
>
> Please convert the entire comment into a C++ comment so it looks more
> intentional.
Hi Mark,
I don't understand what you mean by this, or possibly I do understand
and strongly disagree.
It is extremely common in the kernel for a file to start
// SPDX-License-Identifier.....
and to have that immediately followed by a comment lile:
/*
* .....
* ....
This patch makes this file match much of the rest of the kernel. Why
do you want something different?
Thanks,
NeilBrown
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-02-03 22:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 10:17 [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier Stefan Roese
2019-02-01 10:17 ` [PATCH 2/9 v3] staging: spi: mt7621: Clean up excessive header usage Stefan Roese
2019-02-01 10:17 ` [PATCH 3/9 v3] staging: spi: mt7621: Add return code check on device_reset() Stefan Roese
2019-02-01 10:17 ` [PATCH 4/9 v3] staging: spi: mt7621: Remove superfluous SPI_BPW_MASK definition Stefan Roese
2019-02-01 10:17 ` [PATCH 5/9 v3] staging: spi: mt7621: Minor cosmetic changes Stefan Roese
2019-02-01 10:17 ` [PATCH 6/9 v3] staging: spi: mt7621: Use recommended comment style Stefan Roese
2019-02-01 10:17 ` [PATCH 7/9 v3] staging: spi: mt7621: Sort register definitions Stefan Roese
2019-02-01 10:17 ` [PATCH 8/9 v3] staging: spi: mt7621: Use macros instead of hardcoded values Stefan Roese
2019-02-01 10:17 ` [PATCH 9/9 v3] staging: spi: mt7621: Remove superfluous pre-declaration of struct mt7621_spi Stefan Roese
2019-02-03 22:42 ` NeilBrown
2019-02-01 13:03 ` [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier Mark Brown
2019-02-03 22:34 ` NeilBrown [this message]
2019-02-04 8:53 ` Mark Brown
2019-02-04 23:09 ` NeilBrown
2019-02-05 6:29 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muncjyb3.fsf@notabene.neil.brown.name \
--to=neil@brown.name \
--cc=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john@phrozen.org \
--cc=linux-spi@vger.kernel.org \
--cc=sankalpnegi2310@gmail.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).