* [PATCH] spi/spi_oc_tiny: fix build error
@ 2011-02-22 21:24 Andres Salomon
2011-02-22 21:35 ` [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Andres Salomon @ 2011-02-22 21:24 UTC (permalink / raw)
To: David Brownell
Cc: Grant Likely, spi-devel-general, linux-kernel, Stephen Rothwell
Fix the following build error due to a missing semicolon:
CC [M] drivers/spi/spi_oc_tiny.o
drivers/spi/spi_oc_tiny.c:394: error: expected ‘,’ or ‘;’ before ‘extern’
make[2]: *** [drivers/spi/spi_oc_tiny.o] Error 1
Signed-off-by: Andres Salomon <dilinger@queued.net>
---
drivers/spi/spi_oc_tiny.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi_oc_tiny.c b/drivers/spi/spi_oc_tiny.c
index e99e545..f1bde66 100644
--- a/drivers/spi/spi_oc_tiny.c
+++ b/drivers/spi/spi_oc_tiny.c
@@ -390,7 +390,7 @@ static int __devexit tiny_spi_remove(struct platform_device *pdev)
static const struct of_device_id tiny_spi_match[] = {
{ .compatible = "opencores,tiny-spi-rtlsvn2", },
{},
-}
+};
MODULE_DEVICE_TABLE(of, tiny_spi_match);
#else /* CONFIG_OF */
#define tiny_spi_match NULL
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors
2011-02-22 21:24 [PATCH] spi/spi_oc_tiny: fix build error Andres Salomon
@ 2011-02-22 21:35 ` Randy Dunlap
2011-02-22 22:02 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2011-02-22 21:35 UTC (permalink / raw)
To: Andres Salomon
Cc: David Brownell, Grant Likely, spi-devel-general, linux-kernel,
Stephen Rothwell
On Tue, 22 Feb 2011 13:24:38 -0800 Andres Salomon wrote:
> Fix the following build error due to a missing semicolon:
>
> CC [M] drivers/spi/spi_oc_tiny.o
> drivers/spi/spi_oc_tiny.c:394: error: expected ‘,’ or ‘;’ before ‘extern’
> make[2]: *** [drivers/spi/spi_oc_tiny.o] Error 1
>
> Signed-off-by: Andres Salomon <dilinger@queued.net>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Same fix is needed for drivers/spi/spi_altera.c.
I already had this patch ready to send. Grant, can you extract
the spi_altera.c patch...?
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build error due to missing semi-colon:
drivers/spi/spi_altera.c:308: error: expected ',' or ';' before 'extern'
drivers/spi/spi_oc_tiny.c:394: error: expected ',' or ';' before 'extern'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/spi/spi_altera.c | 2 +-
drivers/spi/spi_oc_tiny.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20110222.orig/drivers/spi/spi_oc_tiny.c
+++ linux-next-20110222/drivers/spi/spi_oc_tiny.c
@@ -390,7 +390,7 @@ static int __devexit tiny_spi_remove(str
static const struct of_device_id tiny_spi_match[] = {
{ .compatible = "opencores,tiny-spi-rtlsvn2", },
{},
-}
+};
MODULE_DEVICE_TABLE(of, tiny_spi_match);
#else /* CONFIG_OF */
#define tiny_spi_match NULL
--- linux-next-20110222.orig/drivers/spi/spi_altera.c
+++ linux-next-20110222/drivers/spi/spi_altera.c
@@ -304,7 +304,7 @@ static int __devexit altera_spi_remove(s
static const struct of_device_id altera_spi_match[] = {
{ .compatible = "ALTR,spi-1.0", },
{},
-}
+};
MODULE_DEVICE_TABLE(of, altera_spi_match);
#else /* CONFIG_OF */
#define altera_spi_match NULL
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors
2011-02-22 21:35 ` [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors Randy Dunlap
@ 2011-02-22 22:02 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2011-02-22 22:02 UTC (permalink / raw)
To: Randy Dunlap
Cc: Andres Salomon, David Brownell, spi-devel-general, linux-kernel,
Stephen Rothwell
On Tue, Feb 22, 2011 at 2:35 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On Tue, 22 Feb 2011 13:24:38 -0800 Andres Salomon wrote:
>
>> Fix the following build error due to a missing semicolon:
>>
>> CC [M] drivers/spi/spi_oc_tiny.o
>> drivers/spi/spi_oc_tiny.c:394: error: expected ‘,’ or ‘;’ before ‘extern’
>> make[2]: *** [drivers/spi/spi_oc_tiny.o] Error 1
>>
>> Signed-off-by: Andres Salomon <dilinger@queued.net>
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Same fix is needed for drivers/spi/spi_altera.c.
> I already had this patch ready to send. Grant, can you extract
> the spi_altera.c patch...?
done. Will be pushed out when I finish testing.
g.
>
>
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix build error due to missing semi-colon:
>
> drivers/spi/spi_altera.c:308: error: expected ',' or ';' before 'extern'
> drivers/spi/spi_oc_tiny.c:394: error: expected ',' or ';' before 'extern'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/spi/spi_altera.c | 2 +-
> drivers/spi/spi_oc_tiny.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20110222.orig/drivers/spi/spi_oc_tiny.c
> +++ linux-next-20110222/drivers/spi/spi_oc_tiny.c
> @@ -390,7 +390,7 @@ static int __devexit tiny_spi_remove(str
> static const struct of_device_id tiny_spi_match[] = {
> { .compatible = "opencores,tiny-spi-rtlsvn2", },
> {},
> -}
> +};
> MODULE_DEVICE_TABLE(of, tiny_spi_match);
> #else /* CONFIG_OF */
> #define tiny_spi_match NULL
> --- linux-next-20110222.orig/drivers/spi/spi_altera.c
> +++ linux-next-20110222/drivers/spi/spi_altera.c
> @@ -304,7 +304,7 @@ static int __devexit altera_spi_remove(s
> static const struct of_device_id altera_spi_match[] = {
> { .compatible = "ALTR,spi-1.0", },
> {},
> -}
> +};
> MODULE_DEVICE_TABLE(of, altera_spi_match);
> #else /* CONFIG_OF */
> #define altera_spi_match NULL
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-22 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-22 21:24 [PATCH] spi/spi_oc_tiny: fix build error Andres Salomon
2011-02-22 21:35 ` [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors Randy Dunlap
2011-02-22 22:02 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).