* [PATCH] spi: spi-ti-qspi: reinit of completion variable
@ 2016-11-15 18:26 Prahlad V
2016-11-15 18:53 ` Applied "spi: spi-ti-qspi: reinit of completion variable" to the spi tree Mark Brown
[not found] ` <20161115182643.32217-1-prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 2 replies; 4+ messages in thread
From: Prahlad V @ 2016-11-15 18:26 UTC (permalink / raw)
To: broonie-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, vigneshr-l0cyMroinI0,
Prahlad V
completion variable should be reinitialized before reusing.
Signed-off-by: Prahlad V <prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/spi/spi-ti-qspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index caeac66..ec6fb09 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
tx->callback = ti_qspi_dma_callback;
tx->callback_param = qspi;
cookie = tx->tx_submit(tx);
+ reinit_completion(&qspi->transfer_complete);
ret = dma_submit_error(cookie);
if (ret) {
--
2.9.2.729.ga42d7b6
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Applied "spi: spi-ti-qspi: reinit of completion variable" to the spi tree
2016-11-15 18:26 [PATCH] spi: spi-ti-qspi: reinit of completion variable Prahlad V
@ 2016-11-15 18:53 ` Mark Brown
[not found] ` <20161115182643.32217-1-prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2016-11-15 18:53 UTC (permalink / raw)
To: Prahlad V; +Cc: Mark Brown, broonie, linux-spi, linux-kernel, vigneshr
The patch
spi: spi-ti-qspi: reinit of completion variable
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From d06a3507fe7cfd85a296d2c1fe367dd850e9595f Mon Sep 17 00:00:00 2001
From: Prahlad V <prahlad.eee@gmail.com>
Date: Tue, 15 Nov 2016 23:56:43 +0530
Subject: [PATCH] spi: spi-ti-qspi: reinit of completion variable
completion variable should be reinitialized before reusing.
Signed-off-by: Prahlad V <prahlad.eee@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-ti-qspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index caeac66a3977..ec6fb09e2e17 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
tx->callback = ti_qspi_dma_callback;
tx->callback_param = qspi;
cookie = tx->tx_submit(tx);
+ reinit_completion(&qspi->transfer_complete);
ret = dma_submit_error(cookie);
if (ret) {
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <20161115182643.32217-1-prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable
[not found] ` <20161115182643.32217-1-prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-11-22 7:24 ` prahlad venkata
[not found] ` <CAFbo-qWmvm02wpkWT0hgX6qu6jOStmwAXHBWbjbAQ=fwv0WPng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: prahlad venkata @ 2016-11-22 7:24 UTC (permalink / raw)
To: broonie-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Vignesh R, Prahlad V
Did anybody got chance to review this patch?
I feel this is a trivial yet required fix.
On Tue, Nov 15, 2016 at 11:56 PM, Prahlad V <prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> completion variable should be reinitialized before reusing.
>
> Signed-off-by: Prahlad V <prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/spi/spi-ti-qspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index caeac66..ec6fb09 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
> tx->callback = ti_qspi_dma_callback;
> tx->callback_param = qspi;
> cookie = tx->tx_submit(tx);
> + reinit_completion(&qspi->transfer_complete);
>
> ret = dma_submit_error(cookie);
> if (ret) {
> --
> 2.9.2.729.ga42d7b6
>
--
Regards,
Prahlad.
+91-9663742838
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-22 12:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-15 18:26 [PATCH] spi: spi-ti-qspi: reinit of completion variable Prahlad V
2016-11-15 18:53 ` Applied "spi: spi-ti-qspi: reinit of completion variable" to the spi tree Mark Brown
[not found] ` <20161115182643.32217-1-prahlad.eee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-22 7:24 ` [PATCH] spi: spi-ti-qspi: reinit of completion variable prahlad venkata
[not found] ` <CAFbo-qWmvm02wpkWT0hgX6qu6jOStmwAXHBWbjbAQ=fwv0WPng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-22 12:27 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).