From: Grant Likely <email@example.com>
Cc: Torsten Fleischer <firstname.lastname@example.org>,
Subject: Re: spi_mpc8xxx.c: chip select polarity problem
Date: Thu, 26 Nov 2009 11:16:34 -0700 [thread overview]
Message-ID: <email@example.com> (raw)
On Thu, Nov 26, 2009 at 5:12 AM, Anton Vorontsov
> On Wed, Nov 25, 2009 at 03:11:57PM -0700, Grant Likely wrote:
>> On Wed, Nov 25, 2009 at 1:41 PM, Torsten Fleischer
>> <firstname.lastname@example.org> wrote:
>> > On Wen, Nov 25, 2009 at 01:33:57 Grant Likely wrote:
>> >> Thanks. However, there needs to be a proper description of what this
>> >> patch does to go in the commit header. Can you please write one?
>> >> Thanks,
>> >> g.
>> > [...]
>> > The initialization of the chip selects is removed from the probe() function of
>> > the spi_mpc8xxx driver, because the driver doesn't know the polarity of the
>> > chip selects of the SPI devices at the time of its initialization.
>> > For this reason the initialization of the several chip selects is postponed
>> > to the point of time when the very first SPI transfer to the associated device
>> > occurs.
>> > Signed-off-by: Torsten Fleischer <email@example.com>
>> Ah. I understand what you're doing now. Hmmm. This approach
>> concerns me because it relies on firmware or platform code to get CS
>> gpios set up properly before the driver is probed.
> Yes, that was said at the very beginning of this thread.
I also came in part way through as I wasn't an SPI maintainer when
this thread started. :-)
>> Firmware doesn't
>> always get it right, and I prefer to avoid platform specific setups as
>> much as possible. Why can't the CS polarity be encoded into the
>> device tree so the driver *does* have the polarity data at probe time?
> We have the spi-cs-high property, but it duplicates compatible
> property. 'compatible' is enough to tell whether some device has
> cs-high or cs-low (device's driver knows that already).
But the device's driver isn't controlling the CS line, the SPI bus
driver is. Besides, there is no guarantee that all drivers will
actualy be loaded before something starts using SPI. The bus driver
*must* know what the active state of each CS line is before activating
The spi bus binding is deficient in this case. A property (can be
optional) need to be added to the spi bus node to explicitly state the
CS polarities. It's not entirely sane to look for a "spi-cs-high'
property in the spi device nodes because the SPI bus may not be fully
populated (ie. if a device happens to be sitting on the bus, but isn't
in the device tree yet). Before any SPI transactions go out, it is
the responsibility of the bus driver to ensure all CS lines are in the
> The problem is that SPI bus master doesn't know all the devices,
> so it can't extract that information from the compatible string.
> To workaround that we can use 'spi-cs-high', but that's ugly
It doesn't need to know about the devices, but is must know how all of
its CS lines behave. So it isn't an really an ugly workaround, but I
do think the binding is insufficient for the SPI bus driver (see
> SPI modes (0,1,2,3) is another matter, some devices can work in
> several modes, so 'spi-cpol' and 'spi-cpha' are actually useful.
yes. spi-cpol and spi-cpha are actually properties of the device, and
belong in the spi device node, not the spi bus node.
The spi-cs-high property is defined in
Documentation/powerpc/dts-bindings/spi-bus.txt, but it definitely was
a mistake for the reasons I described above. It does work in some
cases, but a property at the bus node would be better. The driver can
still fallback to looking for spi-cs-high properties in child nodes.
Currently the spi-cs-high property is parsed in the
of_register_spi_devices() function, but the CS polarity needs to be
known before registering devices. It needs to be factored out into
another utility function callable by spi bus drivers so that it can
get polarity data at probe time.
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-11-26 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <firstname.lastname@example.org>
[not found] ` <email@example.com>
[not found] ` <firstname.lastname@example.org>
[not found] ` <email@example.com>
2009-11-25 22:11 ` spi_mpc8xxx.c: chip select polarity problem Grant Likely
2009-11-26 12:12 ` Anton Vorontsov
2009-11-26 17:27 ` Torsten Fleischer
2009-11-26 18:18 ` Grant Likely
2009-11-26 18:16 ` Grant Likely [this message]
2009-11-26 18:41 ` Anton Vorontsov
2009-11-26 18:50 ` Grant Likely
2009-11-26 19:01 ` Anton Vorontsov
2009-11-26 19:17 ` Grant Likely
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).