* [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory @ 2021-07-19 22:46 Phillip Potter 2021-07-19 23:46 ` Larry Finger 2021-07-21 8:16 ` Greg KH 0 siblings, 2 replies; 17+ messages in thread From: Phillip Potter @ 2021-07-19 22:46 UTC (permalink / raw) To: gregkh; +Cc: Larry.Finger, dan.carpenter, linux-kernel, linux-staging Move all C source files from the core subdirectory to the root folder of the driver, and adjust Makefile accordingly. The ultmate goal is to remove hal layer and fold its functionalty into the main sources. At this point, the distinction between hal and core will be meaningless, so this is the first step towards simplifying the file layout. Signed-off-by: Phillip Potter <phil@philpotter.co.uk> --- drivers/staging/rtl8188eu/Makefile | 34 +++++++++---------- drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0 .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0 .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0 .../rtl8188eu/{core => }/rtw_ieee80211.c | 0 .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0 .../staging/rtl8188eu/{core => }/rtw_iol.c | 0 .../staging/rtl8188eu/{core => }/rtw_led.c | 0 .../staging/rtl8188eu/{core => }/rtw_mlme.c | 0 .../rtl8188eu/{core => }/rtw_mlme_ext.c | 0 .../rtl8188eu/{core => }/rtw_pwrctrl.c | 0 .../staging/rtl8188eu/{core => }/rtw_recv.c | 0 drivers/staging/rtl8188eu/{core => }/rtw_rf.c | 0 .../rtl8188eu/{core => }/rtw_security.c | 0 .../staging/rtl8188eu/{core => }/rtw_sreset.c | 0 .../rtl8188eu/{core => }/rtw_sta_mgt.c | 0 .../rtl8188eu/{core => }/rtw_wlan_util.c | 0 .../staging/rtl8188eu/{core => }/rtw_xmit.c | 0 18 files changed, 17 insertions(+), 17 deletions(-) rename drivers/staging/rtl8188eu/{core => }/rtw_ap.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_cmd.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_efuse.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_ieee80211.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_ioctl_set.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_iol.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_led.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_mlme.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_mlme_ext.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_pwrctrl.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_recv.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_rf.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_security.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_sreset.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_sta_mgt.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_wlan_util.c (100%) rename drivers/staging/rtl8188eu/{core => }/rtw_xmit.c (100%) diff --git a/drivers/staging/rtl8188eu/Makefile b/drivers/staging/rtl8188eu/Makefile index 28b936e8be0a..2dad13bdbdeb 100644 --- a/drivers/staging/rtl8188eu/Makefile +++ b/drivers/staging/rtl8188eu/Makefile @@ -1,22 +1,22 @@ # SPDX-License-Identifier: GPL-2.0 r8188eu-y := \ - core/rtw_ap.o \ - core/rtw_cmd.o \ - core/rtw_efuse.o \ - core/rtw_ieee80211.o \ - core/rtw_ioctl_set.o \ - core/rtw_iol.o \ - core/rtw_led.o \ - core/rtw_mlme.o \ - core/rtw_mlme_ext.o \ - core/rtw_pwrctrl.o \ - core/rtw_recv.o \ - core/rtw_rf.o \ - core/rtw_security.o \ - core/rtw_sreset.o \ - core/rtw_sta_mgt.o \ - core/rtw_wlan_util.o \ - core/rtw_xmit.o \ + rtw_ap.o \ + rtw_cmd.o \ + rtw_efuse.o \ + rtw_ieee80211.o \ + rtw_ioctl_set.o \ + rtw_iol.o \ + rtw_led.o \ + rtw_mlme.o \ + rtw_mlme_ext.o \ + rtw_pwrctrl.o \ + rtw_recv.o \ + rtw_rf.o \ + rtw_security.o \ + rtw_sreset.o \ + rtw_sta_mgt.o \ + rtw_wlan_util.o \ + rtw_xmit.o \ hal/fw.o \ hal/mac_cfg.o \ hal/bb_cfg.o \ diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/rtw_ap.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_ap.c rename to drivers/staging/rtl8188eu/rtw_ap.c diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/rtw_cmd.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_cmd.c rename to drivers/staging/rtl8188eu/rtw_cmd.c diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/rtw_efuse.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_efuse.c rename to drivers/staging/rtl8188eu/rtw_efuse.c diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/rtw_ieee80211.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_ieee80211.c rename to drivers/staging/rtl8188eu/rtw_ieee80211.c diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/rtw_ioctl_set.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c rename to drivers/staging/rtl8188eu/rtw_ioctl_set.c diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/rtw_iol.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_iol.c rename to drivers/staging/rtl8188eu/rtw_iol.c diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/rtw_led.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_led.c rename to drivers/staging/rtl8188eu/rtw_led.c diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/rtw_mlme.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_mlme.c rename to drivers/staging/rtl8188eu/rtw_mlme.c diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/rtw_mlme_ext.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_mlme_ext.c rename to drivers/staging/rtl8188eu/rtw_mlme_ext.c diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/rtw_pwrctrl.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_pwrctrl.c rename to drivers/staging/rtl8188eu/rtw_pwrctrl.c diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/rtw_recv.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_recv.c rename to drivers/staging/rtl8188eu/rtw_recv.c diff --git a/drivers/staging/rtl8188eu/core/rtw_rf.c b/drivers/staging/rtl8188eu/rtw_rf.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_rf.c rename to drivers/staging/rtl8188eu/rtw_rf.c diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/rtw_security.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_security.c rename to drivers/staging/rtl8188eu/rtw_security.c diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c b/drivers/staging/rtl8188eu/rtw_sreset.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_sreset.c rename to drivers/staging/rtl8188eu/rtw_sreset.c diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/rtw_sta_mgt.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_sta_mgt.c rename to drivers/staging/rtl8188eu/rtw_sta_mgt.c diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/rtw_wlan_util.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_wlan_util.c rename to drivers/staging/rtl8188eu/rtw_wlan_util.c diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/rtw_xmit.c similarity index 100% rename from drivers/staging/rtl8188eu/core/rtw_xmit.c rename to drivers/staging/rtl8188eu/rtw_xmit.c -- 2.31.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-19 22:46 [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory Phillip Potter @ 2021-07-19 23:46 ` Larry Finger 2021-07-20 9:00 ` Fabio Aiuto 2021-07-20 22:51 ` Phillip Potter 2021-07-21 8:16 ` Greg KH 1 sibling, 2 replies; 17+ messages in thread From: Larry Finger @ 2021-07-19 23:46 UTC (permalink / raw) To: Phillip Potter, gregkh; +Cc: dan.carpenter, linux-kernel, linux-staging On 7/19/21 5:46 PM, Phillip Potter wrote: > Move all C source files from the core subdirectory to the root > folder of the driver, and adjust Makefile accordingly. The ultmate > goal is to remove hal layer and fold its functionalty into the main > sources. At this point, the distinction between hal and core will be > meaningless, so this is the first step towards simplifying the file > layout. > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > --- > drivers/staging/rtl8188eu/Makefile | 34 +++++++++---------- > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0 > .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0 > .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0 > .../rtl8188eu/{core => }/rtw_ieee80211.c | 0 > .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0 > .../staging/rtl8188eu/{core => }/rtw_iol.c | 0 > .../staging/rtl8188eu/{core => }/rtw_led.c | 0 > .../staging/rtl8188eu/{core => }/rtw_mlme.c | 0 > .../rtl8188eu/{core => }/rtw_mlme_ext.c | 0 > .../rtl8188eu/{core => }/rtw_pwrctrl.c | 0 > .../staging/rtl8188eu/{core => }/rtw_recv.c | 0 > drivers/staging/rtl8188eu/{core => }/rtw_rf.c | 0 > .../rtl8188eu/{core => }/rtw_security.c | 0 > .../staging/rtl8188eu/{core => }/rtw_sreset.c | 0 > .../rtl8188eu/{core => }/rtw_sta_mgt.c | 0 > .../rtl8188eu/{core => }/rtw_wlan_util.c | 0 > .../staging/rtl8188eu/{core => }/rtw_xmit.c | 0 > 18 files changed, 17 insertions(+), 17 deletions(-) > rename drivers/staging/rtl8188eu/{core => }/rtw_ap.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_cmd.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_efuse.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_ieee80211.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_ioctl_set.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_iol.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_led.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_mlme.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_mlme_ext.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_pwrctrl.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_recv.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_rf.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_security.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_sreset.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_sta_mgt.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_wlan_util.c (100%) > rename drivers/staging/rtl8188eu/{core => }/rtw_xmit.c (100%) > > diff --git a/drivers/staging/rtl8188eu/Makefile b/drivers/staging/rtl8188eu/Makefile > index 28b936e8be0a..2dad13bdbdeb 100644 > --- a/drivers/staging/rtl8188eu/Makefile > +++ b/drivers/staging/rtl8188eu/Makefile > @@ -1,22 +1,22 @@ > # SPDX-License-Identifier: GPL-2.0 > r8188eu-y := \ > - core/rtw_ap.o \ > - core/rtw_cmd.o \ > - core/rtw_efuse.o \ > - core/rtw_ieee80211.o \ > - core/rtw_ioctl_set.o \ > - core/rtw_iol.o \ > - core/rtw_led.o \ > - core/rtw_mlme.o \ > - core/rtw_mlme_ext.o \ > - core/rtw_pwrctrl.o \ > - core/rtw_recv.o \ > - core/rtw_rf.o \ > - core/rtw_security.o \ > - core/rtw_sreset.o \ > - core/rtw_sta_mgt.o \ > - core/rtw_wlan_util.o \ > - core/rtw_xmit.o \ > + rtw_ap.o \ > + rtw_cmd.o \ > + rtw_efuse.o \ > + rtw_ieee80211.o \ > + rtw_ioctl_set.o \ > + rtw_iol.o \ > + rtw_led.o \ > + rtw_mlme.o \ > + rtw_mlme_ext.o \ > + rtw_pwrctrl.o \ > + rtw_recv.o \ > + rtw_rf.o \ > + rtw_security.o \ > + rtw_sreset.o \ > + rtw_sta_mgt.o \ > + rtw_wlan_util.o \ > + rtw_xmit.o \ > hal/fw.o \ > hal/mac_cfg.o \ > hal/bb_cfg.o \ > diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/rtw_ap.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_ap.c > rename to drivers/staging/rtl8188eu/rtw_ap.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/rtw_cmd.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_cmd.c > rename to drivers/staging/rtl8188eu/rtw_cmd.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/rtw_efuse.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_efuse.c > rename to drivers/staging/rtl8188eu/rtw_efuse.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/rtw_ieee80211.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_ieee80211.c > rename to drivers/staging/rtl8188eu/rtw_ieee80211.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/rtw_ioctl_set.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c > rename to drivers/staging/rtl8188eu/rtw_ioctl_set.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/rtw_iol.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_iol.c > rename to drivers/staging/rtl8188eu/rtw_iol.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/rtw_led.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_led.c > rename to drivers/staging/rtl8188eu/rtw_led.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/rtw_mlme.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_mlme.c > rename to drivers/staging/rtl8188eu/rtw_mlme.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/rtw_mlme_ext.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > rename to drivers/staging/rtl8188eu/rtw_mlme_ext.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/rtw_pwrctrl.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_pwrctrl.c > rename to drivers/staging/rtl8188eu/rtw_pwrctrl.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/rtw_recv.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_recv.c > rename to drivers/staging/rtl8188eu/rtw_recv.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_rf.c b/drivers/staging/rtl8188eu/rtw_rf.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_rf.c > rename to drivers/staging/rtl8188eu/rtw_rf.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/rtw_security.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_security.c > rename to drivers/staging/rtl8188eu/rtw_security.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c b/drivers/staging/rtl8188eu/rtw_sreset.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_sreset.c > rename to drivers/staging/rtl8188eu/rtw_sreset.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/rtw_sta_mgt.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > rename to drivers/staging/rtl8188eu/rtw_sta_mgt.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/rtw_wlan_util.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_wlan_util.c > rename to drivers/staging/rtl8188eu/rtw_wlan_util.c > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/rtw_xmit.c > similarity index 100% > rename from drivers/staging/rtl8188eu/core/rtw_xmit.c > rename to drivers/staging/rtl8188eu/rtw_xmit.c > I think this is just source churning. The current setup with include. core. hal and os_dep subdirectories are not opressive. Larry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-19 23:46 ` Larry Finger @ 2021-07-20 9:00 ` Fabio Aiuto 2021-07-20 22:54 ` Phillip Potter 2021-07-21 0:22 ` Larry Finger 2021-07-20 22:51 ` Phillip Potter 1 sibling, 2 replies; 17+ messages in thread From: Fabio Aiuto @ 2021-07-20 9:00 UTC (permalink / raw) To: Larry Finger Cc: Phillip Potter, gregkh, dan.carpenter, linux-kernel, linux-staging Hi all, On Mon, Jul 19, 2021 at 06:46:16PM -0500, Larry Finger wrote: > On 7/19/21 5:46 PM, Phillip Potter wrote: > > Move all C source files from the core subdirectory to the root > > folder of the driver, and adjust Makefile accordingly. The ultmate > > goal is to remove hal layer and fold its functionalty into the main > > sources. At this point, the distinction between hal and core will be > > meaningless, so this is the first step towards simplifying the file > > layout. > > > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > > --- > > drivers/staging/rtl8188eu/Makefile | 34 +++++++++---------- > > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0 > > .../rtl8188eu/{core => }/rtw_ieee80211.c | 0 > > .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_iol.c | 0 > > > I think this is just source churning. The current setup with include. core. > hal and os_dep subdirectories are not opressive. > > Larry > > maybe the information we will need one day is: will the core/-os_dep/-hal/-include/-directory-structure be welcomed in mainline wireless subsystem, when an rtl* driver will be perfectly tuned? At the moment I can't see such a directory organization in any of the realtek wireless driver. Sure there's time for that ;), Thank you, fabio ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-20 9:00 ` Fabio Aiuto @ 2021-07-20 22:54 ` Phillip Potter 2021-07-21 7:51 ` Fabio Aiuto 2021-07-21 0:22 ` Larry Finger 1 sibling, 1 reply; 17+ messages in thread From: Phillip Potter @ 2021-07-20 22:54 UTC (permalink / raw) To: Fabio Aiuto Cc: gregkh, dan.carpenter, linux-kernel, linux-staging, Larry.Finger On Tue, Jul 20, 2021 at 11:00:36AM +0200, Fabio Aiuto wrote: > Hi all, > > On Mon, Jul 19, 2021 at 06:46:16PM -0500, Larry Finger wrote: > > On 7/19/21 5:46 PM, Phillip Potter wrote: > > > Move all C source files from the core subdirectory to the root > > > folder of the driver, and adjust Makefile accordingly. The ultmate > > > goal is to remove hal layer and fold its functionalty into the main > > > sources. At this point, the distinction between hal and core will be > > > meaningless, so this is the first step towards simplifying the file > > > layout. > > > > > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > > > --- > > > drivers/staging/rtl8188eu/Makefile | 34 +++++++++---------- > > > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0 > > > .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0 > > > .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0 > > > .../rtl8188eu/{core => }/rtw_ieee80211.c | 0 > > > .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0 > > > .../staging/rtl8188eu/{core => }/rtw_iol.c | 0 > > > > > > I think this is just source churning. The current setup with include. core. > > hal and os_dep subdirectories are not opressive. > > > > Larry > > > > > > maybe the information we will need one day is: > > will the core/-os_dep/-hal/-include/-directory-structure be > welcomed in mainline wireless subsystem, when an rtl* driver > will be perfectly tuned? > > At the moment I can't see such a directory organization > in any of the realtek wireless driver. > > Sure there's time for that ;), > > Thank you, > > fabio > > Dear Fabio, Certainly a good start is removing this 'hal' layer so for now I'll focus on that as much as I can. Perhaps the path forwards will become clearer without it there :-) Thank you for your feedback. Regards, Phil ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-20 22:54 ` Phillip Potter @ 2021-07-21 7:51 ` Fabio Aiuto 0 siblings, 0 replies; 17+ messages in thread From: Fabio Aiuto @ 2021-07-21 7:51 UTC (permalink / raw) To: Phillip Potter Cc: gregkh, dan.carpenter, linux-kernel, linux-staging, Larry.Finger Dear Phillip, On Tue, Jul 20, 2021 at 11:54:43PM +0100, Phillip Potter wrote: > On Tue, Jul 20, 2021 at 11:00:36AM +0200, Fabio Aiuto wrote: > > Hi all, > > > > On Mon, Jul 19, 2021 at 06:46:16PM -0500, Larry Finger wrote: > > > On 7/19/21 5:46 PM, Phillip Potter wrote: > > > > Move all C source files from the core subdirectory to the root > > > > folder of the driver, and adjust Makefile accordingly. The ultmate > > > > goal is to remove hal layer and fold its functionalty into the main > > > > sources. At this point, the distinction between hal and core will be > > > > meaningless, so this is the first step towards simplifying the file > > > > layout. > > > > > > > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > > > > --- > > > > drivers/staging/rtl8188eu/Makefile | 34 +++++++++---------- > > > > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0 > > > > .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0 > > > > .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0 > > > > .../rtl8188eu/{core => }/rtw_ieee80211.c | 0 > > > > .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0 > > > > .../staging/rtl8188eu/{core => }/rtw_iol.c | 0 > > > > > > > > > I think this is just source churning. The current setup with include. core. > > > hal and os_dep subdirectories are not opressive. > > > > > > Larry > > > > > > > > > > maybe the information we will need one day is: > > > > will the core/-os_dep/-hal/-include/-directory-structure be > > welcomed in mainline wireless subsystem, when an rtl* driver > > will be perfectly tuned? > > > > At the moment I can't see such a directory organization > > in any of the realtek wireless driver. > > > > Sure there's time for that ;), > > > > Thank you, > > > > fabio > > > > > Dear Fabio, > > Certainly a good start is removing this 'hal' layer so for now I'll > focus on that as much as I can. Perhaps the path forwards will become > clearer without it there :-) Thank you for your feedback. Agreed > > Regards, > Phil thank you, fabio ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-20 9:00 ` Fabio Aiuto 2021-07-20 22:54 ` Phillip Potter @ 2021-07-21 0:22 ` Larry Finger 2021-07-21 7:47 ` Fabio Aiuto 2021-07-21 7:49 ` Phillip Potter 1 sibling, 2 replies; 17+ messages in thread From: Larry Finger @ 2021-07-21 0:22 UTC (permalink / raw) To: Fabio Aiuto Cc: Phillip Potter, gregkh, dan.carpenter, linux-kernel, linux-staging On 7/20/21 4:00 AM, Fabio Aiuto wrote: > maybe the information we will need one day is: > > will the core/-os_dep/-hal/-include/-directory-structure be > welcomed in mainline wireless subsystem, when an rtl* driver > will be perfectly tuned? > > At the moment I can't see such a directory organization > in any of the realtek wireless driver. > > Sure there's time for that;), The question is how much lipstick do you want to put on that pig? The current version does not use cfg80211, and it does not work with NetworkManager or a modern hostapd to create an AP. If you want to get the rtl8188eu driver in shape to be added to the regular drivers section, then I suggest you start with the v5.2.2.4 branch of https://github.com/lwfinger/rtl8188eu.git. Many users of the RTL8188EU chip use that driver. At least that version fixes the two problems listed above. If you want to flatten the directory structure, you can do it there and offline. I want to caution you that following this path will take a lot of time, but once you get it into kernel shape, it will at least be useful. I have never had the time, nor the ambition to undertake this effort. Larry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-21 0:22 ` Larry Finger @ 2021-07-21 7:47 ` Fabio Aiuto 2021-07-21 7:49 ` Phillip Potter 1 sibling, 0 replies; 17+ messages in thread From: Fabio Aiuto @ 2021-07-21 7:47 UTC (permalink / raw) To: Larry Finger Cc: Phillip Potter, gregkh, dan.carpenter, linux-kernel, linux-staging Hello Larry, On Tue, Jul 20, 2021 at 07:22:26PM -0500, Larry Finger wrote: > On 7/20/21 4:00 AM, Fabio Aiuto wrote: > > maybe the information we will need one day is: > > > > will the core/-os_dep/-hal/-include/-directory-structure be > > welcomed in mainline wireless subsystem, when an rtl* driver > > will be perfectly tuned? > > > > At the moment I can't see such a directory organization > > in any of the realtek wireless driver. > > > > Sure there's time for that;), > > The question is how much lipstick do you want to put on that pig? The > current version does not use cfg80211, and it does not work with > NetworkManager or a modern hostapd to create an AP. yes there's a lot of work to do... > > If you want to get the rtl8188eu driver in shape to be added to the regular > drivers section, then I suggest you start with the v5.2.2.4 branch of > https://github.com/lwfinger/rtl8188eu.git. Many users of the RTL8188EU chip > use that driver. At least that version fixes the two problems listed above. > If you want to flatten the directory structure, you can do it there and > offline. if there's a version closer to mainline (as lwfinger seems to be) why keeping the actual rtl8188eu on staging instead of the lwfinger one? > > I want to caution you that following this path will take a lot of time, but > once you get it into kernel shape, it will at least be useful. I have never > had the time, nor the ambition to undertake this effort. yes, I understand, it's taking a lot of time with rtl8723bs as well, but it's a good starting point for kernel newbies > > Larry > thank you, fabio ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-21 0:22 ` Larry Finger 2021-07-21 7:47 ` Fabio Aiuto @ 2021-07-21 7:49 ` Phillip Potter 2021-07-21 17:33 ` Larry Finger 1 sibling, 1 reply; 17+ messages in thread From: Phillip Potter @ 2021-07-21 7:49 UTC (permalink / raw) To: Larry Finger Cc: gregkh, dan.carpenter, linux-kernel, linux-staging, fabioaiuto83 On Tue, Jul 20, 2021 at 07:22:26PM -0500, Larry Finger wrote: > On 7/20/21 4:00 AM, Fabio Aiuto wrote: > > maybe the information we will need one day is: > > > > will the core/-os_dep/-hal/-include/-directory-structure be > > welcomed in mainline wireless subsystem, when an rtl* driver > > will be perfectly tuned? > > > > At the moment I can't see such a directory organization > > in any of the realtek wireless driver. > > > > Sure there's time for that;), > > The question is how much lipstick do you want to put on that pig? The > current version does not use cfg80211, and it does not work with > NetworkManager or a modern hostapd to create an AP. > > If you want to get the rtl8188eu driver in shape to be added to the regular > drivers section, then I suggest you start with the v5.2.2.4 branch of > https://github.com/lwfinger/rtl8188eu.git. Many users of the RTL8188EU chip > use that driver. At least that version fixes the two problems listed above. > If you want to flatten the directory structure, you can do it there and > offline. > > I want to caution you that following this path will take a lot of time, but > once you get it into kernel shape, it will at least be useful. I have never > had the time, nor the ambition to undertake this effort. > > Larry > Dear Larry, Whilst I (and no doubt others) are happy to look into what you've suggested, I do have a few questions: (1) Why is the version from github not the one in staging? (2) On a related note, working on it offline is difficult in terms of proving contributions, particularly for a kernel mentee such as myself. Might I suggest replacing this driver with the one you suggested entirely, so work on it can continue in public? I am happy to submit this and continue work if you think it would be viable. Many thanks and I appreciate your thoughts on this. Regards, Phil ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-21 7:49 ` Phillip Potter @ 2021-07-21 17:33 ` Larry Finger 2021-07-21 18:28 ` Dan Carpenter 0 siblings, 1 reply; 17+ messages in thread From: Larry Finger @ 2021-07-21 17:33 UTC (permalink / raw) To: Phillip Potter Cc: gregkh, dan.carpenter, linux-kernel, linux-staging, fabioaiuto83 On 7/21/21 2:49 AM, Phillip Potter wrote: > Dear Larry, > > Whilst I (and no doubt others) are happy to look into what you've > suggested, I do have a few questions: > (1) Why is the version from github not the one in staging? > (2) On a related note, working on it offline is difficult in terms of > proving contributions, particularly for a kernel mentee such as myself. > > Might I suggest replacing this driver with the one you suggested > entirely, so work on it can continue in public? I am happy to submit > this and continue work if you think it would be viable. Many thanks and > I appreciate your thoughts on this. The reason that the newer driver is at GitHub, rather than in the kernel, is that I never want to devote the 6 months needed to get it into the shape of the old one that I did send to staging. If you take a little time to look at the GitHub code, you will see what I mean. I did this once before only to have Realtek release a new version with all the old warts again. At least we have the fact that this is a heritage product, and Realtek will not be releasing any newer drivers. As is, the code generates very few sparse warnings, but it still contains a number of local CONFIG variables that would never be accepted in the kernel. It also contains a large number of module parameters that need to be evaluated and likely removed. If you wish, I will give you write access to the GitHub repo so that you can make changes there. The numerous users will give you instant feedback if/when you break something. If you want to use it to replace the kernel version, go ahead. I promise that I will not give negative reviews, but I am sure others will have such comments. In any case, I will continue to maintain my repo. There are too many users with old kernels, and the backports project is difficult to use for their level of expertise. Larry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-21 17:33 ` Larry Finger @ 2021-07-21 18:28 ` Dan Carpenter 2021-07-21 19:18 ` Larry Finger 0 siblings, 1 reply; 17+ messages in thread From: Dan Carpenter @ 2021-07-21 18:28 UTC (permalink / raw) To: Larry Finger Cc: Phillip Potter, gregkh, linux-kernel, linux-staging, fabioaiuto83 On Wed, Jul 21, 2021 at 12:33:28PM -0500, Larry Finger wrote: > On 7/21/21 2:49 AM, Phillip Potter wrote: > > Dear Larry, > > > > Whilst I (and no doubt others) are happy to look into what you've > > suggested, I do have a few questions: > > (1) Why is the version from github not the one in staging? > > (2) On a related note, working on it offline is difficult in terms of > > proving contributions, particularly for a kernel mentee such as myself. > > > > Might I suggest replacing this driver with the one you suggested > > entirely, so work on it can continue in public? I am happy to submit > > this and continue work if you think it would be viable. Many thanks and > > I appreciate your thoughts on this. > > The reason that the newer driver is at GitHub, rather than in the kernel, is > that I never want to devote the 6 months needed to get it into the shape of > the old one that I did send to staging. If you take a little time to look at > the GitHub code, you will see what I mean. I did this once before only to > have Realtek release a new version with all the old warts again. At least we > have the fact that this is a heritage product, and Realtek will not be > releasing any newer drivers. You're obviously not a Realtek employee, but what are they doing for wireless drivers these days? regards, dan carpenter ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-21 18:28 ` Dan Carpenter @ 2021-07-21 19:18 ` Larry Finger 2021-07-22 10:44 ` Phillip Potter 0 siblings, 1 reply; 17+ messages in thread From: Larry Finger @ 2021-07-21 19:18 UTC (permalink / raw) To: Dan Carpenter Cc: Phillip Potter, gregkh, linux-kernel, linux-staging, fabioaiuto83 On 7/21/21 1:28 PM, Dan Carpenter wrote: > You're obviously not a Realtek employee, but what are they doing for > wireless drivers these days? You are correct in that I am not a Realtek employee, nor do I have any knowledge of the internals of any of their chips. I do have a close working arrangement with the head of their PCI driver development, and I have gotten free samples of some of their chips. I am a volunteer that is interested in providing drivers for the devices in new laptops with wireless chips that do not yet have a Linux driver in the kernel. I also provide relatively modern drivers for older USB devices through GitHub repos. From what I know, the PCI group at Realtek is mainly working on new 802.11ac devices, but are leaving some hooks for the USB and SDIO equivalents of those chips (RTL8822BE, RTL8822CE, RTL8821CE, RTL8723DE, and RTL8852AE). These drivers are either in the drivers/net/wireless tree of the kernel, or are under review for such inclusion. I have no current contact with the USB part of their driver development. Larry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-21 19:18 ` Larry Finger @ 2021-07-22 10:44 ` Phillip Potter 2021-07-22 13:28 ` Greg KH 0 siblings, 1 reply; 17+ messages in thread From: Phillip Potter @ 2021-07-22 10:44 UTC (permalink / raw) To: Larry Finger Cc: Dan Carpenter, Greg KH, Linux Kernel Mailing List, linux-staging, Fabio Aiuto On Wed, 21 Jul 2021 at 20:18, Larry Finger <Larry.Finger@lwfinger.net> wrote: > > On 7/21/21 1:28 PM, Dan Carpenter wrote: > > You're obviously not a Realtek employee, but what are they doing for > > wireless drivers these days? > > You are correct in that I am not a Realtek employee, nor do I have any knowledge > of the internals of any of their chips. I do have a close working arrangement > with the head of their PCI driver development, and I have gotten free samples of > some of their chips. I am a volunteer that is interested in providing drivers > for the devices in new laptops with wireless chips that do not yet have a Linux > driver in the kernel. I also provide relatively modern drivers for older USB > devices through GitHub repos. > > From what I know, the PCI group at Realtek is mainly working on new 802.11ac > devices, but are leaving some hooks for the USB and SDIO equivalents of those > chips (RTL8822BE, RTL8822CE, RTL8821CE, RTL8723DE, and RTL8852AE). These drivers > are either in the drivers/net/wireless tree of the kernel, or are under review > for such inclusion. > > I have no current contact with the USB part of their driver development. > > Larry > > Dear Larry, Thank you for this info, it's very useful. Are you saying that in its current state the GitHub driver would not even be accepted into staging in your opinion? I am happy to continue improving it, but in my mind this should probably be done publicly, within the kernel tree. Not sure what others think but if there is general consensus then I can submit this new version to staging and integrate within build framework etc, then we can start improving it and getting it ready to move beyond that. Sounds like your driver is further along the path, and we should be using it, but I'm interested in what others think of course. Regards, Phil ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-22 10:44 ` Phillip Potter @ 2021-07-22 13:28 ` Greg KH 2021-07-22 16:30 ` Larry Finger 0 siblings, 1 reply; 17+ messages in thread From: Greg KH @ 2021-07-22 13:28 UTC (permalink / raw) To: Phillip Potter Cc: Larry Finger, Dan Carpenter, Linux Kernel Mailing List, linux-staging, Fabio Aiuto On Thu, Jul 22, 2021 at 11:44:10AM +0100, Phillip Potter wrote: > On Wed, 21 Jul 2021 at 20:18, Larry Finger <Larry.Finger@lwfinger.net> wrote: > > > > On 7/21/21 1:28 PM, Dan Carpenter wrote: > > > You're obviously not a Realtek employee, but what are they doing for > > > wireless drivers these days? > > > > You are correct in that I am not a Realtek employee, nor do I have any knowledge > > of the internals of any of their chips. I do have a close working arrangement > > with the head of their PCI driver development, and I have gotten free samples of > > some of their chips. I am a volunteer that is interested in providing drivers > > for the devices in new laptops with wireless chips that do not yet have a Linux > > driver in the kernel. I also provide relatively modern drivers for older USB > > devices through GitHub repos. > > > > From what I know, the PCI group at Realtek is mainly working on new 802.11ac > > devices, but are leaving some hooks for the USB and SDIO equivalents of those > > chips (RTL8822BE, RTL8822CE, RTL8821CE, RTL8723DE, and RTL8852AE). These drivers > > are either in the drivers/net/wireless tree of the kernel, or are under review > > for such inclusion. > > > > I have no current contact with the USB part of their driver development. > > > > Larry > > > > > Dear Larry, > > Thank you for this info, it's very useful. Are you saying that in its > current state the GitHub driver would not even be accepted into > staging in your opinion? I am happy to continue improving it, but in > my mind this should probably be done publicly, within the kernel tree. > Not sure what others think but if there is general consensus then I > can submit this new version to staging and integrate within build > framework etc, then we can start improving it and getting it ready to > move beyond that. Sounds like your driver is further along the path, > and we should be using it, but I'm interested in what others think of > course. If the code looks "better", I have no objection to just adding it to drivers/staging/ and deleting the existing one here, so that everyone can work on this together in one single place. Larry, any objection to that? thanks, greg k-h ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-22 13:28 ` Greg KH @ 2021-07-22 16:30 ` Larry Finger 2021-07-22 22:12 ` Phillip Potter 0 siblings, 1 reply; 17+ messages in thread From: Larry Finger @ 2021-07-22 16:30 UTC (permalink / raw) To: Greg KH, Phillip Potter Cc: Dan Carpenter, Linux Kernel Mailing List, linux-staging, Fabio Aiuto On 7/22/21 8:28 AM, Greg KH wrote: > If the code looks "better", I have no objection to just adding it to > drivers/staging/ and deleting the existing one here, so that everyone > can work on this together in one single place. > > Larry, any objection to that? I am not opposed to that. Do you want me to supply the new driver as a set of patches, or would someone else like to do it? Larry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-22 16:30 ` Larry Finger @ 2021-07-22 22:12 ` Phillip Potter 0 siblings, 0 replies; 17+ messages in thread From: Phillip Potter @ 2021-07-22 22:12 UTC (permalink / raw) To: Larry Finger Cc: Greg KH, Dan Carpenter, Linux Kernel Mailing List, linux-staging, Fabio Aiuto On Thu, 22 Jul 2021 at 17:31, Larry Finger <Larry.Finger@lwfinger.net> wrote: > > On 7/22/21 8:28 AM, Greg KH wrote: > > If the code looks "better", I have no objection to just adding it to > > drivers/staging/ and deleting the existing one here, so that everyone > > can work on this together in one single place. > > > > Larry, any objection to that? > > I am not opposed to that. Do you want me to supply the new driver as a set of > patches, or would someone else like to do it? > > Larry > I am happy to do it. Two patches seems sensible - one to remove the current driver from staging and another to introduce the new one. Regards, Phil ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-19 23:46 ` Larry Finger 2021-07-20 9:00 ` Fabio Aiuto @ 2021-07-20 22:51 ` Phillip Potter 1 sibling, 0 replies; 17+ messages in thread From: Phillip Potter @ 2021-07-20 22:51 UTC (permalink / raw) To: Larry Finger; +Cc: dan.carpenter, linux-kernel, linux-staging, gregkh On Mon, Jul 19, 2021 at 06:46:16PM -0500, Larry Finger wrote: > On 7/19/21 5:46 PM, Phillip Potter wrote: > > Move all C source files from the core subdirectory to the root > > folder of the driver, and adjust Makefile accordingly. The ultmate > > goal is to remove hal layer and fold its functionalty into the main > > sources. At this point, the distinction between hal and core will be > > meaningless, so this is the first step towards simplifying the file > > layout. > > > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > > --- > > drivers/staging/rtl8188eu/Makefile | 34 +++++++++---------- > > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0 > > .../rtl8188eu/{core => }/rtw_ieee80211.c | 0 > > .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_iol.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_led.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_mlme.c | 0 > > .../rtl8188eu/{core => }/rtw_mlme_ext.c | 0 > > .../rtl8188eu/{core => }/rtw_pwrctrl.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_recv.c | 0 > > drivers/staging/rtl8188eu/{core => }/rtw_rf.c | 0 > > .../rtl8188eu/{core => }/rtw_security.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_sreset.c | 0 > > .../rtl8188eu/{core => }/rtw_sta_mgt.c | 0 > > .../rtl8188eu/{core => }/rtw_wlan_util.c | 0 > > .../staging/rtl8188eu/{core => }/rtw_xmit.c | 0 > > 18 files changed, 17 insertions(+), 17 deletions(-) > > rename drivers/staging/rtl8188eu/{core => }/rtw_ap.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_cmd.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_efuse.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_ieee80211.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_ioctl_set.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_iol.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_led.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_mlme.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_mlme_ext.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_pwrctrl.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_recv.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_rf.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_security.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_sreset.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_sta_mgt.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_wlan_util.c (100%) > > rename drivers/staging/rtl8188eu/{core => }/rtw_xmit.c (100%) > > > > diff --git a/drivers/staging/rtl8188eu/Makefile b/drivers/staging/rtl8188eu/Makefile > > index 28b936e8be0a..2dad13bdbdeb 100644 > > --- a/drivers/staging/rtl8188eu/Makefile > > +++ b/drivers/staging/rtl8188eu/Makefile > > @@ -1,22 +1,22 @@ > > # SPDX-License-Identifier: GPL-2.0 > > r8188eu-y := \ > > - core/rtw_ap.o \ > > - core/rtw_cmd.o \ > > - core/rtw_efuse.o \ > > - core/rtw_ieee80211.o \ > > - core/rtw_ioctl_set.o \ > > - core/rtw_iol.o \ > > - core/rtw_led.o \ > > - core/rtw_mlme.o \ > > - core/rtw_mlme_ext.o \ > > - core/rtw_pwrctrl.o \ > > - core/rtw_recv.o \ > > - core/rtw_rf.o \ > > - core/rtw_security.o \ > > - core/rtw_sreset.o \ > > - core/rtw_sta_mgt.o \ > > - core/rtw_wlan_util.o \ > > - core/rtw_xmit.o \ > > + rtw_ap.o \ > > + rtw_cmd.o \ > > + rtw_efuse.o \ > > + rtw_ieee80211.o \ > > + rtw_ioctl_set.o \ > > + rtw_iol.o \ > > + rtw_led.o \ > > + rtw_mlme.o \ > > + rtw_mlme_ext.o \ > > + rtw_pwrctrl.o \ > > + rtw_recv.o \ > > + rtw_rf.o \ > > + rtw_security.o \ > > + rtw_sreset.o \ > > + rtw_sta_mgt.o \ > > + rtw_wlan_util.o \ > > + rtw_xmit.o \ > > hal/fw.o \ > > hal/mac_cfg.o \ > > hal/bb_cfg.o \ > > diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/rtw_ap.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_ap.c > > rename to drivers/staging/rtl8188eu/rtw_ap.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/rtw_cmd.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_cmd.c > > rename to drivers/staging/rtl8188eu/rtw_cmd.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/rtw_efuse.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_efuse.c > > rename to drivers/staging/rtl8188eu/rtw_efuse.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/rtw_ieee80211.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_ieee80211.c > > rename to drivers/staging/rtl8188eu/rtw_ieee80211.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/rtw_ioctl_set.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c > > rename to drivers/staging/rtl8188eu/rtw_ioctl_set.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/rtw_iol.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_iol.c > > rename to drivers/staging/rtl8188eu/rtw_iol.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/rtw_led.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_led.c > > rename to drivers/staging/rtl8188eu/rtw_led.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/rtw_mlme.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_mlme.c > > rename to drivers/staging/rtl8188eu/rtw_mlme.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/rtw_mlme_ext.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > > rename to drivers/staging/rtl8188eu/rtw_mlme_ext.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/rtw_pwrctrl.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_pwrctrl.c > > rename to drivers/staging/rtl8188eu/rtw_pwrctrl.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/rtw_recv.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_recv.c > > rename to drivers/staging/rtl8188eu/rtw_recv.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_rf.c b/drivers/staging/rtl8188eu/rtw_rf.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_rf.c > > rename to drivers/staging/rtl8188eu/rtw_rf.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/rtw_security.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_security.c > > rename to drivers/staging/rtl8188eu/rtw_security.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c b/drivers/staging/rtl8188eu/rtw_sreset.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_sreset.c > > rename to drivers/staging/rtl8188eu/rtw_sreset.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/rtw_sta_mgt.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > > rename to drivers/staging/rtl8188eu/rtw_sta_mgt.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/rtw_wlan_util.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_wlan_util.c > > rename to drivers/staging/rtl8188eu/rtw_wlan_util.c > > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/rtw_xmit.c > > similarity index 100% > > rename from drivers/staging/rtl8188eu/core/rtw_xmit.c > > rename to drivers/staging/rtl8188eu/rtw_xmit.c > > > > I think this is just source churning. The current setup with include. core. > hal and os_dep subdirectories are not opressive. > > Larry > Dear Larry, Thank you for your feedback. I will focus on utilising the existing folder structure in that case, with a view towards reducing/removing the 'hal' folder and reintegrating its code. Regards, Phil ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory 2021-07-19 22:46 [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory Phillip Potter 2021-07-19 23:46 ` Larry Finger @ 2021-07-21 8:16 ` Greg KH 1 sibling, 0 replies; 17+ messages in thread From: Greg KH @ 2021-07-21 8:16 UTC (permalink / raw) To: Phillip Potter; +Cc: Larry.Finger, dan.carpenter, linux-kernel, linux-staging On Mon, Jul 19, 2021 at 11:46:01PM +0100, Phillip Potter wrote: > Move all C source files from the core subdirectory to the root > folder of the driver, and adjust Makefile accordingly. The ultmate > goal is to remove hal layer and fold its functionalty into the main > sources. At this point, the distinction between hal and core will be > meaningless, so this is the first step towards simplifying the file > layout. > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > --- > drivers/staging/rtl8188eu/Makefile | 34 +++++++++---------- > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0 <snip> As others have pointed out, let's move files when they need to be moved, not yet. Removing the HAL layer is great here, but when that happens, the hal/ directory will be empty and we can go from there if things still need to be moved. thanks, greg k-h ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-07-22 22:12 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-07-19 22:46 [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory Phillip Potter 2021-07-19 23:46 ` Larry Finger 2021-07-20 9:00 ` Fabio Aiuto 2021-07-20 22:54 ` Phillip Potter 2021-07-21 7:51 ` Fabio Aiuto 2021-07-21 0:22 ` Larry Finger 2021-07-21 7:47 ` Fabio Aiuto 2021-07-21 7:49 ` Phillip Potter 2021-07-21 17:33 ` Larry Finger 2021-07-21 18:28 ` Dan Carpenter 2021-07-21 19:18 ` Larry Finger 2021-07-22 10:44 ` Phillip Potter 2021-07-22 13:28 ` Greg KH 2021-07-22 16:30 ` Larry Finger 2021-07-22 22:12 ` Phillip Potter 2021-07-20 22:51 ` Phillip Potter 2021-07-21 8:16 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).