linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ashish Kalra <eashishkalra@gmail.com>
Cc: Abheek Dhawan <adawesomeguy222@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Romain Perier <romain.perier@gmail.com>,
	Waiman Long <longman@redhat.com>,
	Allen Pais <apais@linux.microsoft.com>,
	Ivan Safonov <insafonov@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warning
Date: Thu, 22 Apr 2021 10:43:13 +0200	[thread overview]
Message-ID: <YIE3IffGcjrkz4ZE@kroah.com> (raw)
In-Reply-To: <20210420090142.GA4086@ashish-NUC8i5BEH>

On Tue, Apr 20, 2021 at 02:31:42PM +0530, Ashish Kalra wrote:
> Upon running sparse, "warning: incorrect type in argument 1 (different address spaces)
> is brought to notice for this file.let's add correct typecast to make it cleaner and
> silence the Sparse warning.
> 
> Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
> ---
>  drivers/staging/wlan-ng/p80211netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
> index 6f9666dc0277..70570e8a5ad2 100644
> --- a/drivers/staging/wlan-ng/p80211netdev.c
> +++ b/drivers/staging/wlan-ng/p80211netdev.c
> @@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
>  		goto bail;
>  	}
>  
> -	msgbuf = memdup_user(req->data, req->len);
> +	msgbuf = memdup_user((void __user *)req->data, req->len);

Why isn't data being declared as a __user pointer to start with?  Why is
the cast needed here?

This feels wrong as if it is papering over the real problem.

thanks,

greg k-h

  reply	other threads:[~2021-04-22  8:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  9:01 [PATCH] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warning Ashish Kalra
2021-04-22  8:43 ` Greg Kroah-Hartman [this message]
2021-04-23 15:26   ` Ashish Kalra
2021-04-24  5:59     ` Greg Kroah-Hartman
2021-04-24  6:00     ` Greg Kroah-Hartman
2021-04-24  6:11       ` Joe Perches
2021-04-24  8:15         ` Ashish Kalra
2021-04-24  8:28           ` Greg Kroah-Hartman
2021-04-27 12:23             ` ashish
2021-04-27 12:39               ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIE3IffGcjrkz4ZE@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adawesomeguy222@gmail.com \
    --cc=apais@linux.microsoft.com \
    --cc=eashishkalra@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=longman@redhat.com \
    --cc=romain.perier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).