From: ashish <eashishkalra@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ashish Kalra <eashishkalra@gmail.com>,
Joe Perches <joe@perches.com>,
Abheek Dhawan <adawesomeguy222@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Romain Perier <romain.perier@gmail.com>,
Waiman Long <longman@redhat.com>,
Allen Pais <apais@linux.microsoft.com>,
Ivan Safonov <insafonov@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warning
Date: Tue, 27 Apr 2021 17:53:30 +0530 [thread overview]
Message-ID: <YIgCQtwK8tpGSOQ5@ashish-NUC8i5BEH> (raw)
In-Reply-To: <YIPWq6rp246rg9D0@kroah.com>
On Sat, Apr 24, 2021 at 10:28:27AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 24, 2021 at 01:45:29PM +0530, Ashish Kalra wrote:
> > On Fri, Apr 23, 2021 at 11:11:05PM -0700, Joe Perches wrote:
> > > On Sat, 2021-04-24 at 08:00 +0200, Greg Kroah-Hartman wrote:
> > > > On Fri, Apr 23, 2021 at 08:56:19PM +0530, Ashish Kalra wrote:
> > > > > On Thu, Apr 22, 2021 at 10:43:13AM +0200, Greg Kroah-Hartman wrote:
> > > > > > On Tue, Apr 20, 2021 at 02:31:42PM +0530, Ashish Kalra wrote:
> > > > > > > Upon running sparse, "warning: incorrect type in argument 1 (different address spaces)
> > > > > > > is brought to notice for this file.let's add correct typecast to make it cleaner and
> > > > > > > silence the Sparse warning.
> > > []
> > > > > struct p80211ioctl_req {
> > > > > char name[WLAN_DEVNAMELEN_MAX];
> > > > > - caddr_t data;
> > > > > + void __user *data;
> > > > >
> > > > > Does this looks ok to you and is there any other check possible if this is ok?
> > > >
> > > > Wait, what is "caddr_t"? Try unwinding that mess first...
> > >
> > > Might not be that simple.
> > >
> > > include/linux/types.h:typedef __kernel_caddr_t caddr_t;
> > > include/uapi/linux/coda.h:typedef void * caddr_t;
> > > include/uapi/asm-generic/posix_types.h:typedef char * __kernel_caddr_t;
> > >
> > >
> > data is part of p80211ioctl_req and is used at two places only inside p80211knetdev_do_ioctl
> > it seems both places it will be used as void __user* only
> >
> > msgbuf = memdup_user(req->data, req->len);
> >
> > if (result == 0) {
> > if (copy_to_user
> > ((void __user *)req->data, msgbuf, req->len)) {
> > result = -EFAULT;
> > }
> > }
> >
> > Will it still be problem if we change it from char * to void *.?
>
> Why do you want to change it to void *? Never use a void * unless it
> has to point to unknown data. That does not seem the case here.
>
> > is there any way to check how caller of this function will be using it?
>
> Look at the code to determine this...
>
> thanks,
>
> greg k-h
Thanks Greg and Joe
I have found that adding __user to data is also fixing this warning,
It should be fine logically to make this change
Please share your opinion and will post v2 for this patch
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -81,7 +81,7 @@
struct p80211ioctl_req {
char name[WLAN_DEVNAMELEN_MAX];
- caddr_t data;
+ char __user *data;
u32 magic;
u16 len;
u32 result;
--
2.30.2
next prev parent reply other threads:[~2021-04-27 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 9:01 [PATCH] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) warning Ashish Kalra
2021-04-22 8:43 ` Greg Kroah-Hartman
2021-04-23 15:26 ` Ashish Kalra
2021-04-24 5:59 ` Greg Kroah-Hartman
2021-04-24 6:00 ` Greg Kroah-Hartman
2021-04-24 6:11 ` Joe Perches
2021-04-24 8:15 ` Ashish Kalra
2021-04-24 8:28 ` Greg Kroah-Hartman
2021-04-27 12:23 ` ashish [this message]
2021-04-27 12:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIgCQtwK8tpGSOQ5@ashish-NUC8i5BEH \
--to=eashishkalra@gmail.com \
--cc=adawesomeguy222@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=insafonov@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=longman@redhat.com \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).