From: Chanwoo Choi <cw00.choi@samsung.com>
To: Samuel Holland <samuel@sholland.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: arm: sunxi: Expand MBUS binding
Date: Fri, 15 Oct 2021 17:37:29 +0900 [thread overview]
Message-ID: <07410362-a37b-b6e4-5b6e-a39daa6c22e7@samsung.com> (raw)
In-Reply-To: <20211004012739.39053-3-samuel@sholland.org>
On 10/4/21 10:27 AM, Samuel Holland wrote:
> The MBUS provides more than address translation and bandwidth control.
> It also provides a PMU to measure bandwidth usage by certain masters,
> and it provides notification via IRQ when they are active or idle.
>
> The MBUS is also tightly integrated with the DRAM controller to provide
> a Memory Dynamic Frequency Scaling (MDFS) feature. In view of this, the
> MBUS binding needs to represent the hardware resources needed for MDFS,
> which include the clocks and MMIO range of the adjacent DRAM controller.
>
> Add the additional resources for the H3 and A64 compatibles, and a new
> example showing how they are used.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> .../arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 75 ++++++++++++++++++-
> 1 file changed, 72 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> index e713a6fe4cf7..c1fb404d2fb3 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> @@ -33,10 +33,33 @@ properties:
> - allwinner,sun50i-a64-mbus
>
> reg:
> - maxItems: 1
> + minItems: 1
> + items:
> + - description: MBUS interconnect/bandwidth/PMU registers
> + - description: DRAM controller/PHY registers
> +
> + reg-names:
> + items:
> + - const: "mbus"
> + - const: "dram"
>
> clocks:
> + minItems: 1
> + items:
> + - description: MBUS interconnect module clock
> + - description: DRAM controller/PHY module clock
> + - description: Register bus clock, shared by MBUS and DRAM
> +
> + clock-names:
> + items:
> + - const: "mbus"
> + - const: "dram"
> + - const: "bus"
> +
> + interrupts:
> maxItems: 1
> + description:
> + MBUS PMU activity interrupt.
>
> dma-ranges:
> description:
> @@ -53,13 +76,42 @@ required:
> - clocks
> - dma-ranges
>
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - allwinner,sun8i-h3-mbus
> + - allwinner,sun50i-a64-mbus
> +
> +then:
> + properties:
> + reg:
> + minItems: 2
> +
> + clocks:
> + minItems: 3
> +
> + required:
> + - reg-names
> + - clock-names
> +
> +else:
> + properties:
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/clock/sun5i-ccu.h>
> + #include <dt-bindings/clock/sun50i-a64-ccu.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> - mbus: dram-controller@1c01000 {
> + dram-controller@1c01000 {
> compatible = "allwinner,sun5i-a13-mbus";
> reg = <0x01c01000 0x1000>;
> clocks = <&ccu CLK_MBUS>;
> @@ -69,4 +121,21 @@ examples:
> #interconnect-cells = <1>;
> };
>
> + - |
> + dram-controller@1c62000 {
> + compatible = "allwinner,sun50i-a64-mbus";
> + reg = <0x01c62000 0x1000>,
> + <0x01c63000 0x1000>;
> + reg-names = "mbus", "dram";
> + clocks = <&ccu CLK_MBUS>,
> + <&ccu CLK_DRAM>,
> + <&ccu CLK_BUS_DRAM>;
> + clock-names = "mbus", "dram", "bus";
> + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + dma-ranges = <0x00000000 0x40000000 0xc0000000>;
> + #interconnect-cells = <1>;
> + };
> +
> ...
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2021-10-15 8:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 1:27 [PATCH v2 0/6] DRAM devfreq support for Allwinner A64/H5 Samuel Holland
2021-10-04 1:27 ` [PATCH v2 1/6] dt-bindings: clock: sunxi: Export CLK_DRAM for devfreq Samuel Holland
2021-10-12 1:07 ` Rob Herring
2021-10-15 1:40 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 2/6] dt-bindings: arm: sunxi: Expand MBUS binding Samuel Holland
2021-10-12 1:10 ` Rob Herring
2021-10-15 8:37 ` Chanwoo Choi [this message]
2021-10-04 1:27 ` [PATCH v2 3/6] dt-bindings: arm: sunxi: Add H5 MBUS compatible Samuel Holland
2021-10-04 12:21 ` Rob Herring
2021-10-14 16:33 ` Rob Herring
2021-10-04 1:27 ` [PATCH v2 4/6] ARM: dts: sunxi: h3/h5: Update MBUS node Samuel Holland
2021-10-15 8:29 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 5/6] arm64: dts: allwinner: a64: " Samuel Holland
2021-10-15 8:29 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 6/6] PM / devfreq: Add a driver for the sun8i/sun50i MBUS Samuel Holland
2021-10-15 8:28 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07410362-a37b-b6e4-5b6e-a39daa6c22e7@samsung.com \
--to=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).