From: Chanwoo Choi <cw00.choi@samsung.com>
To: Samuel Holland <samuel@sholland.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: clock: sunxi: Export CLK_DRAM for devfreq
Date: Fri, 15 Oct 2021 10:40:56 +0900 [thread overview]
Message-ID: <a48923b7-12f9-808e-1171-49b826bd5f1c@samsung.com> (raw)
In-Reply-To: <20211004012739.39053-2-samuel@sholland.org>
On 10/4/21 10:27 AM, Samuel Holland wrote:
> The MBUS node needs to reference the CLK_DRAM clock, as the MBUS
> hardware implements memory dynamic frequency scaling using this clock.
>
> Export this clock for SoCs which will be getting a devfreq driver.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> drivers/clk/sunxi-ng/ccu-sun50i-a64.h | 2 --
> drivers/clk/sunxi-ng/ccu-sun8i-h3.h | 2 --
> include/dt-bindings/clock/sun50i-a64-ccu.h | 2 +-
> include/dt-bindings/clock/sun8i-h3-ccu.h | 2 +-
> 4 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.h b/drivers/clk/sunxi-ng/ccu-sun50i-a64.h
> index 54d1f96f4b68..a8c11c0b4e06 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.h
> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.h
> @@ -51,8 +51,6 @@
>
> #define CLK_USB_OHCI1_12M 92
>
> -#define CLK_DRAM 94
> -
> /* All the DRAM gates are exported */
>
> /* And the DSI and GPU module clock is exported */
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-h3.h b/drivers/clk/sunxi-ng/ccu-sun8i-h3.h
> index d8c38447e11b..e13f3c4b57d0 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-h3.h
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-h3.h
> @@ -42,8 +42,6 @@
>
> /* The first bunch of module clocks are exported */
>
> -#define CLK_DRAM 96
> -
> /* All the DRAM gates are exported */
>
> /* Some more module clocks are exported */
> diff --git a/include/dt-bindings/clock/sun50i-a64-ccu.h b/include/dt-bindings/clock/sun50i-a64-ccu.h
> index 318eb15c414c..175892189e9d 100644
> --- a/include/dt-bindings/clock/sun50i-a64-ccu.h
> +++ b/include/dt-bindings/clock/sun50i-a64-ccu.h
> @@ -113,7 +113,7 @@
> #define CLK_USB_OHCI0 91
>
> #define CLK_USB_OHCI1 93
> -
> +#define CLK_DRAM 94
> #define CLK_DRAM_VE 95
> #define CLK_DRAM_CSI 96
> #define CLK_DRAM_DEINTERLACE 97
> diff --git a/include/dt-bindings/clock/sun8i-h3-ccu.h b/include/dt-bindings/clock/sun8i-h3-ccu.h
> index 30d2d15373a2..5d4ada2c22e6 100644
> --- a/include/dt-bindings/clock/sun8i-h3-ccu.h
> +++ b/include/dt-bindings/clock/sun8i-h3-ccu.h
> @@ -126,7 +126,7 @@
> #define CLK_USB_OHCI1 93
> #define CLK_USB_OHCI2 94
> #define CLK_USB_OHCI3 95
> -
> +#define CLK_DRAM 96
> #define CLK_DRAM_VE 97
> #define CLK_DRAM_CSI 98
> #define CLK_DRAM_DEINTERLACE 99
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2021-10-15 1:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 1:27 [PATCH v2 0/6] DRAM devfreq support for Allwinner A64/H5 Samuel Holland
2021-10-04 1:27 ` [PATCH v2 1/6] dt-bindings: clock: sunxi: Export CLK_DRAM for devfreq Samuel Holland
2021-10-12 1:07 ` Rob Herring
2021-10-15 1:40 ` Chanwoo Choi [this message]
2021-10-04 1:27 ` [PATCH v2 2/6] dt-bindings: arm: sunxi: Expand MBUS binding Samuel Holland
2021-10-12 1:10 ` Rob Herring
2021-10-15 8:37 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 3/6] dt-bindings: arm: sunxi: Add H5 MBUS compatible Samuel Holland
2021-10-04 12:21 ` Rob Herring
2021-10-14 16:33 ` Rob Herring
2021-10-04 1:27 ` [PATCH v2 4/6] ARM: dts: sunxi: h3/h5: Update MBUS node Samuel Holland
2021-10-15 8:29 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 5/6] arm64: dts: allwinner: a64: " Samuel Holland
2021-10-15 8:29 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 6/6] PM / devfreq: Add a driver for the sun8i/sun50i MBUS Samuel Holland
2021-10-15 8:28 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a48923b7-12f9-808e-1171-49b826bd5f1c@samsung.com \
--to=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).