From: Chanwoo Choi <cw00.choi@samsung.com>
To: Samuel Holland <samuel@sholland.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] ARM: dts: sunxi: h3/h5: Update MBUS node
Date: Fri, 15 Oct 2021 17:29:48 +0900 [thread overview]
Message-ID: <435d622b-4ad9-d9d5-3c9b-7b66304e42e4@samsung.com> (raw)
In-Reply-To: <20211004012739.39053-5-samuel@sholland.org>
On 10/4/21 10:27 AM, Samuel Holland wrote:
> In order to support memory dynamic frequency scaling (MDFS), the MBUS
> binding now requires enumerating more resources. Provide them in the
> device tree.
>
> Since the H3 and H5 have different clock divider limits, they need
> separate compatibles.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 4 ++++
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 11 ++++++++---
> arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 4 ++++
> 3 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 4e89701df91f..43acb98cf390 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -282,6 +282,10 @@ &display_clocks {
> compatible = "allwinner,sun8i-h3-de2-clk";
> };
>
> +&mbus {
> + compatible = "allwinner,sun8i-h3-mbus";
> +};
> +
> &mmc0 {
> compatible = "allwinner,sun7i-a20-mmc";
> clocks = <&ccu CLK_BUS_MMC0>,
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index c7428df9469e..3a683e190dab 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -568,9 +568,14 @@ external_mdio: mdio@2 {
> };
>
> mbus: dram-controller@1c62000 {
> - compatible = "allwinner,sun8i-h3-mbus";
> - reg = <0x01c62000 0x1000>;
> - clocks = <&ccu CLK_MBUS>;
> + /* compatible is in per SoC .dtsi file */
> + reg = <0x01c62000 0x1000>,
> + <0x01c63000 0x1000>;
> + reg-names = "mbus", "dram";
> + clocks = <&ccu CLK_MBUS>,
> + <&ccu CLK_DRAM>,
> + <&ccu CLK_BUS_DRAM>;
> + clock-names = "mbus", "dram", "bus";
> #address-cells = <1>;
> #size-cells = <1>;
> dma-ranges = <0x00000000 0x40000000 0xc0000000>;
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> index 578a63dedf46..35d5d238e313 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> @@ -233,6 +233,10 @@ &display_clocks {
> compatible = "allwinner,sun50i-h5-de2-clk";
> };
>
> +&mbus {
> + compatible = "allwinner,sun50i-h5-mbus";
> +};
> +
> &mmc0 {
> compatible = "allwinner,sun50i-h5-mmc",
> "allwinner,sun50i-a64-mmc";
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2021-10-15 8:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 1:27 [PATCH v2 0/6] DRAM devfreq support for Allwinner A64/H5 Samuel Holland
2021-10-04 1:27 ` [PATCH v2 1/6] dt-bindings: clock: sunxi: Export CLK_DRAM for devfreq Samuel Holland
2021-10-12 1:07 ` Rob Herring
2021-10-15 1:40 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 2/6] dt-bindings: arm: sunxi: Expand MBUS binding Samuel Holland
2021-10-12 1:10 ` Rob Herring
2021-10-15 8:37 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 3/6] dt-bindings: arm: sunxi: Add H5 MBUS compatible Samuel Holland
2021-10-04 12:21 ` Rob Herring
2021-10-14 16:33 ` Rob Herring
2021-10-04 1:27 ` [PATCH v2 4/6] ARM: dts: sunxi: h3/h5: Update MBUS node Samuel Holland
2021-10-15 8:29 ` Chanwoo Choi [this message]
2021-10-04 1:27 ` [PATCH v2 5/6] arm64: dts: allwinner: a64: " Samuel Holland
2021-10-15 8:29 ` Chanwoo Choi
2021-10-04 1:27 ` [PATCH v2 6/6] PM / devfreq: Add a driver for the sun8i/sun50i MBUS Samuel Holland
2021-10-15 8:28 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435d622b-4ad9-d9d5-3c9b-7b66304e42e4@samsung.com \
--to=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).