[PATCH 1/2] arm64: tegra: fix p3767 card detect polarity

[PATCH 1/2] arm64: tegra: fix p3767 card detect polarity

[Brad Griffis]

The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low.

Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
index bd60478fa75e..831a553ec387 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
@@ -42,7 +42,7 @@ flash@0 {
 		mmc@3400000 {
 			status = "okay";
 			bus-width = <4>;
-			cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_HIGH>;
+			cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_LOW>;
 			disable-wp;
 		};
 
-- 
2.25.1

[PATCH 2/2] arm64: tegra: fix p3767 QSPI speed

[Brad Griffis]

The QSPI device used in Jetson Orin NX and Nano modules (p3767) is
the same as Jetson AGX Orin (p3701) and should have a max speed of
102 MHz.

Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
index 831a553ec387..980f15ac674d 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
@@ -28,7 +28,7 @@ spi@3270000 {
 			flash@0 {
 				compatible = "jedec,spi-nor";
 				reg = <0>;
-				spi-max-frequency = <136000000>;
+				spi-max-frequency = <102000000>;
 				spi-tx-bus-width = <4>;
 				spi-rx-bus-width = <4>;
 			};
-- 
2.25.1

Re: [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]

On Mon, Jun 26, 2023 at 06:09:19PM +0000, Brad Griffis wrote:
> The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low.
> 
> Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
> Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This DTS include is also used by Jetson Orin NX, but I assume that the
same polarity applies to that as well?

Actually, looking at the Orin NX, I don't see an SD card slot and
judging by the documentation that I was able to find it's not documented
for Orin Nano either. Or is it only certain variants that were equipped
with the SD slot?

Thierry

> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> index bd60478fa75e..831a553ec387 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> @@ -42,7 +42,7 @@ flash@0 {
>  		mmc@3400000 {
>  			status = "okay";
>  			bus-width = <4>;
> -			cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_HIGH>;
> +			cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_LOW>;
>  			disable-wp;
>  		};
>  
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/2] arm64: tegra: fix p3767 QSPI speed

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

On Mon, Jun 26, 2023 at 06:09:20PM +0000, Brad Griffis wrote:
> The QSPI device used in Jetson Orin NX and Nano modules (p3767) is
> the same as Jetson AGX Orin (p3701) and should have a max speed of
> 102 MHz.
> 
> Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
> Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This was originally copied from the downstream DTB and I see 136 MHz for
both P3701 and P3767 there. So now I wonder which one is correct. Should
perhaps the P3701 be updated to 136 MHz instead if that's what is being
used downstream?

Thierry

> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> index 831a553ec387..980f15ac674d 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> @@ -28,7 +28,7 @@ spi@3270000 {
>  			flash@0 {
>  				compatible = "jedec,spi-nor";
>  				reg = <0>;
> -				spi-max-frequency = <136000000>;
> +				spi-max-frequency = <102000000>;
>  				spi-tx-bus-width = <4>;
>  				spi-rx-bus-width = <4>;
>  			};
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity

[Brad Griffis]

On Fri, Jul 21, 2023 at 6:22 AM +0000, Thierry Reding wrote:
> On Mon, Jun 26, 2023 at 06:09:19PM +0000, Brad Griffis wrote:
> > The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low.
> >
> > Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
> > Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
> > ---
> >  arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This DTS include is also used by Jetson Orin NX, but I assume that the same
> polarity applies to that as well?

The polarity is the same for all Orin NX/Nano modules that have SD card.

> Actually, looking at the Orin NX, I don't see an SD card slot and judging by the
> documentation that I was able to find it's not documented for Orin Nano
> either. Or is it only certain variants that were equipped with the SD slot?

UEFI dynamically disables this mmc instance on SKUs that do not support it.

RE: [PATCH 2/2] arm64: tegra: fix p3767 QSPI speed

[Brad Griffis]

On Fri, Jul 21, 2023 at 6:26 AM +0000, Thierry Reding wrote:
> On Mon, Jun 26, 2023 at 06:09:20PM +0000, Brad Griffis wrote:
> > The QSPI device used in Jetson Orin NX and Nano modules (p3767) is the
> > same as Jetson AGX Orin (p3701) and should have a max speed of
> > 102 MHz.
> >
> > Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
> > Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
> > ---
> >  arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This was originally copied from the downstream DTB and I see 136 MHz for
> both P3701 and P3767 there. So now I wonder which one is correct. Should
> perhaps the P3701 be updated to 136 MHz instead if that's what is being used
> downstream?

Downstream we have changed both p3701 and p3767 to use 102 MHz.  That is
the max speed for Quad I/O DTR reads. 

Re: [PATCH 2/2] arm64: tegra: fix p3767 QSPI speed

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On Tue, Aug 15, 2023 at 01:38:35PM +0000, Brad Griffis wrote:
> On Fri, Jul 21, 2023 at 6:26 AM +0000, Thierry Reding wrote:
> > On Mon, Jun 26, 2023 at 06:09:20PM +0000, Brad Griffis wrote:
> > > The QSPI device used in Jetson Orin NX and Nano modules (p3767) is the
> > > same as Jetson AGX Orin (p3701) and should have a max speed of
> > > 102 MHz.
> > >
> > > Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
> > > Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
> > > ---
> > >  arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > This was originally copied from the downstream DTB and I see 136 MHz for
> > both P3701 and P3767 there. So now I wonder which one is correct. Should
> > perhaps the P3701 be updated to 136 MHz instead if that's what is being used
> > downstream?
> 
> Downstream we have changed both p3701 and p3767 to use 102 MHz.  That is
> the max speed for Quad I/O DTR reads. 

Alright, I must've looked at an older version of the downstream DTB.

Applied, thanks.
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On Tue, Aug 15, 2023 at 01:37:40PM +0000, Brad Griffis wrote:
> On Fri, Jul 21, 2023 at 6:22 AM +0000, Thierry Reding wrote:
> > On Mon, Jun 26, 2023 at 06:09:19PM +0000, Brad Griffis wrote:
> > > The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low.
> > >
> > > Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
> > > Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
> > > ---
> > >  arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > This DTS include is also used by Jetson Orin NX, but I assume that the same
> > polarity applies to that as well?
> 
> The polarity is the same for all Orin NX/Nano modules that have SD card.
> 
> > Actually, looking at the Orin NX, I don't see an SD card slot and judging by the
> > documentation that I was able to find it's not documented for Orin Nano
> > either. Or is it only certain variants that were equipped with the SD slot?
> 
> UEFI dynamically disables this mmc instance on SKUs that do not support it.

Okay, good. I've adjusted the commit message a tiny little bit to
clarify that this applies to all NX/Nano SKUs that have an SD card slot
equipped.

Applied, thanks.
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]