From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] kernel-shark-qt: Cosmetic modifications in KsQuickContextMenu
Date: Wed, 9 Jan 2019 11:33:17 -0500 [thread overview]
Message-ID: <20190109113317.751b3561@gandalf.local.home> (raw)
In-Reply-To: <20190109130945.28519-3-ykaradzhov@vmware.com>
On Wed, 9 Jan 2019 15:09:41 +0200
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> The following minor modifications in KsQuickContextMenu are introduced:
>
> 1. Removes the "Apply to list/graph" check-boxes.
> 2. Swaps the position of the Show / Hide actions
> 3. Adds "clear all filters" action.
>
This should actually be three separate patches. Even if they are minor,
each patch should only do one thing, with the exception of formatting
clean ups. Formatting clean ups can be done when the code that's being
cleaned up is being changed.
But the above are three distinct changes, and should be three distinct
patches. I know it's a little tedious to do it this way, but it's the
cleaner approach.
Can you resend with them separate?
-- Steve
> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
> ---
> kernel-shark-qt/src/KsQuickContextMenu.cpp | 63 +++++++---------------
> kernel-shark-qt/src/KsQuickContextMenu.hpp | 4 +-
> 2 files changed, 23 insertions(+), 44 deletions(-)
>
>
next prev parent reply other threads:[~2019-01-09 16:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 13:09 [PATCH v2 0/6] Modifications toward KS 1.0 Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 1/6] kernel-shark-qt: Rearrange the "Filter" top menu Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 2/6] kernel-shark-qt: Cosmetic modifications in KsQuickContextMenu Yordan Karadzhov
2019-01-09 16:33 ` Steven Rostedt [this message]
2019-01-09 16:38 ` Yordan Karadzhov
2019-01-09 16:47 ` Steven Rostedt
2019-01-09 13:09 ` [PATCH v2 3/6] kernel-shark-qt: Make the selection in the Table less touchy Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 4/6] kernel-shark-qt: Do not auto-scrolling when the marker switches Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 5/6] kernel-shark-qt: Add the CPU filters to the filter clearing method Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 6/6] kernel-shark-qt: Fix bug in plugin actions execution Yordan Karadzhov
2019-01-09 16:52 ` Steven Rostedt
2019-03-15 0:01 ` Steven Rostedt
2019-03-15 0:05 ` Steven Rostedt
2019-03-15 6:20 ` Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109113317.751b3561@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).