* Re: [PATCH v2] plugin python: Adjust the handling after PyRun_String() failed
[not found] <1493261758-32597-1-git-send-email-treeze.taeung@gmail.com>
@ 2019-01-16 3:39 ` Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2019-01-16 3:39 UTC (permalink / raw)
To: Taeung Song; +Cc: linux-kernel, linux-trace-devel
On Thu, 27 Apr 2017 11:55:58 +0900
Taeung Song <treeze.taeung@gmail.com> wrote:
> Even though PyRun_String() failed,
> just 0 will be returned but we need to return -1
> that means error status, so fix it.
Ug, I just noticed this patch floating in the flood of my INBOX.
I just applied it, and will be pushing it out soon.
Thanks, and I'm really sorry for not seeing it.
-- Steve
>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
> plugin_python.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugin_python.c b/plugin_python.c
> index 2997679..c283ed7 100644
> --- a/plugin_python.c
> +++ b/plugin_python.c
> @@ -55,7 +55,7 @@ static int load_plugin(struct pevent *pevent, const char *path,
>
> free(load);
>
> - return 0;
> + return res ? 0 : -1;
> }
>
> int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
^ permalink raw reply [flat|nested] only message in thread