From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH v3 1/5] kernel-shark: Show warning message when running as Root
Date: Fri, 20 Sep 2019 13:28:48 +0300 [thread overview]
Message-ID: <20190920102852.22769-2-y.karadz@gmail.com> (raw)
In-Reply-To: <20190920102852.22769-1-y.karadz@gmail.com>
Running the KernelShark GUI with Root privileges is not recommended due
to security reasons. The user will be allowed to continue on its own risk.
Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204475
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
kernel-shark/src/KsMainWindow.cpp | 28 ++++++++++++++++++++++++++++
kernel-shark/src/KsMainWindow.hpp | 2 ++
2 files changed, 30 insertions(+)
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index 6439265..904d682 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -76,6 +76,9 @@ KsMainWindow::KsMainWindow(QWidget *parent)
_createMenus();
_initCapture();
+ if (geteuid() == 0)
+ _rootWarning();
+
_splitter.addWidget(&_graph);
_splitter.addWidget(&_view);
setCentralWidget(&_splitter);
@@ -1271,3 +1274,28 @@ void KsMainWindow::_deselectB()
_mState.updateLabels();
_graph.glPtr()->model()->update();
}
+
+void KsMainWindow::_rootWarning()
+{
+ QString cbFlag("noRootWarn");
+
+ if (_settings.value(cbFlag).toBool())
+ return;
+
+ QMessageBox warn;
+ warn.setText("KernelShark is running with Root privileges.");
+ warn.setInformativeText("Continue at your own risk.");
+ warn.setIcon(QMessageBox::Warning);
+ warn.setStandardButtons(QMessageBox::Close);
+
+ QCheckBox cb("Don't show this message again.");
+
+ auto lamCbChec = [&] (int state) {
+ if (state)
+ _settings.setValue(cbFlag, true);
+ };
+
+ connect(&cb, &QCheckBox::stateChanged, lamCbChec);
+ warn.setCheckBox(&cb);
+ warn.exec();
+}
diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp
index 62e66a0..4a7b8ab 100644
--- a/kernel-shark/src/KsMainWindow.hpp
+++ b/kernel-shark/src/KsMainWindow.hpp
@@ -238,6 +238,8 @@ private:
void _deselectB();
+ void _rootWarning();
+
void _updateFilterMenu();
void _filterSyncCBoxUpdate(kshark_context *kshark_ctx);
--
2.20.1
next prev parent reply other threads:[~2019-09-20 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 10:28 [PATCH v3 0/5] Handle the case when KernelShark is started as Root Yordan Karadzhov (VMware)
2019-09-20 10:28 ` Yordan Karadzhov (VMware) [this message]
2019-09-20 10:28 ` [PATCH v3 2/5] kernel-shark: Don't use pkexec when running " Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 3/5] kernel-shark: Use standart error message in KsMainWindow::_record() Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 4/5] kernel-shark: Optimize the error messages when "Record" fails to start Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 5/5] kernel-shark: Better formatting of the error messages from "Record" Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920102852.22769-2-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).