Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type
@ 2021-02-05 11:12 Tzvetomir Stoyanov (VMware)
  2021-02-08 10:34 ` Yordan Karadzhov (VMware)
  0 siblings, 1 reply; 2+ messages in thread
From: Tzvetomir Stoyanov (VMware) @ 2021-02-05 11:12 UTC (permalink / raw)
  To: rostedt, y.karadz; +Cc: linux-trace-devel

From: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>

There is a compilation error when compiling KernelShark on Fedora 33
with c++ (GCC) 10.2.1:

  src/KsPlotTools.hpp:349:37: error: ‘string’ in namespace ‘std’ does not name a type

"string" should be included in that header file, as it is a direct
dependency.

Signed-off-by: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
---
 src/KsPlotTools.hpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/KsPlotTools.hpp b/src/KsPlotTools.hpp
index 1725926..68bd6f7 100644
--- a/src/KsPlotTools.hpp
+++ b/src/KsPlotTools.hpp
@@ -15,6 +15,7 @@
 // C++
 #include <forward_list>
 #include <unordered_map>
+#include <string>
 
 // KernelShark
 #include "libkshark.h"
-- 
2.29.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type
  2021-02-05 11:12 [PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type Tzvetomir Stoyanov (VMware)
@ 2021-02-08 10:34 ` Yordan Karadzhov (VMware)
  0 siblings, 0 replies; 2+ messages in thread
From: Yordan Karadzhov (VMware) @ 2021-02-08 10:34 UTC (permalink / raw)
  To: Tzvetomir Stoyanov (VMware), rostedt; +Cc: linux-trace-devel



On 5.02.21 г. 13:12 ч., Tzvetomir Stoyanov (VMware) wrote:
> From: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> 
> There is a compilation error when compiling KernelShark on Fedora 33
> with c++ (GCC) 10.2.1:
> 
>    src/KsPlotTools.hpp:349:37: error: ‘string’ in namespace ‘std’ does not name a type
> 
> "string" should be included in that header file, as it is a direct
> dependency.
> 
> Signed-off-by: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> ---
>   src/KsPlotTools.hpp | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/KsPlotTools.hpp b/src/KsPlotTools.hpp
> index 1725926..68bd6f7 100644
> --- a/src/KsPlotTools.hpp
> +++ b/src/KsPlotTools.hpp
> @@ -15,6 +15,7 @@
>   // C++
>   #include <forward_list>
>   #include <unordered_map>
> +#include <string>
>   
>   // KernelShark
>   #include "libkshark.h"
> 

Thanks Ceco!

Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 11:12 [PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type Tzvetomir Stoyanov (VMware)
2021-02-08 10:34 ` Yordan Karadzhov (VMware)

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git