linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: sameeruddin shaik <sameeruddin.shaik8@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Fix lib audit warning message
Date: Wed, 13 Jan 2021 21:40:45 +0530	[thread overview]
Message-ID: <c7d7a2f9-78cf-366f-44ec-e1695c019443@gmail.com> (raw)
In-Reply-To: <20210112122906.33c959f2@gandalf.local.home>

hi steve,

please check now.

statically updated the warning message which we will get, when
compiling trace-cmd without the libaudit library.

Following are the the messages which will pop out when compiling

Before:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw 
syscalls " "(install libaudit-devel and try again)"

After:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw 
syscalls " "(install libaudit-devel(for fedora) or libaudit-dev(for 
debian/ubuntu) and try again)"

Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
---
  tracecmd/trace-profile.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
index cfae2a2..9b5c385 100644
--- a/tracecmd/trace-profile.c
+++ b/tracecmd/trace-profile.c
@@ -21,7 +21,7 @@

  #ifdef WARN_NO_AUDIT
  # warning "lib audit not found, using raw syscalls "    \
-    "(install libaudit-devel and try again)"
+    "(install libaudit-devel(for fedora) or libaudit-dev(for 
debian/ubuntu) and try again)"
  #endif

  #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"
-- 

Thanks,

sameer.

On 12/01/21 10:59 pm, Steven Rostedt wrote:
> On Tue, 12 Jan 2021 13:01:20 +0530
> Sameeruddin Shaik <sameeruddin.shaik8@gmail.com> wrote:
>
> Hi Sameer,
>
>> statically updated the warning message which we will get, when
>> compiling trace-cmd without the libaudit library.
>>
>> Following are the the messages which will pop out when compiling
>>
>> Before:
>> -------
>> trace-profile.c:23:3: warning: #warning "lib audit not found, using
>> raw syscalls " "(install libaudit-devel and try again)"
>>
>> After:
>> -------
>> trace-profile.c:23:3: warning: #warning "lib audit not found, using
>> raw syscalls " "(install libaudit-devel(for fedora) or
>> libaudit-dev(for debian/ubuntu) and try again)"
>>
>> Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
>> ---
>>   tracecmd/trace-profile.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
>> index cfae2a2..4e5d68d 100644
>> --- a/tracecmd/trace-profile.c
>> +++ b/tracecmd/trace-profile.c
>> @@ -21,7 +21,8 @@
>>
>>   #ifdef WARN_NO_AUDIT
>>   # warning "lib audit not found, using raw syscalls "    \
> Your mail client turned tabs into spaces and this doesn't apply properly.
> Are you able to fix that?
>
>> -    "(install libaudit-devel and try again)"
>> +    "(install libaudit-devel(for fedora) or libaudit-dev(for \
>> +debian/ubuntu) and try again)"
> Also, the above can stay on one line. Yes, it breaks the 80 char limit, but
> that's more of a guideline and not a requirement ;-)
>
>
> Care to send a v2?
>
> Thanks!
>
> -- Steve
>
>>   #endif
>>
>>   #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"

  reply	other threads:[~2021-01-13 10:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  7:31 [PATCH] trace-cmd: Fix lib audit warning message Sameeruddin Shaik
2021-01-12 17:29 ` Steven Rostedt
2021-01-13 16:10   ` sameeruddin shaik [this message]
2021-01-13 14:38     ` Steven Rostedt
2021-01-14  6:44 Sameeruddin shaik
2021-01-14  2:04 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7d7a2f9-78cf-366f-44ec-e1695c019443@gmail.com \
    --to=sameeruddin.shaik8@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).