* [PATCH] ata: pata_cs5536: don't build on UML
@ 2023-03-12 5:26 Randy Dunlap
2023-03-12 11:38 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-03-12 5:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Damien Le Moal, linux-ide, linux-um
Similar to 22eebaa631c4 ("ata: pata_cs5535: Don't build on UML"),
prevent pata_cs5536 from building on UML since it references
symbols that are not present when building X86_32/i386 allmodconfig.
ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined!
ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined!
ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined!
ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined!
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-ide@vger.kernel.org
Cc: linux-um@lists.infradead.org
---
drivers/ata/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/ata/Kconfig b/drivers/ata/Kconfig
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -650,6 +650,7 @@ config PATA_CS5535
config PATA_CS5536
tristate "CS5536 PATA support"
depends on PCI && (X86_32 || MIPS || COMPILE_TEST)
+ depends on !UML
help
This option enables support for the AMD CS5536
companion chip used with the Geode LX processor family.
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: pata_cs5536: don't build on UML
2023-03-12 5:26 [PATCH] ata: pata_cs5536: don't build on UML Randy Dunlap
@ 2023-03-12 11:38 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2023-03-12 11:38 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Damien Le Moal, linux-ide, linux-um
Hi Randy,
On Sun, Mar 12, 2023 at 6:26 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Similar to 22eebaa631c4 ("ata: pata_cs5535: Don't build on UML"),
> prevent pata_cs5536 from building on UML since it references
> symbols that are not present when building X86_32/i386 allmodconfig.
>
> ERROR: modpost: "__tracepoint_write_msr" [drivers/ata/pata_cs5536.ko] undefined!
> ERROR: modpost: "do_trace_write_msr" [drivers/ata/pata_cs5536.ko] undefined!
> ERROR: modpost: "__tracepoint_read_msr" [drivers/ata/pata_cs5536.ko] undefined!
> ERROR: modpost: "do_trace_read_msr" [drivers/ata/pata_cs5536.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks for your patch!
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -650,6 +650,7 @@ config PATA_CS5535
> config PATA_CS5536
> tristate "CS5536 PATA support"
> depends on PCI && (X86_32 || MIPS || COMPILE_TEST)
How does this work on MIPS?
Oh, the MSR functionality inside the driver depends on CONFIG_X86_32.
Perhaps this can be fixed better for all users inside
arch/x86/include/asm/msr.h?
> + depends on !UML
> help
> This option enables support for the AMD CS5536
> companion chip used with the Geode LX processor family.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-12 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-12 5:26 [PATCH] ata: pata_cs5536: don't build on UML Randy Dunlap
2023-03-12 11:38 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).