From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc: linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chengguang Xu <cgxu519@mykernel.net>
Subject: [RFC PATCH v5 04/10] ovl: mark overlayfs' inode dirty on modification
Date: Thu, 23 Sep 2021 21:08:08 +0800 [thread overview]
Message-ID: <20210923130814.140814-5-cgxu519@mykernel.net> (raw)
In-Reply-To: <20210923130814.140814-1-cgxu519@mykernel.net>
Mark overlayfs' inode dirty on modification so that
we can recognize and collect target inodes for syncfs.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/overlayfs/inode.c | 1 +
fs/overlayfs/overlayfs.h | 4 ++++
fs/overlayfs/util.c | 21 +++++++++++++++++++++
3 files changed, 26 insertions(+)
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index d854e59a3710..4a03aceaeedc 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -478,6 +478,7 @@ int ovl_update_time(struct inode *inode, struct timespec64 *ts, int flags)
if (upperpath.dentry) {
touch_atime(&upperpath);
inode->i_atime = d_inode(upperpath.dentry)->i_atime;
+ ovl_mark_inode_dirty(inode);
}
}
return 0;
diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h
index 3894f3347955..5a016baa06dd 100644
--- a/fs/overlayfs/overlayfs.h
+++ b/fs/overlayfs/overlayfs.h
@@ -276,6 +276,7 @@ static inline bool ovl_allow_offline_changes(struct ovl_fs *ofs)
/* util.c */
+void ovl_mark_inode_dirty(struct inode *inode);
int ovl_want_write(struct dentry *dentry);
void ovl_drop_write(struct dentry *dentry);
struct dentry *ovl_workdir(struct dentry *dentry);
@@ -529,6 +530,9 @@ static inline void ovl_copyattr(struct inode *from, struct inode *to)
to->i_mtime = from->i_mtime;
to->i_ctime = from->i_ctime;
i_size_write(to, i_size_read(from));
+
+ if (ovl_inode_upper(to) && from->i_state & I_DIRTY_ALL)
+ ovl_mark_inode_dirty(to);
}
/* vfs inode flags copied from real to ovl inode */
diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c
index f48284a2a896..5441eae2e345 100644
--- a/fs/overlayfs/util.c
+++ b/fs/overlayfs/util.c
@@ -25,7 +25,14 @@ int ovl_want_write(struct dentry *dentry)
void ovl_drop_write(struct dentry *dentry)
{
struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
+ struct dentry *upper;
+
mnt_drop_write(ovl_upper_mnt(ofs));
+ if (d_inode(dentry)) {
+ upper = ovl_dentry_upper(dentry);
+ if (upper && d_inode(upper) && d_inode(upper)->i_state & I_DIRTY_ALL)
+ ovl_mark_inode_dirty(d_inode(dentry));
+ }
}
struct dentry *ovl_workdir(struct dentry *dentry)
@@ -1060,3 +1067,17 @@ int ovl_sync_status(struct ovl_fs *ofs)
return errseq_check(&mnt->mnt_sb->s_wb_err, ofs->errseq);
}
+
+/*
+ * We intentionally add I_DIRTY_SYNC flag regardless dirty flag
+ * of upper inode so that we have chance to invoke ->write_inode
+ * to re-dirty overlayfs' inode during writeback process.
+ */
+void ovl_mark_inode_dirty(struct inode *inode)
+{
+ struct inode *upper = ovl_inode_upper(inode);
+ unsigned long iflag = I_DIRTY_SYNC;
+
+ iflag |= upper->i_state & I_DIRTY_ALL;
+ __mark_inode_dirty(inode, iflag);
+}
--
2.27.0
next prev parent reply other threads:[~2021-09-23 13:24 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 13:08 [RFC PATCH v5 00/10] implement containerized syncfs for overlayfs Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 01/10] ovl: setup overlayfs' private bdi Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 02/10] ovl: implement ->writepages operation Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 03/10] ovl: implement overlayfs' ->evict_inode operation Chengguang Xu
2021-10-06 15:33 ` Miklos Szeredi
2021-10-07 6:08 ` Chengguang Xu
2021-10-07 7:43 ` Miklos Szeredi
2021-09-23 13:08 ` Chengguang Xu [this message]
2021-10-07 18:43 ` [RFC PATCH v5 04/10] ovl: mark overlayfs' inode dirty on modification Miklos Szeredi
2021-09-23 13:08 ` [RFC PATCH v5 05/10] ovl: mark overlayfs' inode dirty on shared mmap Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 06/10] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2021-10-07 9:01 ` Jan Kara
2021-10-07 12:26 ` Chengguang Xu
2021-10-07 14:41 ` Jan Kara
2021-10-07 14:54 ` Chengguang Xu
2021-10-07 9:23 ` Miklos Szeredi
2021-10-07 12:28 ` Chengguang Xu
2021-10-07 12:45 ` Miklos Szeredi
2021-10-07 13:09 ` Chengguang Xu
2021-10-07 13:34 ` Miklos Szeredi
2021-10-07 14:46 ` Jan Kara
2021-10-07 14:53 ` Chengguang Xu
2021-10-07 18:51 ` Miklos Szeredi
2021-10-08 13:13 ` Jan Kara
2021-11-16 2:20 ` Chengguang Xu
2021-11-16 12:35 ` Miklos Szeredi
2021-11-17 6:11 ` Chengguang Xu
2021-11-18 6:32 ` Chengguang Xu
2021-11-18 11:23 ` Jan Kara
2021-11-18 12:02 ` Chengguang Xu
2021-11-18 16:43 ` Jan Kara
2021-11-19 6:12 ` Chengguang Xu
2021-11-30 11:22 ` Jan Kara
2021-11-30 16:09 ` Chengguang Xu
2021-11-30 19:04 ` Amir Goldstein
2021-12-01 2:37 ` Chengguang Xu
2021-12-01 6:31 ` Chengguang Xu
2021-12-01 7:19 ` Amir Goldstein
2021-12-01 13:46 ` Jan Kara
2021-12-01 14:59 ` Chengguang Xu
2021-12-01 16:24 ` Chengguang Xu
2021-12-01 22:47 ` Amir Goldstein
2021-12-01 23:23 ` ovl_flush() behavior Amir Goldstein
2021-12-02 2:11 ` Chengguang Xu
2021-12-02 15:20 ` Vivek Goyal
2021-12-02 15:59 ` Amir Goldstein
2021-12-02 22:00 ` Vivek Goyal
2021-12-02 15:14 ` Vivek Goyal
2021-12-05 14:06 ` [RFC PATCH v5 06/10] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2021-12-07 5:33 ` Amir Goldstein
2022-02-05 16:09 ` Chengguang Xu
2022-02-05 16:23 ` Amir Goldstein
2021-09-23 13:08 ` [RFC PATCH v5 07/10] ovl: cache dirty overlayfs' inode Chengguang Xu
2021-10-07 11:09 ` Miklos Szeredi
2021-10-07 12:04 ` Chengguang Xu
2021-10-07 12:27 ` Miklos Szeredi
2021-09-23 13:08 ` [RFC PATCH v5 08/10] fs: export wait_sb_inodes() Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 09/10] fs: introduce new helper sync_fs_and_blockdev() Chengguang Xu
2021-10-19 7:15 ` Amir Goldstein
2021-11-15 11:39 ` Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 10/10] ovl: implement containerized syncfs for overlayfs Chengguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923130814.140814-5-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).