From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH 3/3] ovl: do not follow non-dir origin with redirect_dir=nofollow
Date: Fri, 30 Oct 2020 13:05:36 +0100 [thread overview]
Message-ID: <CAJfpegvhH+SUn-QModbU23sk3=NGYgxKSekh5B70JfK_=HbHfw@mail.gmail.com> (raw)
In-Reply-To: <20200713141945.11719-4-amir73il@gmail.com>
On Mon, Jul 13, 2020 at 4:20 PM Amir Goldstein <amir73il@gmail.com> wrote:
>
> Following non-dir origin can result in some bugs when underlying layers
> are edited offline.
Sorry, lost track. What bugs this results in?
Thanks,
Miklos
To be on the safe side, do not follow non-dir
> origin when not following redirects. This will make overlay lookup
> with "redirect_dir=nofollow" behave as pre kernel v4.12 lookup, before
> the introduction of the origin xattr.
>
> Link: https://lore.kernel.org/linux-unionfs/CAJfpegv9h7ubuGy_6K4OCdZd3R7Z4HGmCDB2L7mO5bVoGd6MSA@mail.gmail.com/
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
> fs/overlayfs/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
> index ae1c1216a038..31ee5a519736 100644
> --- a/fs/overlayfs/namei.c
> +++ b/fs/overlayfs/namei.c
> @@ -861,7 +861,7 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
> err = -EREMOTE;
> goto out;
> }
> - if (upperdentry && !d.is_dir) {
> + if (upperdentry && !d.is_dir && ofs->config.redirect_follow) {
> unsigned int origin_ctr = 0;
>
> /*
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-10-30 12:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 14:19 [PATCH 0/3] Misc. redirect_dir=nofollow fixes Amir Goldstein
2020-07-13 14:19 ` [PATCH 1/3] ovl: force read-only sb on failure to create index dir Amir Goldstein
2020-07-14 18:18 ` Vivek Goyal
2020-07-14 18:32 ` Amir Goldstein
2020-07-14 18:38 ` Vivek Goyal
2020-07-14 18:45 ` Amir Goldstein
2020-07-15 20:04 ` Miklos Szeredi
2020-07-16 5:00 ` Amir Goldstein
2020-07-15 20:03 ` Miklos Szeredi
2020-07-13 14:19 ` [PATCH 2/3] ovl: fix mount option checks for nfs_export with no upperdir Amir Goldstein
2020-07-14 14:52 ` Miklos Szeredi
2020-07-14 14:58 ` Amir Goldstein
2020-07-14 15:08 ` Miklos Szeredi
2020-07-14 15:20 ` Amir Goldstein
2020-07-15 20:05 ` Miklos Szeredi
2020-07-13 14:19 ` [PATCH 3/3] ovl: do not follow non-dir origin with redirect_dir=nofollow Amir Goldstein
2020-10-30 12:05 ` Miklos Szeredi [this message]
2020-10-30 13:20 ` Amir Goldstein
2020-10-30 13:51 ` Miklos Szeredi
2020-07-14 18:07 ` [PATCH 0/3] Misc. redirect_dir=nofollow fixes Vivek Goyal
2020-07-14 18:42 ` Amir Goldstein
2020-07-15 13:06 ` Vivek Goyal
2020-07-15 13:56 ` Amir Goldstein
2020-07-16 13:27 ` Vivek Goyal
2020-07-16 13:43 ` Amir Goldstein
2020-07-16 15:26 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegvhH+SUn-QModbU23sk3=NGYgxKSekh5B70JfK_=HbHfw@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).