* [PATCH 00/16] constify copied structure
@ 2020-01-01 7:43 Julia Lawall
2020-01-01 7:43 ` [PATCH 04/16] usb: gadget: udc: atmel: " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-01-01 7:43 UTC (permalink / raw)
To: Jernej Skrabec
Cc: kernel-janitors, Jonas Karlman, Laurent Pinchart, linuxppc-dev,
linux-fbdev, dri-devel, linux-media, linux-kernel, alsa-devel,
linux-arm-kernel, linux-usb, linux-arm-msm, linux-gpio,
linux-nfs, netdev
Make const static structures that are just copied into other structures.
The semantic patch that detects the opportunity for this change is as
follows: (http://coccinelle.lip6.fr/)
<smpl>
@r disable optional_qualifier@
identifier i,j;
position p;
@@
static struct i j@p = { ... };
@upd@
position p1;
identifier r.j;
expression e;
@@
e = j@p1
@ref@
position p2 != {r.p,upd.p1};
identifier r.j;
@@
j@p2
@script:ocaml depends on upd && !ref@
i << r.i;
j << r.j;
p << r.p;
@@
if j = (List.hd p).current_element
then Coccilib.print_main i p
</smpl>
---
arch/powerpc/sysdev/mpic.c | 4 ++--
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
drivers/media/i2c/mt9v111.c | 2 +-
drivers/media/platform/davinci/isif.c | 2 +-
drivers/media/usb/cx231xx/cx231xx-dvb.c | 2 +-
drivers/media/usb/dvb-usb-v2/anysee.c | 4 ++--
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 +-
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 2 +-
drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 2 +-
drivers/ptp/ptp_clockmatrix.c | 2 +-
drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
drivers/video/fbdev/sa1100fb.c | 2 +-
net/sunrpc/xdr.c | 2 +-
sound/isa/ad1816a/ad1816a_lib.c | 2 +-
sound/pci/hda/hda_controller.c | 2 +-
sound/soc/qcom/qdsp6/q6asm-dai.c | 2 +-
16 files changed, 18 insertions(+), 18 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 04/16] usb: gadget: udc: atmel: constify copied structure
2020-01-01 7:43 [PATCH 00/16] constify copied structure Julia Lawall
@ 2020-01-01 7:43 ` Julia Lawall
2020-01-06 11:16 ` Cristian.Birsan
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-01-01 7:43 UTC (permalink / raw)
To: Cristian Birsan
Cc: kernel-janitors, Felipe Balbi, Greg Kroah-Hartman, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, linux-arm-kernel,
linux-usb, linux-kernel
The usba_gadget_template structure is only copied into another
structure, so make it const.
The opportunity for this change was found using Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 8a42768e3213..6e0432141c40 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -1122,7 +1122,7 @@ static struct usb_endpoint_descriptor usba_ep0_desc = {
.bInterval = 1,
};
-static struct usb_gadget usba_gadget_template = {
+static const struct usb_gadget usba_gadget_template = {
.ops = &usba_udc_ops,
.max_speed = USB_SPEED_HIGH,
.name = "atmel_usba_udc",
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 04/16] usb: gadget: udc: atmel: constify copied structure
2020-01-01 7:43 ` [PATCH 04/16] usb: gadget: udc: atmel: " Julia Lawall
@ 2020-01-06 11:16 ` Cristian.Birsan
0 siblings, 0 replies; 3+ messages in thread
From: Cristian.Birsan @ 2020-01-06 11:16 UTC (permalink / raw)
To: Julia.Lawall
Cc: kernel-janitors, balbi, gregkh, Nicolas.Ferre, alexandre.belloni,
Ludovic.Desroches, linux-arm-kernel, linux-usb, linux-kernel
On 1/1/20 9:43 AM, Julia Lawall wrote:
> The usba_gadget_template structure is only copied into another
> structure, so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Acked-by: Cristian Birsan <cristian.birsan@microchip.com>
>
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 8a42768e3213..6e0432141c40 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1122,7 +1122,7 @@ static struct usb_endpoint_descriptor usba_ep0_desc = {
> .bInterval = 1,
> };
>
> -static struct usb_gadget usba_gadget_template = {
> +static const struct usb_gadget usba_gadget_template = {
> .ops = &usba_udc_ops,
> .max_speed = USB_SPEED_HIGH,
> .name = "atmel_usba_udc",
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-06 11:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-01 7:43 [PATCH 00/16] constify copied structure Julia Lawall
2020-01-01 7:43 ` [PATCH 04/16] usb: gadget: udc: atmel: " Julia Lawall
2020-01-06 11:16 ` Cristian.Birsan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).