* [PATCH] xhci: Fix log mistake of xhci_start
@ 2020-05-15 5:45 jiahao
2020-05-15 6:53 ` Mathias Nyman
2020-05-15 9:21 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: jiahao @ 2020-05-15 5:45 UTC (permalink / raw)
To: mathias.nyman, gregkh, jiahao; +Cc: linux-usb, linux-kernel
It is obvious that XCHI_MAX_HALT_USEC is usec,
not milliseconds; Replace 'milliseconds' with
'usec' of the debug message.
Signed-off-by: jiahao <jiahao@xiaomi.com>
---
drivers/usb/host/xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index bee5dec..d011472 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -147,7 +147,7 @@ int xhci_start(struct xhci_hcd *xhci)
STS_HALT, 0, XHCI_MAX_HALT_USEC);
if (ret == -ETIMEDOUT)
xhci_err(xhci, "Host took too long to start, "
- "waited %u microseconds.\n",
+ "waited %u usec.\n",
XHCI_MAX_HALT_USEC);
if (!ret)
/* clear state flags. Including dying, halted or removing */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xhci: Fix log mistake of xhci_start
2020-05-15 5:45 [PATCH] xhci: Fix log mistake of xhci_start jiahao
@ 2020-05-15 6:53 ` Mathias Nyman
2020-05-15 9:21 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Mathias Nyman @ 2020-05-15 6:53 UTC (permalink / raw)
To: jiahao, mathias.nyman, gregkh, jiahao; +Cc: linux-usb, linux-kernel
On 15.5.2020 8.45, jiahao wrote:
> It is obvious that XCHI_MAX_HALT_USEC is usec,
> not milliseconds; Replace 'milliseconds' with
> 'usec' of the debug message.
>
> Signed-off-by: jiahao <jiahao@xiaomi.com>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index bee5dec..d011472 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -147,7 +147,7 @@ int xhci_start(struct xhci_hcd *xhci)
> STS_HALT, 0, XHCI_MAX_HALT_USEC);
> if (ret == -ETIMEDOUT)
> xhci_err(xhci, "Host took too long to start, "
> - "waited %u microseconds.\n",
> + "waited %u usec.\n",
It already says "microseconds", no need to change it
-Mathias
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xhci: Fix log mistake of xhci_start
2020-05-15 5:45 [PATCH] xhci: Fix log mistake of xhci_start jiahao
2020-05-15 6:53 ` Mathias Nyman
@ 2020-05-15 9:21 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2020-05-15 9:21 UTC (permalink / raw)
To: jiahao, mathias.nyman, gregkh, jiahao; +Cc: linux-usb, linux-kernel
On 15.05.2020 8:45, jiahao wrote:
> It is obvious that XCHI_MAX_HALT_USEC is usec,
> not milliseconds; Replace 'milliseconds' with
I don't see 'milliseconds', only 'microseconds'...
> 'usec' of the debug message.
>
> Signed-off-by: jiahao <jiahao@xiaomi.com>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index bee5dec..d011472 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -147,7 +147,7 @@ int xhci_start(struct xhci_hcd *xhci)
> STS_HALT, 0, XHCI_MAX_HALT_USEC);
> if (ret == -ETIMEDOUT)
> xhci_err(xhci, "Host took too long to start, "
> - "waited %u microseconds.\n",
> + "waited %u usec.\n",
> XHCI_MAX_HALT_USEC);
> if (!ret)
> /* clear state flags. Including dying, halted or removing */
>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-15 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 5:45 [PATCH] xhci: Fix log mistake of xhci_start jiahao
2020-05-15 6:53 ` Mathias Nyman
2020-05-15 9:21 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).