From: Johan Hovold <johan@kernel.org>
To: Charles Yeh <charlesyeh522@gmail.com>
Cc: "Johan Hovold" <johan@kernel.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Yeh.Charles [葉榮鑫]" <charles-yeh@prolific.com.tw>
Subject: Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)
Date: Mon, 23 Sep 2019 15:08:04 +0200 [thread overview]
Message-ID: <20190923130804.GC30545@localhost> (raw)
In-Reply-To: <CAAZvQQ6MPrsfTcsnyD4DbKDVJf1WyLoxqW7q07k2RO1Cs5yd5Q@mail.gmail.com>
On Mon, Sep 23, 2019 at 06:35:19PM +0800, Charles Yeh wrote:
> Johan Hovold <johan@kernel.org> 於 2019年9月23日 週一 下午6:24寫道：
> > That looks much better. But please move the reset defines above the
> > flow control ones to keep the registers sorted by address (0x7 < 0xa).
>
> Thank you for your reply
>
> Charles Ans:
> The new define is follows
>
> #define PL2303_READ_TYPE_HX_STATUS 0x8080
>
> #define PL2303_HXN_RESET_REG 0x07
> #define PL2303_HXN_RESET_UPSTREAM_PIPE 0x02
> #define PL2303_HXN_RESET_DOWNSTREAM_PIPE 0x01
>
> #define PL2303_HXN_FLOWCTRL_REG 0x0A
> #define PL2303_HXN_FLOWCTRL_MASK 0x1C
> #define PL2303_HXN_FLOWCTRL_NONE 0x1C
> #define PL2303_HXN_FLOWCTRL_RTS_CTS 0x18
> #define PL2303_HXN_FLOWCTRL_XON_XOFF 0x0C
>
>
> > Also looks good, thanks. Just move the reset define block as mentioned
> > above.
>
> Thank you for your reply
>
>
> Please confirm the above new define
> If there is no problem.. I will write a new Patch file.
Yes, the above looks good.
Johan
next prev parent reply other threads:[~2019-09-23 13:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 12:30 [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN) Charles Yeh
2019-07-05 2:57 ` Charles Yeh
2019-07-05 5:18 ` Greg KH
2019-07-16 8:49 ` Johan Hovold
2019-08-27 8:40 ` Charles Yeh
2019-09-18 5:46 ` Charles Yeh
2019-09-20 7:56 ` Johan Hovold
2019-09-23 9:53 ` Charles Yeh
2019-09-23 10:24 ` Johan Hovold
2019-09-23 10:35 ` Charles Yeh
2019-09-23 13:08 ` Johan Hovold [this message]
2019-09-25 1:20 ` Charles Yeh
2019-09-25 8:06 ` Johan Hovold
2019-09-25 9:36 ` Charles Yeh
2019-09-25 9:38 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923130804.GC30545@localhost \
--to=johan@kernel.org \
--cc=charles-yeh@prolific.com.tw \
--cc=charlesyeh522@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).