From: Charles Yeh <charlesyeh522@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Yeh.Charles [葉榮鑫]" <charles-yeh@prolific.com.tw>
Subject: Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)
Date: Mon, 23 Sep 2019 17:53:34 +0800 [thread overview]
Message-ID: <CAAZvQQ6613eO6G0Gm-Sv3yWqTG_rRrynF=xVSLgz2uakXU2=ZQ@mail.gmail.com> (raw)
In-Reply-To: <20190920075602.GI30545@localhost>
Johan Hovold <johan@kernel.org> 於 2019年9月20日 週五 下午3:56寫道:
> Yes, that's better, but you're mixing register addresses, bit values and
> masks above. Perhaps things would be more clear if you but a _REG suffix
> on the register defines and order things as follows:
>
> #define PL2303_HXN_<name1>_REG 0xX1
> #define PL2303_HXN_<name1>_<field>_MASK 0xY1
> #define PL2303_HXN_<name1>_<field>_<value> 0xZ1
>
> #define PL2303_HXN_<name2>_REG 0xX2
> #define PL2303_HXN_<name2>_<field>_MASK 0xY2
> #define PL2303_HXN_<name2>_<field>_<value> 0xZ2
>
> The idea is simply to keep related defines together and not mix
> register address, masks and value defines.
>
> Keep registers sorted by address, and bit masks and values by bit order
> (e.g. MSB first).
Thank you for your reply
Charles Ans:
The new define is follows
#define PL2303_READ_TYPE_HX_STATUS 0x8080
#define PL2303_HXN_FLOWCTRL_REG 0x0A
#define PL2303_HXN_FLOWCTRL_MASK 0x1C
#define PL2303_HXN_FLOWCTRL_NONE 0x1C
#define PL2303_HXN_FLOWCTRL_RTS_CTS 0x18
#define PL2303_HXN_FLOWCTRL_XON_XOFF 0x0C
#define PL2303_HXN_RESET_REG 0x07
#define PL2303_HXN_RESET_UPSTREAM_PIPE 0x02
#define PL2303_HXN_RESET_DOWNSTREAM_PIPE 0x01
> Yes, but that doesn't imply that you need to read back the old value.
>
> I'm assuming it would either always read back as 0, or you would read
> back the previous value written, which means you could end up resetting
> something you did not intend.
>
> Either way, you should not read back the current value when resetting
> the data pipes.
>
Thank you for your reply
Charles Ans:
The new code is follows
pl2303_vendor_write(serial,
PL2303_HXN_RESET_REG,
PL2303_HXN_RESET_UPSTREAM_PIPE |
PL2303_HXN_RESET_DOWNSTREAM_PIPE);
Please confirm the above new define & code..
If there is no problem.. I will write a new Patch file.
Charles.
next prev parent reply other threads:[~2019-09-23 9:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 12:30 [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN) Charles Yeh
2019-07-05 2:57 ` Charles Yeh
2019-07-05 5:18 ` Greg KH
2019-07-16 8:49 ` Johan Hovold
2019-08-27 8:40 ` Charles Yeh
2019-09-18 5:46 ` Charles Yeh
2019-09-20 7:56 ` Johan Hovold
2019-09-23 9:53 ` Charles Yeh [this message]
2019-09-23 10:24 ` Johan Hovold
2019-09-23 10:35 ` Charles Yeh
2019-09-23 13:08 ` Johan Hovold
2019-09-25 1:20 ` Charles Yeh
2019-09-25 8:06 ` Johan Hovold
2019-09-25 9:36 ` Charles Yeh
2019-09-25 9:38 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAZvQQ6613eO6G0Gm-Sv3yWqTG_rRrynF=xVSLgz2uakXU2=ZQ@mail.gmail.com' \
--to=charlesyeh522@gmail.com \
--cc=charles-yeh@prolific.com.tw \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).