* [PATCH v3 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW
2020-01-20 14:09 [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW Thomas Hebb
@ 2020-01-20 14:09 ` Thomas Hebb
2020-01-20 14:25 ` Guenter Roeck
` (2 more replies)
2020-01-20 14:25 ` [PATCH v3 1/2] usb: typec: wcove: " Guenter Roeck
2020-01-20 15:05 ` Heikki Krogerus
2 siblings, 3 replies; 7+ messages in thread
From: Thomas Hebb @ 2020-01-20 14:09 UTC (permalink / raw)
To: linux-kernel
Cc: stable, Thomas Hebb, Greg Kroah-Hartman, Guenter Roeck,
Hans de Goede, Heikki Krogerus, linux-usb
commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
port") didn't convert this value from mW to uW when migrating to a new
specification format like it should have.
Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
---
Changes in v3: None
Changes in v2: None
drivers/usb/typec/tcpm/fusb302.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index ed8655c6af8c..b498960ff72b 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -1666,7 +1666,7 @@ static const struct property_entry port_props[] = {
PROPERTY_ENTRY_STRING("try-power-role", "sink"),
PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
- PROPERTY_ENTRY_U32("op-sink-microwatt", 2500),
+ PROPERTY_ENTRY_U32("op-sink-microwatt", 2500000),
{ }
};
--
2.24.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW
2020-01-20 14:09 ` [PATCH v3 2/2] usb: typec: fusb302: " Thomas Hebb
@ 2020-01-20 14:25 ` Guenter Roeck
2020-01-20 15:05 ` Heikki Krogerus
2020-01-22 9:12 ` Greg Kroah-Hartman
2 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2020-01-20 14:25 UTC (permalink / raw)
To: Thomas Hebb, linux-kernel
Cc: stable, Greg Kroah-Hartman, Hans de Goede, Heikki Krogerus, linux-usb
On 1/20/20 6:09 AM, Thomas Hebb wrote:
> commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> port") didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
>
> Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index ed8655c6af8c..b498960ff72b 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1666,7 +1666,7 @@ static const struct property_entry port_props[] = {
> PROPERTY_ENTRY_STRING("try-power-role", "sink"),
> PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
> PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
> - PROPERTY_ENTRY_U32("op-sink-microwatt", 2500),
> + PROPERTY_ENTRY_U32("op-sink-microwatt", 2500000),
> { }
> };
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW
2020-01-20 14:09 ` [PATCH v3 2/2] usb: typec: fusb302: " Thomas Hebb
2020-01-20 14:25 ` Guenter Roeck
@ 2020-01-20 15:05 ` Heikki Krogerus
2020-01-22 9:12 ` Greg Kroah-Hartman
2 siblings, 0 replies; 7+ messages in thread
From: Heikki Krogerus @ 2020-01-20 15:05 UTC (permalink / raw)
To: Thomas Hebb
Cc: linux-kernel, stable, Greg Kroah-Hartman, Guenter Roeck,
Hans de Goede, linux-usb
On Mon, Jan 20, 2020 at 06:09:06AM -0800, Thomas Hebb wrote:
> commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> port") didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
>
> Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index ed8655c6af8c..b498960ff72b 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1666,7 +1666,7 @@ static const struct property_entry port_props[] = {
> PROPERTY_ENTRY_STRING("try-power-role", "sink"),
> PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
> PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
> - PROPERTY_ENTRY_U32("op-sink-microwatt", 2500),
> + PROPERTY_ENTRY_U32("op-sink-microwatt", 2500000),
> { }
> };
>
> --
> 2.24.1
thanks,
--
heikki
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW
2020-01-20 14:09 ` [PATCH v3 2/2] usb: typec: fusb302: " Thomas Hebb
2020-01-20 14:25 ` Guenter Roeck
2020-01-20 15:05 ` Heikki Krogerus
@ 2020-01-22 9:12 ` Greg Kroah-Hartman
2 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-22 9:12 UTC (permalink / raw)
To: Thomas Hebb
Cc: linux-kernel, stable, Guenter Roeck, Hans de Goede,
Heikki Krogerus, linux-usb
On Mon, Jan 20, 2020 at 06:09:06AM -0800, Thomas Hebb wrote:
> commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> port") didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
>
> Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Changes in v3: None
Not true, you changed the stable address :(
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW
2020-01-20 14:09 [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW Thomas Hebb
2020-01-20 14:09 ` [PATCH v3 2/2] usb: typec: fusb302: " Thomas Hebb
@ 2020-01-20 14:25 ` Guenter Roeck
2020-01-20 15:05 ` Heikki Krogerus
2 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2020-01-20 14:25 UTC (permalink / raw)
To: Thomas Hebb, linux-kernel
Cc: stable, Greg Kroah-Hartman, Heikki Krogerus, linux-usb
On 1/20/20 6:09 AM, Thomas Hebb wrote:
> commit 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
>
> Fixes: 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> ---
>
> Changes in v3:
> - Use the right stable email address
>
> Changes in v2:
> - Split fix into two patches
> - Added stable cc
>
> drivers/usb/typec/tcpm/wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/wcove.c b/drivers/usb/typec/tcpm/wcove.c
> index edc271da14f4..9b745f432c91 100644
> --- a/drivers/usb/typec/tcpm/wcove.c
> +++ b/drivers/usb/typec/tcpm/wcove.c
> @@ -597,7 +597,7 @@ static const struct property_entry wcove_props[] = {
> PROPERTY_ENTRY_STRING("try-power-role", "sink"),
> PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
> PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
> - PROPERTY_ENTRY_U32("op-sink-microwatt", 15000),
> + PROPERTY_ENTRY_U32("op-sink-microwatt", 15000000),
> { }
> };
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW
2020-01-20 14:09 [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW Thomas Hebb
2020-01-20 14:09 ` [PATCH v3 2/2] usb: typec: fusb302: " Thomas Hebb
2020-01-20 14:25 ` [PATCH v3 1/2] usb: typec: wcove: " Guenter Roeck
@ 2020-01-20 15:05 ` Heikki Krogerus
2 siblings, 0 replies; 7+ messages in thread
From: Heikki Krogerus @ 2020-01-20 15:05 UTC (permalink / raw)
To: Thomas Hebb
Cc: linux-kernel, stable, Greg Kroah-Hartman, Guenter Roeck, linux-usb
On Mon, Jan 20, 2020 at 06:09:05AM -0800, Thomas Hebb wrote:
> commit 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
>
> Fixes: 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>
> Changes in v3:
> - Use the right stable email address
>
> Changes in v2:
> - Split fix into two patches
> - Added stable cc
>
> drivers/usb/typec/tcpm/wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/wcove.c b/drivers/usb/typec/tcpm/wcove.c
> index edc271da14f4..9b745f432c91 100644
> --- a/drivers/usb/typec/tcpm/wcove.c
> +++ b/drivers/usb/typec/tcpm/wcove.c
> @@ -597,7 +597,7 @@ static const struct property_entry wcove_props[] = {
> PROPERTY_ENTRY_STRING("try-power-role", "sink"),
> PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
> PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
> - PROPERTY_ENTRY_U32("op-sink-microwatt", 15000),
> + PROPERTY_ENTRY_U32("op-sink-microwatt", 15000000),
> { }
> };
>
> --
> 2.24.1
thanks,
--
heikki
^ permalink raw reply [flat|nested] 7+ messages in thread