* [PATCH] usb: gadget: s3c: Remove unused 'udc' variable
@ 2020-07-31 7:41 Krzysztof Kozlowski
2020-07-31 18:38 ` Nathan Chancellor
2020-08-19 19:11 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-31 7:41 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Gustavo A. R. Silva,
Chunfeng Yun, Nathan Chancellor, Krzysztof Kozlowski, linux-usb,
linux-kernel
Remove unused 'udc' variable to fix compile warnings:
drivers/usb/gadget/udc/s3c2410_udc.c: In function 's3c2410_udc_dequeue':
drivers/usb/gadget/udc/s3c2410_udc.c:1268:22: warning: variable 'udc' set but not used [-Wunused-but-set-variable]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/usb/gadget/udc/s3c2410_udc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
index bc2e8eb737c3..e875a0b967c0 100644
--- a/drivers/usb/gadget/udc/s3c2410_udc.c
+++ b/drivers/usb/gadget/udc/s3c2410_udc.c
@@ -1270,7 +1270,6 @@ static int s3c2410_udc_queue(struct usb_ep *_ep, struct usb_request *_req,
static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)
{
struct s3c2410_ep *ep = to_s3c2410_ep(_ep);
- struct s3c2410_udc *udc;
int retval = -EINVAL;
unsigned long flags;
struct s3c2410_request *req = NULL;
@@ -1283,8 +1282,6 @@ static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)
if (!_ep || !_req)
return retval;
- udc = to_s3c2410_udc(ep->gadget);
-
local_irq_save(flags);
list_for_each_entry(req, &ep->queue, queue) {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: gadget: s3c: Remove unused 'udc' variable
2020-07-31 7:41 [PATCH] usb: gadget: s3c: Remove unused 'udc' variable Krzysztof Kozlowski
@ 2020-07-31 18:38 ` Nathan Chancellor
2020-08-19 19:11 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2020-07-31 18:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Felipe Balbi, Greg Kroah-Hartman, Gustavo A. R. Silva,
Chunfeng Yun, linux-usb, linux-kernel
On Fri, Jul 31, 2020 at 09:41:22AM +0200, Krzysztof Kozlowski wrote:
> Remove unused 'udc' variable to fix compile warnings:
>
> drivers/usb/gadget/udc/s3c2410_udc.c: In function 's3c2410_udc_dequeue':
> drivers/usb/gadget/udc/s3c2410_udc.c:1268:22: warning: variable 'udc' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Weird, looks like it has been unused since the introduction of the
driver.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/usb/gadget/udc/s3c2410_udc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
> index bc2e8eb737c3..e875a0b967c0 100644
> --- a/drivers/usb/gadget/udc/s3c2410_udc.c
> +++ b/drivers/usb/gadget/udc/s3c2410_udc.c
> @@ -1270,7 +1270,6 @@ static int s3c2410_udc_queue(struct usb_ep *_ep, struct usb_request *_req,
> static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)
> {
> struct s3c2410_ep *ep = to_s3c2410_ep(_ep);
> - struct s3c2410_udc *udc;
> int retval = -EINVAL;
> unsigned long flags;
> struct s3c2410_request *req = NULL;
> @@ -1283,8 +1282,6 @@ static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)
> if (!_ep || !_req)
> return retval;
>
> - udc = to_s3c2410_udc(ep->gadget);
> -
> local_irq_save(flags);
>
> list_for_each_entry(req, &ep->queue, queue) {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: gadget: s3c: Remove unused 'udc' variable
2020-07-31 7:41 [PATCH] usb: gadget: s3c: Remove unused 'udc' variable Krzysztof Kozlowski
2020-07-31 18:38 ` Nathan Chancellor
@ 2020-08-19 19:11 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-19 19:11 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Gustavo A. R. Silva,
Chunfeng Yun, Nathan Chancellor, linux-usb, linux-kernel
On Fri, Jul 31, 2020 at 09:41:22AM +0200, Krzysztof Kozlowski wrote:
> Remove unused 'udc' variable to fix compile warnings:
>
> drivers/usb/gadget/udc/s3c2410_udc.c: In function 's3c2410_udc_dequeue':
> drivers/usb/gadget/udc/s3c2410_udc.c:1268:22: warning: variable 'udc' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/usb/gadget/udc/s3c2410_udc.c | 3 ---
Applied along with other mach-s3c (and related usb) cleanups to
samsung-soc.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-19 19:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31 7:41 [PATCH] usb: gadget: s3c: Remove unused 'udc' variable Krzysztof Kozlowski
2020-07-31 18:38 ` Nathan Chancellor
2020-08-19 19:11 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).