* [PATCH] usb: dwc2: gadget: use existing helper
@ 2021-11-22 12:31 John Keeping
2021-11-23 5:17 ` Minas Harutyunyan
0 siblings, 1 reply; 2+ messages in thread
From: John Keeping @ 2021-11-22 12:31 UTC (permalink / raw)
To: Minas Harutyunyan
Cc: John Keeping, Greg Kroah-Hartman, linux-usb, linux-kernel
All other checks of params.g_dma_desc in this file use the
using_desc_dma() helper function. Use that helper in two more places
for consistency throughout the file.
Signed-off-by: John Keeping <john@metanate.com>
---
drivers/usb/dwc2/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index ab8d7dad9f567..b884a83b26a6e 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -5217,7 +5217,7 @@ int dwc2_restore_device_registers(struct dwc2_hsotg *hsotg, int remote_wakeup)
* as result BNA interrupt asserted on hibernation exit
* by restoring from saved area.
*/
- if (hsotg->params.g_dma_desc &&
+ if (using_desc_dma(hsotg) &&
(dr->diepctl[i] & DXEPCTL_EPENA))
dr->diepdma[i] = hsotg->eps_in[i]->desc_list_dma;
dwc2_writel(hsotg, dr->dtxfsiz[i], DPTXFSIZN(i));
@@ -5229,7 +5229,7 @@ int dwc2_restore_device_registers(struct dwc2_hsotg *hsotg, int remote_wakeup)
* as result BNA interrupt asserted on hibernation exit
* by restoring from saved area.
*/
- if (hsotg->params.g_dma_desc &&
+ if (using_desc_dma(hsotg) &&
(dr->doepctl[i] & DXEPCTL_EPENA))
dr->doepdma[i] = hsotg->eps_out[i]->desc_list_dma;
dwc2_writel(hsotg, dr->doepdma[i], DOEPDMA(i));
--
2.34.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc2: gadget: use existing helper
2021-11-22 12:31 [PATCH] usb: dwc2: gadget: use existing helper John Keeping
@ 2021-11-23 5:17 ` Minas Harutyunyan
0 siblings, 0 replies; 2+ messages in thread
From: Minas Harutyunyan @ 2021-11-23 5:17 UTC (permalink / raw)
To: John Keeping; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
On 11/22/2021 4:31 PM, John Keeping wrote:
> All other checks of params.g_dma_desc in this file use the
> using_desc_dma() helper function. Use that helper in two more places
> for consistency throughout the file.
>
> Signed-off-by: John Keeping <john@metanate.com>
Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
> ---
> drivers/usb/dwc2/gadget.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index ab8d7dad9f567..b884a83b26a6e 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -5217,7 +5217,7 @@ int dwc2_restore_device_registers(struct dwc2_hsotg *hsotg, int remote_wakeup)
> * as result BNA interrupt asserted on hibernation exit
> * by restoring from saved area.
> */
> - if (hsotg->params.g_dma_desc &&
> + if (using_desc_dma(hsotg) &&
> (dr->diepctl[i] & DXEPCTL_EPENA))
> dr->diepdma[i] = hsotg->eps_in[i]->desc_list_dma;
> dwc2_writel(hsotg, dr->dtxfsiz[i], DPTXFSIZN(i));
> @@ -5229,7 +5229,7 @@ int dwc2_restore_device_registers(struct dwc2_hsotg *hsotg, int remote_wakeup)
> * as result BNA interrupt asserted on hibernation exit
> * by restoring from saved area.
> */
> - if (hsotg->params.g_dma_desc &&
> + if (using_desc_dma(hsotg) &&
> (dr->doepctl[i] & DXEPCTL_EPENA))
> dr->doepdma[i] = hsotg->eps_out[i]->desc_list_dma;
> dwc2_writel(hsotg, dr->doepdma[i], DOEPDMA(i));
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-23 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 12:31 [PATCH] usb: dwc2: gadget: use existing helper John Keeping
2021-11-23 5:17 ` Minas Harutyunyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).