From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: <linux-usb@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH 3/4] usb: host: ehci-sh: propagate errors from platform_get_irq()
Date: Tue, 14 Dec 2021 23:42:46 +0300 [thread overview]
Message-ID: <20211214204247.7172-4-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20211214204247.7172-1-s.shtylyov@omp.ru>
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -ENODEV. Switch to propagating the error codes upstream. IRQ0 is no
longer returned by platform_get_irq(), so we now can safely ignore it...
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/ehci-sh.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c
index c25c51d26f26..882231b5c382 100644
--- a/drivers/usb/host/ehci-sh.c
+++ b/drivers/usb/host/ehci-sh.c
@@ -82,8 +82,8 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev)
return -ENODEV;
irq = platform_get_irq(pdev, 0);
- if (irq <= 0) {
- ret = -ENODEV;
+ if (irq < 0) {
+ ret = irq;
goto fail_create_hcd;
}
--
2.26.3
next prev parent reply other threads:[~2021-12-14 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 20:42 [PATCH 0/4] Propagate errors from platform_get_irq() in the USB drivers Sergey Shtylyov
2021-12-14 20:42 ` [PATCH 1/4] usb: gadget: udc: bcm63xx: propagate errors from platform_get_irq() Sergey Shtylyov
2021-12-16 3:48 ` Florian Fainelli
2021-12-14 20:42 ` [PATCH 2/4] usb: gadget: udc: pxa25x: " Sergey Shtylyov
2021-12-17 10:32 ` Daniel Mack
2021-12-17 11:11 ` Greg Kroah-Hartman
2021-12-14 20:42 ` Sergey Shtylyov [this message]
2021-12-14 21:04 ` [PATCH 3/4] usb: host: ehci-sh: " Alan Stern
2021-12-14 20:42 ` [PATCH 4/4] usb: host: ohci-omap: " Sergey Shtylyov
2021-12-14 21:04 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211214204247.7172-4-s.shtylyov@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).