From: Alan Stern <stern@rowland.harvard.edu>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 4/4] usb: host: ohci-omap: propagate errors from platform_get_irq()
Date: Tue, 14 Dec 2021 16:04:41 -0500 [thread overview]
Message-ID: <YbkG6dui2A2yBiFX@rowland.harvard.edu> (raw)
In-Reply-To: <20211214204247.7172-5-s.shtylyov@omp.ru>
On Tue, Dec 14, 2021 at 11:42:47PM +0300, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -ENXIO for some strange reason. Switch to propagating the error codes
> upstream.
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/ohci-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
> index ded9738392e4..45dcf8292072 100644
> --- a/drivers/usb/host/ohci-omap.c
> +++ b/drivers/usb/host/ohci-omap.c
> @@ -306,7 +306,7 @@ static int ohci_hcd_omap_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - retval = -ENXIO;
> + retval = irq;
> goto err3;
> }
> retval = usb_add_hcd(hcd, irq, 0);
> --
> 2.26.3
>
prev parent reply other threads:[~2021-12-14 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 20:42 [PATCH 0/4] Propagate errors from platform_get_irq() in the USB drivers Sergey Shtylyov
2021-12-14 20:42 ` [PATCH 1/4] usb: gadget: udc: bcm63xx: propagate errors from platform_get_irq() Sergey Shtylyov
2021-12-16 3:48 ` Florian Fainelli
2021-12-14 20:42 ` [PATCH 2/4] usb: gadget: udc: pxa25x: " Sergey Shtylyov
2021-12-17 10:32 ` Daniel Mack
2021-12-17 11:11 ` Greg Kroah-Hartman
2021-12-14 20:42 ` [PATCH 3/4] usb: host: ehci-sh: " Sergey Shtylyov
2021-12-14 21:04 ` Alan Stern
2021-12-14 20:42 ` [PATCH 4/4] usb: host: ohci-omap: " Sergey Shtylyov
2021-12-14 21:04 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbkG6dui2A2yBiFX@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).