From: Daniel Mack <daniel@zonque.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] usb: gadget: udc: pxa25x: propagate errors from platform_get_irq()
Date: Fri, 17 Dec 2021 11:32:58 +0100 [thread overview]
Message-ID: <32d35b68-50e9-a280-d0f7-edef8165825a@zonque.org> (raw)
In-Reply-To: <20211214204247.7172-3-s.shtylyov@omp.ru>
On 12/14/21 21:42, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -ENODEV for some strange reason. Switch to propagating the error codes
> upstream.
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: Daniel Mack <daniel@zonque.org>
Greg, could you take this through your tree?
Best,
Daniel
> ---
> drivers/usb/gadget/udc/pxa25x_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c
> index 52cdfd8212d6..b38747fd3bb0 100644
> --- a/drivers/usb/gadget/udc/pxa25x_udc.c
> +++ b/drivers/usb/gadget/udc/pxa25x_udc.c
> @@ -2364,7 +2364,7 @@ static int pxa25x_udc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return -ENODEV;
> + return irq;
>
> dev->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dev->regs))
>
next prev parent reply other threads:[~2021-12-17 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 20:42 [PATCH 0/4] Propagate errors from platform_get_irq() in the USB drivers Sergey Shtylyov
2021-12-14 20:42 ` [PATCH 1/4] usb: gadget: udc: bcm63xx: propagate errors from platform_get_irq() Sergey Shtylyov
2021-12-16 3:48 ` Florian Fainelli
2021-12-14 20:42 ` [PATCH 2/4] usb: gadget: udc: pxa25x: " Sergey Shtylyov
2021-12-17 10:32 ` Daniel Mack [this message]
2021-12-17 11:11 ` Greg Kroah-Hartman
2021-12-14 20:42 ` [PATCH 3/4] usb: host: ehci-sh: " Sergey Shtylyov
2021-12-14 21:04 ` Alan Stern
2021-12-14 20:42 ` [PATCH 4/4] usb: host: ohci-omap: " Sergey Shtylyov
2021-12-14 21:04 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32d35b68-50e9-a280-d0f7-edef8165825a@zonque.org \
--to=daniel@zonque.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).