From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Florian Fainelli <f.fainelli@gmail.com>,
gregkh@linuxfoundation.org, wahrenst@gmx.net, robh@kernel.org,
mathias.nyman@linux.intel.com, Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-usb@vger.kernel.org,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: linux-kernel@vger.kernel.org, tim.gover@raspberrypi.org,
helgaas@kernel.org, lorenzo.pieralisi@arm.com,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/9] dt-bindings: reset: Add a binding for the RPi Firmware USB reset
Date: Tue, 09 Jun 2020 13:14:17 +0200 [thread overview]
Message-ID: <2cee4af79f5f599eb1a6c1f6f0ece504eb111799.camel@suse.de> (raw)
In-Reply-To: <ffc9ec9e-bd1c-a8dd-8a68-a15bf95c919b@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]
On Mon, 2020-06-08 at 12:58 -0700, Florian Fainelli wrote:
>
> On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote:
> > The firmware running on the RPi VideoCore can be used to reset and
> > initialize the board's xHCI controller. The reset controller is passed
> > to the PCI device through the DT, hence this binding.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > ---
> > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 21 +++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > firmware.yaml
> > b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > firmware.yaml
> > index b48ed875eb8e..8f9d0986c28f 100644
> > --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > firmware.yaml
> > +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > firmware.yaml
> > @@ -39,6 +39,22 @@ properties:
> > - compatible
> > - "#clock-cells"
> >
> > + usb-reset:
> > + type: object
> > +
> > + properties:
> > + compatible:
> > + const: raspberrypi,firmware-usb-reset
>
> I would make this less USB centric, even if this is the only consumer of
> the reset controller for now, there could, in premise be other blocks
> that require a reset (e.g.: V3D) that would involve going to the VPU
> firmware because of various requirements (security, register blocking etc.).
I like the idea, I'll introduce this in v2.
> > +
> > + "#clock-cells":
>
> Did not you mean #reset-cells here?
>
Sorry I missed that.
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-09 11:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 19:26 [PATCH 0/9] Raspberry Pi 4 USB firmware initialization rework Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 1/9] dt-bindings: reset: Add a binding for the RPi Firmware USB reset Nicolas Saenz Julienne
2020-06-08 19:58 ` Florian Fainelli
2020-06-09 11:14 ` Nicolas Saenz Julienne [this message]
2020-06-08 19:26 ` [PATCH 2/9] reset: Add Raspberry Pi 4 firmware USB reset controller Nicolas Saenz Julienne
2020-06-08 20:13 ` Florian Fainelli
2020-06-08 19:26 ` [PATCH 3/9] ARM: dts: bcm2711: Add firmware usb reset node Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 4/9] ARM: dts: bcm2711: Add reset controller to xHCI node Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 5/9] usb: xhci-pci: Add support for reset controllers Nicolas Saenz Julienne
2020-06-08 19:43 ` Florian Fainelli
2020-06-09 11:18 ` Nicolas Saenz Julienne
2020-06-09 11:59 ` Philipp Zabel
2020-06-09 13:08 ` Nicolas Saenz Julienne
[not found] ` <CAHp75VdWq96SSzB1S9pM=H8=3np8-1Cep_9BqGiTCUTtCUt-yw@mail.gmail.com>
2020-06-09 11:19 ` Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 6/9] Revert "USB: pci-quirks: Add Raspberry Pi 4 quirk" Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 7/9] usb: host: pci-quirks: Bypass xHCI quirks for Raspberry Pi 4 Nicolas Saenz Julienne
2020-06-08 19:50 ` Florian Fainelli
2020-06-08 19:27 ` [PATCH 8/9] Revert "firmware: raspberrypi: Introduce vl805 init routine" Nicolas Saenz Julienne
2020-06-08 19:27 ` [PATCH 9/9] Revert "PCI: brcmstb: Wait for Raspberry Pi's firmware when present" Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cee4af79f5f599eb1a6c1f6f0ece504eb111799.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mathias.nyman@linux.intel.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tim.gover@raspberrypi.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).