From: Florian Fainelli <f.fainelli@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
f.fainelli@gmail.com, gregkh@linuxfoundation.org,
wahrenst@gmx.net, robh@kernel.org, mathias.nyman@linux.intel.com,
Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-usb@vger.kernel.org,
Mathias Nyman <mathias.nyman@intel.com>
Cc: linux-kernel@vger.kernel.org, tim.gover@raspberrypi.org,
helgaas@kernel.org, lorenzo.pieralisi@arm.com
Subject: Re: [PATCH 7/9] usb: host: pci-quirks: Bypass xHCI quirks for Raspberry Pi 4
Date: Mon, 8 Jun 2020 12:50:58 -0700 [thread overview]
Message-ID: <6b1084e1-05ca-5321-46fd-7b6f83224a49@gmail.com> (raw)
In-Reply-To: <20200608192701.18355-8-nsaenzjulienne@suse.de>
On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote:
> The board doesn't need the quirks to be run, and takes case of its own
(if you have to resubmit) takes care
> initialization trough a reset controller device. So let's bypass it
its quirk.
> quirk.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/usb/host/pci-quirks.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index 92150ecdb036..4b3be05d1290 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -16,6 +16,8 @@
> #include <linux/export.h>
> #include <linux/acpi.h>
> #include <linux/dmi.h>
> +#include <linux/of.h>
> +
> #include "pci-quirks.h"
> #include "xhci-ext-caps.h"
>
> @@ -1248,6 +1250,16 @@ static void quirk_usb_early_handoff(struct pci_dev *pdev)
> */
> if (pdev->vendor == 0x184e) /* vendor Netlogic */
> return;
> +
> + /*
> + * Bypass the Raspberry Pi 4 controller xHCI controller, things are
> + * taken care by the board's co-processor.
taken care of by.
With that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> + */
> + if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483 &&
> + of_device_is_compatible(of_get_parent(pdev->bus->dev.of_node),
> + "brcm,bcm2711-pcie"))
> + return;
> +
> if (pdev->class != PCI_CLASS_SERIAL_USB_UHCI &&
> pdev->class != PCI_CLASS_SERIAL_USB_OHCI &&
> pdev->class != PCI_CLASS_SERIAL_USB_EHCI &&
>
--
Florian
next prev parent reply other threads:[~2020-06-08 19:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 19:26 [PATCH 0/9] Raspberry Pi 4 USB firmware initialization rework Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 1/9] dt-bindings: reset: Add a binding for the RPi Firmware USB reset Nicolas Saenz Julienne
2020-06-08 19:58 ` Florian Fainelli
2020-06-09 11:14 ` Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 2/9] reset: Add Raspberry Pi 4 firmware USB reset controller Nicolas Saenz Julienne
2020-06-08 20:13 ` Florian Fainelli
2020-06-08 19:26 ` [PATCH 3/9] ARM: dts: bcm2711: Add firmware usb reset node Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 4/9] ARM: dts: bcm2711: Add reset controller to xHCI node Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 5/9] usb: xhci-pci: Add support for reset controllers Nicolas Saenz Julienne
2020-06-08 19:43 ` Florian Fainelli
2020-06-09 11:18 ` Nicolas Saenz Julienne
2020-06-09 11:59 ` Philipp Zabel
2020-06-09 13:08 ` Nicolas Saenz Julienne
[not found] ` <CAHp75VdWq96SSzB1S9pM=H8=3np8-1Cep_9BqGiTCUTtCUt-yw@mail.gmail.com>
2020-06-09 11:19 ` Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 6/9] Revert "USB: pci-quirks: Add Raspberry Pi 4 quirk" Nicolas Saenz Julienne
2020-06-08 19:26 ` [PATCH 7/9] usb: host: pci-quirks: Bypass xHCI quirks for Raspberry Pi 4 Nicolas Saenz Julienne
2020-06-08 19:50 ` Florian Fainelli [this message]
2020-06-08 19:27 ` [PATCH 8/9] Revert "firmware: raspberrypi: Introduce vl805 init routine" Nicolas Saenz Julienne
2020-06-08 19:27 ` [PATCH 9/9] Revert "PCI: brcmstb: Wait for Raspberry Pi's firmware when present" Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b1084e1-05ca-5321-46fd-7b6f83224a49@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=nsaenzjulienne@suse.de \
--cc=robh@kernel.org \
--cc=tim.gover@raspberrypi.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).