* Usb midi device does not work on wake @ 2020-01-12 12:06 Richard Dodd 2020-01-13 9:23 ` Oliver Neukum 0 siblings, 1 reply; 8+ messages in thread From: Richard Dodd @ 2020-01-12 12:06 UTC (permalink / raw) To: linux-usb Hello I've got a Novation midi-over-usb device (LaunchControl XL) that works correctly on boot, but remains in power-off mode when waking from sleep. I suspect that there is some sort of initialisation that needs to be applied. Could anyone suggest possible causes, or point me in the direction of the relevant source code. I found `sound/usb/quirks.c`, which seems to be the place to handle this kind of thing, but there is no mention of my device anywhere in the source tree at present (1235:0061). Thanks in advance for your help Richard ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Usb midi device does not work on wake 2020-01-12 12:06 Usb midi device does not work on wake Richard Dodd @ 2020-01-13 9:23 ` Oliver Neukum 2020-01-29 15:47 ` Richard Dodd 0 siblings, 1 reply; 8+ messages in thread From: Oliver Neukum @ 2020-01-13 9:23 UTC (permalink / raw) To: Richard Dodd, linux-usb Am Sonntag, den 12.01.2020, 12:06 +0000 schrieb Richard Dodd: > Hello > > I've got a Novation midi-over-usb device (LaunchControl XL) that works > correctly on boot, but remains in power-off mode when waking from > sleep. > > I suspect that there is some sort of initialisation that needs to be > applied. Could anyone suggest possible causes, or point me in the > direction of the relevant source code. I found `sound/usb/quirks.c`, > which seems to be the place to handle this kind of thing, but there is > no mention of my device anywhere in the source tree at present > (1235:0061). Hi, some devices need an additional reset. They have the quirk RESET_RESUME in that file. Try adding your device to that list and recompile your kernel. HTH Oliver ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Usb midi device does not work on wake 2020-01-13 9:23 ` Oliver Neukum @ 2020-01-29 15:47 ` Richard Dodd 2020-01-30 6:34 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Richard Dodd @ 2020-01-29 15:47 UTC (permalink / raw) To: Oliver Neukum; +Cc: linux-usb [-- Attachment #1: Type: text/plain, Size: 1136 bytes --] On Mon, Jan 13, 2020 at 9:40 AM Oliver Neukum <oneukum@suse.com> wrote: > > Am Sonntag, den 12.01.2020, 12:06 +0000 schrieb Richard Dodd: > > Hello > > > > I've got a Novation midi-over-usb device (LaunchControl XL) that works > > correctly on boot, but remains in power-off mode when waking from > > sleep. > > > > I suspect that there is some sort of initialisation that needs to be > > applied. Could anyone suggest possible causes, or point me in the > > direction of the relevant source code. I found `sound/usb/quirks.c`, > > which seems to be the place to handle this kind of thing, but there is > > no mention of my device anywhere in the source tree at present > > (1235:0061). > > Hi, > > some devices need an additional reset. They have the quirk RESET_RESUME > in that file. Try adding your device to that list and recompile your > kernel. > > HTH > Oliver > Hi I found the list you are talking about in `drivers/usb/core/quirks.c`, and when I patched it, my device correctly woke up after suspend. :) Can I upstream the patch by posting it here. The patch is attached to this email. Thanks Rich [-- Attachment #2: patch --] [-- Type: application/octet-stream, Size: 503 bytes --] diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 6b6413073584..3db6c05aaa4b 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -445,6 +445,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /* novation SoundControl XL */ + { USB_DEVICE(0x1235, 0x0061), .driver_info = USB_QUIRK_RESET_RESUME }, + { } /* terminating entry must be last */ }; ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: Usb midi device does not work on wake 2020-01-29 15:47 ` Richard Dodd @ 2020-01-30 6:34 ` Greg KH 2020-01-30 16:58 ` Richard Dodd 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2020-01-30 6:34 UTC (permalink / raw) To: Richard Dodd; +Cc: Oliver Neukum, linux-usb On Wed, Jan 29, 2020 at 03:47:29PM +0000, Richard Dodd wrote: > On Mon, Jan 13, 2020 at 9:40 AM Oliver Neukum <oneukum@suse.com> wrote: > > > > Am Sonntag, den 12.01.2020, 12:06 +0000 schrieb Richard Dodd: > > > Hello > > > > > > I've got a Novation midi-over-usb device (LaunchControl XL) that works > > > correctly on boot, but remains in power-off mode when waking from > > > sleep. > > > > > > I suspect that there is some sort of initialisation that needs to be > > > applied. Could anyone suggest possible causes, or point me in the > > > direction of the relevant source code. I found `sound/usb/quirks.c`, > > > which seems to be the place to handle this kind of thing, but there is > > > no mention of my device anywhere in the source tree at present > > > (1235:0061). > > > > Hi, > > > > some devices need an additional reset. They have the quirk RESET_RESUME > > in that file. Try adding your device to that list and recompile your > > kernel. > > > > HTH > > Oliver > > > > Hi > > I found the list you are talking about in `drivers/usb/core/quirks.c`, > and when I patched it, my device correctly woke up after suspend. :) > > Can I upstream the patch by posting it here. The patch is attached to > this email. Can you please resend this in the format described in the documentation so that we can apply it to the tree? thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Usb midi device does not work on wake 2020-01-30 6:34 ` Greg KH @ 2020-01-30 16:58 ` Richard Dodd 2020-01-30 17:33 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Richard Dodd @ 2020-01-30 16:58 UTC (permalink / raw) To: Greg KH; +Cc: Oliver Neukum, linux-usb [-- Attachment #1: Type: text/plain, Size: 1624 bytes --] Hi Greg Hopefully I followed the correct instructions. I have attached the patch. Rich On Thu, Jan 30, 2020 at 6:34 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Jan 29, 2020 at 03:47:29PM +0000, Richard Dodd wrote: > > On Mon, Jan 13, 2020 at 9:40 AM Oliver Neukum <oneukum@suse.com> wrote: > > > > > > Am Sonntag, den 12.01.2020, 12:06 +0000 schrieb Richard Dodd: > > > > Hello > > > > > > > > I've got a Novation midi-over-usb device (LaunchControl XL) that works > > > > correctly on boot, but remains in power-off mode when waking from > > > > sleep. > > > > > > > > I suspect that there is some sort of initialisation that needs to be > > > > applied. Could anyone suggest possible causes, or point me in the > > > > direction of the relevant source code. I found `sound/usb/quirks.c`, > > > > which seems to be the place to handle this kind of thing, but there is > > > > no mention of my device anywhere in the source tree at present > > > > (1235:0061). > > > > > > Hi, > > > > > > some devices need an additional reset. They have the quirk RESET_RESUME > > > in that file. Try adding your device to that list and recompile your > > > kernel. > > > > > > HTH > > > Oliver > > > > > > > Hi > > > > I found the list you are talking about in `drivers/usb/core/quirks.c`, > > and when I patched it, my device correctly woke up after suspend. :) > > > > Can I upstream the patch by posting it here. The patch is attached to > > this email. > > Can you please resend this in the format described in the documentation > so that we can apply it to the tree? > > thanks, > > greg k-h [-- Attachment #2: 0001-USB-Fix-novation-SourceControl-XL-after-suspend.patch --] [-- Type: text/x-patch, Size: 1012 bytes --] From 7d991df69d2c47ac41f4657109cee514eef68728 Mon Sep 17 00:00:00 2001 From: Richard Dodd <richard.o.dodd@gmail.com> Date: Thu, 30 Jan 2020 16:53:51 +0000 Subject: [PATCH] USB: Fix novation SourceControl XL after suspend Currently, the SourceControl will stay in power-down mode after resuming from suspend. This patch resets the device after suspend to power it up. Signed-off-by: Richard Dodd <richard.o.dodd@gmail.com> --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 6b6413073584..3db6c05aaa4b 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -445,6 +445,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /* novation SoundControl XL */ + { USB_DEVICE(0x1235, 0x0061), .driver_info = USB_QUIRK_RESET_RESUME }, + { } /* terminating entry must be last */ }; -- 2.25.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: Usb midi device does not work on wake 2020-01-30 16:58 ` Richard Dodd @ 2020-01-30 17:33 ` Greg KH [not found] ` <CAAWug1d7u1bGhkyYRbEk1g4a3oMPgxCrppeTPtjLT-uuHhf83g@mail.gmail.com> 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2020-01-30 17:33 UTC (permalink / raw) To: Richard Dodd; +Cc: Oliver Neukum, linux-usb On Thu, Jan 30, 2020 at 04:58:46PM +0000, Richard Dodd wrote: > Hi Greg > > Hopefully I followed the correct instructions. I have attached the patch. Attachments do not work, just send it as-is. Look at lots of examples on this mailing list for how to do that. that being said, it does look good so far... thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAAWug1d7u1bGhkyYRbEk1g4a3oMPgxCrppeTPtjLT-uuHhf83g@mail.gmail.com>]
* Re: Usb midi device does not work on wake [not found] ` <CAAWug1d7u1bGhkyYRbEk1g4a3oMPgxCrppeTPtjLT-uuHhf83g@mail.gmail.com> @ 2020-01-31 21:40 ` Greg KH 2020-02-12 14:22 ` [PATCH] USB: Fix novation SourceControl XL after suspend richard.o.dodd 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2020-01-31 21:40 UTC (permalink / raw) To: Richard Dodd; +Cc: Oliver Neukum, linux-usb On Fri, Jan 31, 2020 at 05:24:27PM +0000, Richard Dodd wrote: > >From 7d991df69d2c47ac41f4657109cee514eef68728 Mon Sep 17 00:00:00 2001 > From: Richard Dodd <richard.o.dodd@gmail.com> > Date: Thu, 30 Jan 2020 16:53:51 +0000 > Subject: [PATCH] USB: Fix novation SourceControl XL after suspend > > Currently, the SourceControl will stay in power-down mode after resuming > from suspend. This patch resets the device after suspend to power it up. > > Signed-off-by: Richard Dodd <richard.o.dodd@gmail.com> > --- > drivers/usb/core/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index 6b6413073584..3db6c05aaa4b 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -445,6 +445,9 @@ static const struct usb_device_id usb_quirk_list[] = { > /* INTEL VALUE SSD */ > { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, > > + /* novation SoundControl XL */ > + { USB_DEVICE(0x1235, 0x0061), .driver_info = USB_QUIRK_RESET_RESUME }, > + > { } /* terminating entry must be last */ > }; > Whitespace is all corrupted, tabs are turned into spaces :( Can you just use git send-email? Don't use a web email client, they do not work. thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] USB: Fix novation SourceControl XL after suspend 2020-01-31 21:40 ` Greg KH @ 2020-02-12 14:22 ` richard.o.dodd 0 siblings, 0 replies; 8+ messages in thread From: richard.o.dodd @ 2020-02-12 14:22 UTC (permalink / raw) Cc: gregkh, oneukum, linux-usb, Richard Dodd, Marco Zatta, Maximilian Luz, linux-kernel From: Richard Dodd <richard.o.dodd@gmail.com> Currently, the SourceControl will stay in power-down mode after resuming from suspend. This patch resets the device after suspend to power it up. Signed-off-by: Richard Dodd <richard.o.dodd@gmail.com> --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 6b6413073584..3db6c05aaa4b 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -445,6 +445,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /* novation SoundControl XL */ + { USB_DEVICE(0x1235, 0x0061), .driver_info = USB_QUIRK_RESET_RESUME }, + { } /* terminating entry must be last */ }; -- 2.25.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-02-12 14:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-12 12:06 Usb midi device does not work on wake Richard Dodd
2020-01-13 9:23 ` Oliver Neukum
2020-01-29 15:47 ` Richard Dodd
2020-01-30 6:34 ` Greg KH
2020-01-30 16:58 ` Richard Dodd
2020-01-30 17:33 ` Greg KH
[not found] ` <CAAWug1d7u1bGhkyYRbEk1g4a3oMPgxCrppeTPtjLT-uuHhf83g@mail.gmail.com>
2020-01-31 21:40 ` Greg KH
2020-02-12 14:22 ` [PATCH] USB: Fix novation SourceControl XL after suspend richard.o.dodd
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).