From: Linus Walleij <linus.walleij@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb <linux-usb@vger.kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Stefan Agner <stefan@agner.ch>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] usb: usb3503: Convert to use GPIO descriptors
Date: Fri, 6 Dec 2019 14:21:19 +0100 [thread overview]
Message-ID: <CACRpkdYABrazSkSn0Qn-dCguxhgJUiQ2viDRMw4VAggafmZrQQ@mail.gmail.com> (raw)
In-Reply-To: <cc924d9c-d8b2-d14e-f758-556551557e5d@samsung.com>
On Fri, Dec 6, 2019 at 12:53 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> On 06.12.2019 10:58, Linus Walleij wrote:
> > On Fri, Dec 6, 2019 at 10:14 AM Marek Szyprowski
> > <m.szyprowski@samsung.com> wrote:
> >
> > BTW:
> >
> >> I really wonder why
> >> it worked fine with non-descriptor code and the ACTIVE_LOW DT flags...
> > The old code ignored the polarity flags in the device tree and
> > assumed everything was active high, that's how. It could as well
> > be hardcoded to 1337.
>
> Okay, then to restore current driver behavior after your patch, one has
> to change gpio flags in all dts to ACTIVE_HIGH...
Yeah :/
I think we should do a two-stage rocket here, if you make a patch to
all the DTS files I will make sure to add some logic enforcing the
right line levels in this patch as well.
I'll make sure to assert reset expecting it to be flagged as active low.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-12-06 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191205145641eucas1p1e3f40dff8a0c8e9ca47425e2370eabbb@eucas1p1.samsung.com>
2019-12-05 14:56 ` [PATCH] usb: usb3503: Convert to use GPIO descriptors Linus Walleij
2019-12-06 7:55 ` Marek Szyprowski
2019-12-06 9:14 ` Marek Szyprowski
2019-12-06 9:56 ` Linus Walleij
2019-12-06 11:42 ` Marek Szyprowski
2019-12-06 13:43 ` Linus Walleij
2019-12-09 16:33 ` Marek Szyprowski
2019-12-10 23:13 ` Linus Walleij
2019-12-11 8:48 ` Marek Szyprowski
2019-12-06 9:58 ` Linus Walleij
2019-12-06 11:52 ` Marek Szyprowski
2019-12-06 13:21 ` Linus Walleij [this message]
2019-12-06 13:33 ` Marek Szyprowski
2019-12-06 13:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYABrazSkSn0Qn-dCguxhgJUiQ2viDRMw4VAggafmZrQQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).