From: Linus Walleij <linus.walleij@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb <linux-usb@vger.kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Stefan Agner <stefan@agner.ch>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] usb: usb3503: Convert to use GPIO descriptors
Date: Wed, 11 Dec 2019 00:13:58 +0100 [thread overview]
Message-ID: <CACRpkdbPpxY2s8fqNuoYcrQUY1TJXmy__qbJ6nbw4XYrqtNHNQ@mail.gmail.com> (raw)
In-Reply-To: <bb1432d3-1fee-9c3d-0ae1-af305deed636@samsung.com>
On Mon, Dec 9, 2019 at 5:33 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> On 06.12.2019 14:43, Linus Walleij wrote:
> > On Fri, Dec 6, 2019 at 12:43 PM Marek Szyprowski
> > <m.szyprowski@samsung.com> wrote:
> >
> >> arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts: invert RESET
> >> gpio polarity (to ACTIVE_LOW), not sure about INTN gpio
> > AFAICT INTN should be set to ACTIVE_HIGH if it is working with the
> > current code in the kernel.
> >
> > However it is pretty confusing with the "N" at the end of INTN,
> > indicating negative polarity. Maybe it means something else,
> > I haven't checked the datasheet. Maybe all boards have inverters
> > on these lines so they come out active high.
>
> Well, this line is indeed active low. The datasheet names it 'int_n'.
> However I think it makes sense to keep it as ACTIVE_HIGH, because the
> 'n' is already in the gpio name (and dt binding). In contrary, the reset
> gpio pin/binding is named without the 'n', thus I want to clarify it as
> active low. The datasheet names it 'reset_n'.
Agreed.
> If you are okay with this approach, I will send a patchset fixing
> polarity in DTS together with your patch converting the driver to gpio
> descriptors with the fixup for the reset gpio polarity.
Yes this approach should work, will you fold in fixes to my
patch (like asserting reset high) as well or do you want me
to send a v2?
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-12-10 23:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191205145641eucas1p1e3f40dff8a0c8e9ca47425e2370eabbb@eucas1p1.samsung.com>
2019-12-05 14:56 ` [PATCH] usb: usb3503: Convert to use GPIO descriptors Linus Walleij
2019-12-06 7:55 ` Marek Szyprowski
2019-12-06 9:14 ` Marek Szyprowski
2019-12-06 9:56 ` Linus Walleij
2019-12-06 11:42 ` Marek Szyprowski
2019-12-06 13:43 ` Linus Walleij
2019-12-09 16:33 ` Marek Szyprowski
2019-12-10 23:13 ` Linus Walleij [this message]
2019-12-11 8:48 ` Marek Szyprowski
2019-12-06 9:58 ` Linus Walleij
2019-12-06 11:52 ` Marek Szyprowski
2019-12-06 13:21 ` Linus Walleij
2019-12-06 13:33 ` Marek Szyprowski
2019-12-06 13:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbPpxY2s8fqNuoYcrQUY1TJXmy__qbJ6nbw4XYrqtNHNQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).