* [RESEND 00/25] Rid W=1 warnings from HID
@ 2021-03-26 14:34 Lee Jones
2021-03-26 14:34 ` Lee Jones
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Lee Jones @ 2021-03-26 14:34 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <vojtech@ucw.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Zhang Lixu <lixu.zhang@intel.com>
--
2.27.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [RESEND 00/25] Rid W=1 warnings from HID
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
@ 2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34 ` [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Lee Jones
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-03-26 14:34 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
[RESEND] contains no functional changes. Only 18 of 25 patches
actually made it to the list during the first attempt.
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <vojtech@ucw.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Zhang Lixu <lixu.zhang@intel.com>
--
2.27.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-03-26 14:34 ` Lee Jones
@ 2021-03-26 14:34 ` Lee Jones
2021-04-07 16:56 ` Benjamin Tissoires
2021-03-26 14:34 ` [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Lee Jones
2021-04-06 8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
3 siblings, 1 reply; 11+ messages in thread
From: Lee Jones @ 2021-03-26 14:34 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, message to,
linux-usb, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: message to <vojtech@ucw.cz>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/usbhid/usbkbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index d5b7a696a68c5..d0c640be8a885 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = {
* new key is pressed or a key that was pressed is released.
* @led: URB for sending LEDs (e.g. numlock, ...)
* @newleds: data that will be sent with the @led URB representing which LEDs
- should be on
+ * should be on
* @name: Name of the keyboard. @dev's name field points to this buffer
* @phys: Physical path of the keyboard. @dev's phys field points to this
* buffer
--
2.27.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description
2021-03-26 14:34 ` [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Lee Jones
@ 2021-04-07 16:56 ` Benjamin Tissoires
2021-04-08 7:05 ` Lee Jones
0 siblings, 1 reply; 11+ messages in thread
From: Benjamin Tissoires @ 2021-04-07 16:56 UTC (permalink / raw)
To: Lee Jones
Cc: lkml, Jiri Kosina, message to, Linux USB Mailing List,
open list:HID CORE LAYER
On Fri, Mar 26, 2021 at 3:35 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on
>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: message to <vojtech@ucw.cz>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/hid/usbhid/usbkbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
> index d5b7a696a68c5..d0c640be8a885 100644
> --- a/drivers/hid/usbhid/usbkbd.c
> +++ b/drivers/hid/usbhid/usbkbd.c
> @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = {
> * new key is pressed or a key that was pressed is released.
> * @led: URB for sending LEDs (e.g. numlock, ...)
> * @newleds: data that will be sent with the @led URB representing which LEDs
> - should be on
> + * should be on
nitpick: checkpatch complains about spaces before tabs here.
I amended locally and will push the fixed version.
Cheers,
Benjamin
> * @name: Name of the keyboard. @dev's name field points to this buffer
> * @phys: Physical path of the keyboard. @dev's phys field points to this
> * buffer
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description
2021-04-07 16:56 ` Benjamin Tissoires
@ 2021-04-08 7:05 ` Lee Jones
0 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-04-08 7:05 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: lkml, Jiri Kosina, message to, Linux USB Mailing List,
open list:HID CORE LAYER
On Wed, 07 Apr 2021, Benjamin Tissoires wrote:
> On Fri, Mar 26, 2021 at 3:35 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on
> >
> > Cc: Jiri Kosina <jikos@kernel.org>
> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > Cc: message to <vojtech@ucw.cz>
> > Cc: linux-usb@vger.kernel.org
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/hid/usbhid/usbkbd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
> > index d5b7a696a68c5..d0c640be8a885 100644
> > --- a/drivers/hid/usbhid/usbkbd.c
> > +++ b/drivers/hid/usbhid/usbkbd.c
> > @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = {
> > * new key is pressed or a key that was pressed is released.
> > * @led: URB for sending LEDs (e.g. numlock, ...)
> > * @newleds: data that will be sent with the @led URB representing which LEDs
> > - should be on
> > + * should be on
>
> nitpick: checkpatch complains about spaces before tabs here.
>
> I amended locally and will push the fixed version.
Those are usually highlighted in my editor.
I wonder how I missed them.
Thanks for cleaning it up though.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34 ` [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Lee Jones
@ 2021-03-26 14:34 ` Lee Jones
2021-04-06 8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
3 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-03-26 14:34 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Anssi Hannula,
linux-usb, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'dev' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'effect_id' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'value' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: expecting prototype for value times(). Prototype was for pidff_playback() instead
drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'pidff' not described in 'pidff_find_effects'
drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'dev' not described in 'pidff_find_effects'
drivers/hid/usbhid/hid-pidff.c:1005: warning: expecting prototype for Find the implemented effect types(). Prototype was for pidff_find_effects() instead
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/usbhid/hid-pidff.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index fddac7c72f645..ea126c50acc3b 100644
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c
@@ -505,7 +505,7 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n)
HID_REQ_SET_REPORT);
}
-/**
+/*
* Play the effect with effect id @effect_id for @value times
*/
static int pidff_playback(struct input_dev *dev, int effect_id, int value)
@@ -997,7 +997,7 @@ static int pidff_find_special_fields(struct pidff_device *pidff)
return 0;
}
-/**
+/*
* Find the implemented effect types
*/
static int pidff_find_effects(struct pidff_device *pidff,
--
2.27.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [RESEND 00/25] Rid W=1 warnings from HID
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
` (2 preceding siblings ...)
2021-03-26 14:34 ` [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Lee Jones
@ 2021-04-06 8:56 ` Lee Jones
2021-04-07 16:09 ` Benjamin Tissoires
3 siblings, 1 reply; 11+ messages in thread
From: Lee Jones @ 2021-04-06 8:56 UTC (permalink / raw)
To: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
On Fri, 26 Mar 2021, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> header
> HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
These have been on the list for a couple of weeks now.
Is there anything I can do to help expedite their merge?
I'm concerned since -rc6 has just been released.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RESEND 00/25] Rid W=1 warnings from HID
2021-04-06 8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
@ 2021-04-07 16:09 ` Benjamin Tissoires
2021-04-08 7:06 ` Lee Jones
0 siblings, 1 reply; 11+ messages in thread
From: Benjamin Tissoires @ 2021-04-07 16:09 UTC (permalink / raw)
To: Lee Jones
Cc: lkml, Alexandre Torgue, Anssi Hannula, Bruno Prémont,
Christian König, Daniel Drubin, Dario Pagani, dri-devel,
Henrik Rydberg, Jiri Kosina, Jonathan Cameron, Kai-Heng Feng,
Kim Kuparinen, Krzysztof Wilczyński, linaro-mm-sig,
Linux ARM, linux-iio, open list:HID CORE LAYER, linux-media,
linux-stm32, Linux USB Mailing List, Lopez Casado, L. Vinyard,
Jr, Masaki Ota, Maxime Coquelin, message to, Michael Haboustak,
Rushikesh S Kadam, Srinivas Pandruvada, Sumit Semwal,
Uwe Kleine-König, Vojtech Pavlik, Zhang Lixu
On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 26 Mar 2021, Lee Jones wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (25):
> > HID: intel-ish-hid: Remove unused variable 'err'
> > HID: ishtp-hid-client: Move variable to where it's actually used
> > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> > HID: intel-ish: Supply some missing param descriptions
> > HID: intel-ish: Fix a naming disparity and a formatting error
> > HID: usbhid: Repair a formatting issue in a struct description
> > HID: intel-ish-hid: Fix a little doc-rot
> > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> > HID: hid-alps: Correct struct misnaming
> > HID: intel-ish-hid: Fix potential copy/paste error
> > HID: hid-core: Fix incorrect function name in header
> > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> > header
> > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> > HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> > HID: hid-picolcd_core: Remove unused variable 'ret'
> > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> > abuses
> > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> > HID: hid-uclogic-params: Ensure function names are present and correct
> > in kernel-doc headers
> > HID: hid-sensor-custom: Remove unused variable 'ret'
> > HID: wacom_sys: Demote kernel-doc abuse
> > HID: hid-sensor-hub: Remove unused struct member 'quirks'
> > HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> > definition
> > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
>
> These have been on the list for a couple of weeks now.
>
> Is there anything I can do to help expedite their merge?
>
> I'm concerned since -rc6 has just been released.
Sorry for the delay.
I am currently queuing them locally and running a few tests on them. I
don't expect anything to happen, but better be safe than anything.
FWIW, I am splitting the series in 3:
- 11 patches for intel ish are going to be queued in for-5.13/intel-ish
- the thrustmaster one in for-5.13/thrustmaster
- the rest (13 patches) will be sent in for-5.13/warnings.
Cheers,
Benjamin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RESEND 00/25] Rid W=1 warnings from HID
2021-04-07 16:09 ` Benjamin Tissoires
@ 2021-04-08 7:06 ` Lee Jones
2021-04-08 11:43 ` Benjamin Tissoires
0 siblings, 1 reply; 11+ messages in thread
From: Lee Jones @ 2021-04-08 7:06 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: lkml, Alexandre Torgue, Anssi Hannula, Bruno Prémont,
Christian König, Daniel Drubin, Dario Pagani, dri-devel,
Henrik Rydberg, Jiri Kosina, Jonathan Cameron, Kai-Heng Feng,
Kim Kuparinen, Krzysztof Wilczyński, linaro-mm-sig,
Linux ARM, linux-iio, open list:HID CORE LAYER, linux-media,
linux-stm32, Linux USB Mailing List, Lopez Casado, L. Vinyard,
Jr, Masaki Ota, Maxime Coquelin, message to, Michael Haboustak,
Rushikesh S Kadam, Srinivas Pandruvada, Sumit Semwal,
Uwe Kleine-König, Vojtech Pavlik, Zhang Lixu
On Wed, 07 Apr 2021, Benjamin Tissoires wrote:
> On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Fri, 26 Mar 2021, Lee Jones wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > Lee Jones (25):
> > > HID: intel-ish-hid: Remove unused variable 'err'
> > > HID: ishtp-hid-client: Move variable to where it's actually used
> > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> > > HID: intel-ish: Supply some missing param descriptions
> > > HID: intel-ish: Fix a naming disparity and a formatting error
> > > HID: usbhid: Repair a formatting issue in a struct description
> > > HID: intel-ish-hid: Fix a little doc-rot
> > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> > > HID: hid-alps: Correct struct misnaming
> > > HID: intel-ish-hid: Fix potential copy/paste error
> > > HID: hid-core: Fix incorrect function name in header
> > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> > > header
> > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> > > HID: hid-picolcd_core: Remove unused variable 'ret'
> > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> > > abuses
> > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> > > HID: hid-uclogic-params: Ensure function names are present and correct
> > > in kernel-doc headers
> > > HID: hid-sensor-custom: Remove unused variable 'ret'
> > > HID: wacom_sys: Demote kernel-doc abuse
> > > HID: hid-sensor-hub: Remove unused struct member 'quirks'
> > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> > > definition
> > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
> >
> > These have been on the list for a couple of weeks now.
> >
> > Is there anything I can do to help expedite their merge?
> >
> > I'm concerned since -rc6 has just been released.
>
> Sorry for the delay.
>
> I am currently queuing them locally and running a few tests on them. I
> don't expect anything to happen, but better be safe than anything.
>
> FWIW, I am splitting the series in 3:
> - 11 patches for intel ish are going to be queued in for-5.13/intel-ish
> - the thrustmaster one in for-5.13/thrustmaster
> - the rest (13 patches) will be sent in for-5.13/warnings.
Sounds good to me. Thanks Benjamin.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RESEND 00/25] Rid W=1 warnings from HID
2021-04-08 7:06 ` Lee Jones
@ 2021-04-08 11:43 ` Benjamin Tissoires
0 siblings, 0 replies; 11+ messages in thread
From: Benjamin Tissoires @ 2021-04-08 11:43 UTC (permalink / raw)
To: Lee Jones
Cc: lkml, Alexandre Torgue, Anssi Hannula, Bruno Prémont,
Christian König, Daniel Drubin, Dario Pagani, dri-devel,
Henrik Rydberg, Jiri Kosina, Jonathan Cameron, Kai-Heng Feng,
Kim Kuparinen, Krzysztof Wilczyński, linaro-mm-sig,
Linux ARM, linux-iio, open list:HID CORE LAYER, linux-media,
linux-stm32, Linux USB Mailing List, Lopez Casado, L. Vinyard,
Jr, Masaki Ota, Maxime Coquelin, message to, Michael Haboustak,
Rushikesh S Kadam, Srinivas Pandruvada, Sumit Semwal,
Uwe Kleine-König, Vojtech Pavlik, Zhang Lixu
On Thu, Apr 8, 2021 at 9:06 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Wed, 07 Apr 2021, Benjamin Tissoires wrote:
>
> > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Fri, 26 Mar 2021, Lee Jones wrote:
> > >
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > >
> > > > Lee Jones (25):
> > > > HID: intel-ish-hid: Remove unused variable 'err'
> > > > HID: ishtp-hid-client: Move variable to where it's actually used
> > > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> > > > HID: intel-ish: Supply some missing param descriptions
> > > > HID: intel-ish: Fix a naming disparity and a formatting error
> > > > HID: usbhid: Repair a formatting issue in a struct description
> > > > HID: intel-ish-hid: Fix a little doc-rot
> > > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> > > > HID: hid-alps: Correct struct misnaming
> > > > HID: intel-ish-hid: Fix potential copy/paste error
> > > > HID: hid-core: Fix incorrect function name in header
> > > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> > > > header
> > > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> > > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> > > > HID: hid-picolcd_core: Remove unused variable 'ret'
> > > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> > > > abuses
> > > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> > > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> > > > HID: hid-uclogic-params: Ensure function names are present and correct
> > > > in kernel-doc headers
> > > > HID: hid-sensor-custom: Remove unused variable 'ret'
> > > > HID: wacom_sys: Demote kernel-doc abuse
> > > > HID: hid-sensor-hub: Remove unused struct member 'quirks'
> > > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> > > > definition
> > > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> > > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
> > >
> > > These have been on the list for a couple of weeks now.
> > >
> > > Is there anything I can do to help expedite their merge?
> > >
> > > I'm concerned since -rc6 has just been released.
> >
> > Sorry for the delay.
> >
> > I am currently queuing them locally and running a few tests on them. I
> > don't expect anything to happen, but better be safe than anything.
> >
> > FWIW, I am splitting the series in 3:
> > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish
> > - the thrustmaster one in for-5.13/thrustmaster
> > - the rest (13 patches) will be sent in for-5.13/warnings.
>
> Sounds good to me. Thanks Benjamin.
>
After a few attempts at fixing my CI, I have now pushed this series as
mentioned previously.
Cheers,
Benjamin
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-24 17:33 Lee Jones
2021-03-24 17:33 ` [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Lee Jones
0 siblings, 1 reply; 11+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <vojtech@ucw.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Zhang Lixu <lixu.zhang@intel.com>
--
2.27.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description
2021-03-24 17:33 [PATCH " Lee Jones
@ 2021-03-24 17:33 ` Lee Jones
0 siblings, 0 replies; 11+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, message to,
linux-usb, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: message to <vojtech@ucw.cz>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/usbhid/usbkbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index d5b7a696a68c5..d0c640be8a885 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = {
* new key is pressed or a key that was pressed is released.
* @led: URB for sending LEDs (e.g. numlock, ...)
* @newleds: data that will be sent with the @led URB representing which LEDs
- should be on
+ * should be on
* @name: Name of the keyboard. @dev's name field points to this buffer
* @phys: Physical path of the keyboard. @dev's phys field points to this
* buffer
--
2.27.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-04-08 11:44 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34 ` [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Lee Jones
2021-04-07 16:56 ` Benjamin Tissoires
2021-04-08 7:05 ` Lee Jones
2021-03-26 14:34 ` [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Lee Jones
2021-04-06 8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-04-07 16:09 ` Benjamin Tissoires
2021-04-08 7:06 ` Lee Jones
2021-04-08 11:43 ` Benjamin Tissoires
-- strict thread matches above, loose matches on Subject: below --
2021-03-24 17:33 [PATCH " Lee Jones
2021-03-24 17:33 ` [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).