From: Badhri Jagan Sridharan <badhri@google.com>
To: Rob Herring <robh@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
USB <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v2 6/6] Documentation: connector: Add slow-charger-loop definition
Date: Tue, 13 Apr 2021 18:27:31 -0700 [thread overview]
Message-ID: <CAPTae5+fxxpzNCNb-eo_7gR6-Pvnr0aFq58dfPmucB2eh7ibjg@mail.gmail.com> (raw)
In-Reply-To: <20210409183803.GA3928012@robh.at.kernel.org>
Hi Rob,
Have clarified "slow charger loops" and pSnkStby in my V3 of the patch
and have updated the subject as well.
I was actually doing a git log where the last one showed up with the
following commit description.
commit 4b59b60d896f3ed94921974e916db091bc3a9ba8
Author: Kyle Tso <kyletso@google.com>
Date: Fri Feb 12 15:37:43 2021 +0800
Documentation: connector: Update the description of sink-vdos
Remove the acronym "VDM" and replace it with the full name "Vendor
Defined Message".
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Kyle Tso <kyletso@google.com>
Link: https://lore.kernel.org/r/20210212073743.665038-1-kyletso@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks,
Badhri
On Fri, Apr 9, 2021 at 11:38 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Apr 07, 2021 at 01:07:23PM -0700, Badhri Jagan Sridharan wrote:
> > To allow slow charger loops to comply to pSnkStby requirement,
> > this patch introduces slow-charger-loop which when set makes
> > the port request PD_P_SNK_STDBY_MW upon entering SNK_DISCOVERY
> > (instead of 3A or the 1.5A during SNK_DISCOVERY) and the actual
> > currrent limit after RX of PD_CTRL_PSRDY for PD link or during
> > SNK_READY for non-pd link.
>
> What are 'slow charger loops' and pSnkStby?
>
> 'dt-bindings: connector: ...' for the subject. Follow the pattern you
> see with 'git log --oneline' for a directory.
>
> >
> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> > ---
> > .../devicetree/bindings/connector/usb-connector.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > index b6daedd62516..09ad3ad983a6 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > @@ -197,6 +197,13 @@ properties:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [1, 2, 3]
> >
> > + slow-charger-loop:
> > + description: Allows slow charging loops to comply to pSnkStby. When set makes
> > + the port request pSnkStby(2.5W - 5V@500mA) upon entering SNK_DISCOVERY(instead
> > + of 3A or the 1.5A during SNK_DISCOVERY) and the actual currrent limit after
> > + reception of PS_Ready for PD link or during SNK_READY for non-pd link.
> > + type: boolean
> > +
> > required:
> > - compatible
> >
> > --
> > 2.31.1.295.g9ea45b61b8-goog
> >
next prev parent reply other threads:[~2021-04-14 1:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 20:07 [PATCH v2 1/6] usb: typec: tcpm: Address incorrect values of tcpm psy for fixed supply Badhri Jagan Sridharan
2021-04-07 20:07 ` [PATCH v2 2/6] usb: typec: tcpm: Address incorrect values of tcpm psy for pps supply Badhri Jagan Sridharan
2021-04-08 6:59 ` Heikki Krogerus
2021-04-10 2:10 ` Guenter Roeck
2021-04-07 20:07 ` [PATCH v2 3/6] usb: typec: tcpm: update power supply once partner accepts Badhri Jagan Sridharan
2021-04-08 7:09 ` Heikki Krogerus
2021-04-10 2:10 ` Guenter Roeck
2021-04-07 20:07 ` [PATCH v2 4/6] usb: typec: tcpm: Honour pSnkStdby requirement during negotiation Badhri Jagan Sridharan
2021-04-08 7:47 ` Heikki Krogerus
2021-04-14 0:58 ` Badhri Jagan Sridharan
2021-04-10 2:11 ` Guenter Roeck
2021-04-07 20:07 ` [PATCH v2 5/6] usb: typec: tcpm: Allow slow charging loops to comply to pSnkStby Badhri Jagan Sridharan
2021-04-08 8:14 ` Heikki Krogerus
2021-04-08 8:22 ` Heikki Krogerus
2021-04-14 0:59 ` Badhri Jagan Sridharan
2021-04-07 20:07 ` [PATCH v2 6/6] Documentation: connector: Add slow-charger-loop definition Badhri Jagan Sridharan
2021-04-09 18:38 ` Rob Herring
2021-04-14 1:27 ` Badhri Jagan Sridharan [this message]
2021-04-08 6:51 ` [PATCH v2 1/6] usb: typec: tcpm: Address incorrect values of tcpm psy for fixed supply Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTae5+fxxpzNCNb-eo_7gR6-Pvnr0aFq58dfPmucB2eh7ibjg@mail.gmail.com \
--to=badhri@google.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).