From: Badhri Jagan Sridharan <badhri@google.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
USB <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v2 5/6] usb: typec: tcpm: Allow slow charging loops to comply to pSnkStby
Date: Tue, 13 Apr 2021 17:59:52 -0700 [thread overview]
Message-ID: <CAPTae5J2K_=VaL2mQOZxBgaSEGDavW=Rm8XNNDM4n=JPgqbjaw@mail.gmail.com> (raw)
In-Reply-To: <YG69UKTSgyHQHeFd@kuha.fi.intel.com>
On Thu, Apr 8, 2021 at 1:22 AM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> > > @@ -4047,9 +4053,12 @@ static void run_state_machine(struct tcpm_port *port)
> > > break;
> > > case SNK_DISCOVERY:
> > > if (port->vbus_present) {
> > > - tcpm_set_current_limit(port,
> > > - tcpm_get_current_limit(port),
> > > - 5000);
> > > + u32 current_lim = (!port->slow_charger_loop ||
> > > + (tcpm_get_current_limit(port) <=
> > > + PD_P_SNK_STDBY_MW / 5)) ?
> > > + tcpm_get_current_limit(port) :
> > > + PD_P_SNK_STDBY_MW / 5;
> >
> > Here the use of the ternary operator is not appropriate. Please try to
> > clean that up somehow. Maybe something like this would be better?
> >
> > u32 current_lim = tcpm_get_current_limit(port);
> >
> > if (port->slow_charger_loop || (current_lim < PD_P_SNK_STDBY_MW / 5))
> > current_lim = PD_P_SNK_STDBY_MW / 5;
>
> Sorry, I mean:
>
> if (port->slow_charger_loop || (current_lim > PD_P_SNK_STDBY_MW / 5))
> current_lim = PD_P_SNK_STDBY_MW / 5;
Ack. Updating in my next version: V3.
Thanks,
Badhri
>
> thanks,
>
> --
> heikki
next prev parent reply other threads:[~2021-04-14 1:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 20:07 [PATCH v2 1/6] usb: typec: tcpm: Address incorrect values of tcpm psy for fixed supply Badhri Jagan Sridharan
2021-04-07 20:07 ` [PATCH v2 2/6] usb: typec: tcpm: Address incorrect values of tcpm psy for pps supply Badhri Jagan Sridharan
2021-04-08 6:59 ` Heikki Krogerus
2021-04-10 2:10 ` Guenter Roeck
2021-04-07 20:07 ` [PATCH v2 3/6] usb: typec: tcpm: update power supply once partner accepts Badhri Jagan Sridharan
2021-04-08 7:09 ` Heikki Krogerus
2021-04-10 2:10 ` Guenter Roeck
2021-04-07 20:07 ` [PATCH v2 4/6] usb: typec: tcpm: Honour pSnkStdby requirement during negotiation Badhri Jagan Sridharan
2021-04-08 7:47 ` Heikki Krogerus
2021-04-14 0:58 ` Badhri Jagan Sridharan
2021-04-10 2:11 ` Guenter Roeck
2021-04-07 20:07 ` [PATCH v2 5/6] usb: typec: tcpm: Allow slow charging loops to comply to pSnkStby Badhri Jagan Sridharan
2021-04-08 8:14 ` Heikki Krogerus
2021-04-08 8:22 ` Heikki Krogerus
2021-04-14 0:59 ` Badhri Jagan Sridharan [this message]
2021-04-07 20:07 ` [PATCH v2 6/6] Documentation: connector: Add slow-charger-loop definition Badhri Jagan Sridharan
2021-04-09 18:38 ` Rob Herring
2021-04-14 1:27 ` Badhri Jagan Sridharan
2021-04-08 6:51 ` [PATCH v2 1/6] usb: typec: tcpm: Address incorrect values of tcpm psy for fixed supply Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTae5J2K_=VaL2mQOZxBgaSEGDavW=Rm8XNNDM4n=JPgqbjaw@mail.gmail.com' \
--to=badhri@google.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).