* [PATCH v2] usb: typec: tcpci: mask event interrupts when remove driver
@ 2020-01-20 5:55 Jun Li
2020-01-20 6:06 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Jun Li @ 2020-01-20 5:55 UTC (permalink / raw)
To: linux, heikki.krogerus; +Cc: gregkh, linux-usb, dl-linux-imx
This is to prevent any possible events generated while unregister
tpcm port.
Fixes: 74e656d6b0551 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
Signed-off-by: Li Jun <jun.li@nxp.com>
---
drivers/usb/typec/tcpm/tcpci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
index c1f7073..fb9f2c1 100644
--- a/drivers/usb/typec/tcpm/tcpci.c
+++ b/drivers/usb/typec/tcpm/tcpci.c
@@ -581,6 +581,12 @@ static int tcpci_probe(struct i2c_client *client,
static int tcpci_remove(struct i2c_client *client)
{
struct tcpci_chip *chip = i2c_get_clientdata(client);
+ int err;
+
+ /* Disable chip interrupts before unregistger port */
+ err = tcpci_write16(chip->tcpci, TCPC_ALERT_MASK, 0);
+ if (err < 0)
+ return err;
tcpci_unregister_port(chip->tcpci);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: typec: tcpci: mask event interrupts when remove driver
2020-01-20 5:55 [PATCH v2] usb: typec: tcpci: mask event interrupts when remove driver Jun Li
@ 2020-01-20 6:06 ` Guenter Roeck
2020-01-20 6:42 ` Jun Li
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2020-01-20 6:06 UTC (permalink / raw)
To: Jun Li, heikki.krogerus; +Cc: gregkh, linux-usb, dl-linux-imx
On 1/19/20 9:55 PM, Jun Li wrote:
> This is to prevent any possible events generated while unregister
> tpcm port.
>
> Fixes: 74e656d6b0551 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
> drivers/usb/typec/tcpm/tcpci.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
> index c1f7073..fb9f2c1 100644
> --- a/drivers/usb/typec/tcpm/tcpci.c
> +++ b/drivers/usb/typec/tcpm/tcpci.c
> @@ -581,6 +581,12 @@ static int tcpci_probe(struct i2c_client *client,
> static int tcpci_remove(struct i2c_client *client)
> {
> struct tcpci_chip *chip = i2c_get_clientdata(client);
> + int err;
> +
> + /* Disable chip interrupts before unregistger port */
s/unregistger/unregistering/
Sorry, I should have noticed before.
> + err = tcpci_write16(chip->tcpci, TCPC_ALERT_MASK, 0);
> + if (err < 0)
> + return err;
>
> tcpci_unregister_port(chip->tcpci);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] usb: typec: tcpci: mask event interrupts when remove driver
2020-01-20 6:06 ` Guenter Roeck
@ 2020-01-20 6:42 ` Jun Li
0 siblings, 0 replies; 3+ messages in thread
From: Jun Li @ 2020-01-20 6:42 UTC (permalink / raw)
To: Guenter Roeck, heikki.krogerus; +Cc: gregkh, linux-usb, dl-linux-imx
Hi Guenter
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: 2020年1月20日 14:06
> To: Jun Li <jun.li@nxp.com>; heikki.krogerus@linux.intel.com
> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: Re: [PATCH v2] usb: typec: tcpci: mask event interrupts when remove
> driver
>
> On 1/19/20 9:55 PM, Jun Li wrote:
> > This is to prevent any possible events generated while unregister tpcm
> > port.
> >
> > Fixes: 74e656d6b0551 ("staging: typec: Type-C Port Controller
> > Interface driver (tcpci)")
> > Signed-off-by: Li Jun <jun.li@nxp.com>
> > ---
> > drivers/usb/typec/tcpm/tcpci.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/usb/typec/tcpm/tcpci.c
> > b/drivers/usb/typec/tcpm/tcpci.c index c1f7073..fb9f2c1 100644
> > --- a/drivers/usb/typec/tcpm/tcpci.c
> > +++ b/drivers/usb/typec/tcpm/tcpci.c
> > @@ -581,6 +581,12 @@ static int tcpci_probe(struct i2c_client *client,
> > static int tcpci_remove(struct i2c_client *client)
> > {
> > struct tcpci_chip *chip = i2c_get_clientdata(client);
> > + int err;
> > +
> > + /* Disable chip interrupts before unregistger port */
>
> s/unregistger/unregistering/
>
> Sorry, I should have noticed before.
thanks, I will send v3, I thought checkpatch.pl will check spell errors in patch but
seems it only covers commit log.
Li Jun
>
> > + err = tcpci_write16(chip->tcpci, TCPC_ALERT_MASK, 0);
> > + if (err < 0)
> > + return err;
> >
> > tcpci_unregister_port(chip->tcpci);
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-20 6:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20 5:55 [PATCH v2] usb: typec: tcpci: mask event interrupts when remove driver Jun Li
2020-01-20 6:06 ` Guenter Roeck
2020-01-20 6:42 ` Jun Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).