From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: taehyun cho <taehyun.cho@samsung.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent
Date: Mon, 8 Feb 2021 12:57:07 +0100 [thread overview]
Message-ID: <YCEnE4/Pf8P/CCID@kroah.com> (raw)
In-Reply-To: <20210208114538.134766-1-taehyun.cho@samsung.com>
On Mon, Feb 08, 2021 at 08:45:38PM +0900, taehyun cho wrote:
> 'ARCH_EXYNOS' is no more used.
I do not understand this sentance. I see it used in many places in the
kernel tree still, is it being removed?
And if so, as of what commit is this true?
> 'USB_DWC3_EXYNOS' is glue layer
> which can be used with Synopsys DWC3 controller on Exynos SoCs.
> 'USB_DWC3_EXYNOS' can be used from Exynos5 to Exynos9.
This is fine, but the help text doesn't show this, why not put that
information there?
>
> Signed-off-by: taehyun cho <taehyun.cho@samsung.com>
> ---
> drivers/usb/dwc3/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 2133acf8ee69..dc2f92ac8ef6 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -67,10 +67,10 @@ config USB_DWC3_OMAP
>
> config USB_DWC3_EXYNOS
> tristate "Samsung Exynos Platform"
> - depends on (ARCH_EXYNOS || COMPILE_TEST) && OF
> + depends on (USB_DWC3 || COMPILE_TEST) && OF
> default USB_DWC3
> help
> - Recent Exynos5 SoCs ship with one DesignWare Core USB3 IP inside,
> + Exynos SoCs chip with one DesignWare Core USB3 IP inside,
This does not make much sense anymore, can you reword it?
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-08 11:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <taehyun cho>
[not found] ` <CGME20210208112816epcas2p43777bb9740f7307e38cb534f01099126@epcas2p4.samsung.com>
2021-02-08 11:29 ` [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent taehyun cho
2021-02-08 11:39 ` Greg Kroah-Hartman
[not found] ` <CGME20210208114447epcas2p3507f22a555355ac7710c5ca220853e0e@epcas2p3.samsung.com>
2021-02-08 11:45 ` taehyun cho
2021-02-08 11:57 ` Greg Kroah-Hartman [this message]
2021-02-08 13:05 ` Krzysztof Kozlowski
[not found] <CGME20210303022537epcas2p1b85ab825ceca3a411a177cc1af8a2c7b@epcas2p1.samsung.com>
2021-03-03 2:26 ` taehyun cho
2021-03-03 10:24 ` Krzysztof Kozlowski
2021-03-03 10:30 ` Greg Kroah-Hartman
2021-03-03 10:38 ` Krzysztof Kozlowski
2021-03-03 11:01 ` Krzysztof Kozlowski
2021-03-03 12:54 ` Arnd Bergmann
2021-03-03 14:05 ` Greg Kroah-Hartman
2021-03-03 14:56 ` Guenter Roeck
2021-03-03 15:09 ` Greg Kroah-Hartman
2021-03-03 15:46 ` Krzysztof Kozlowski
2021-03-03 16:33 ` Arnd Bergmann
2021-03-03 16:43 ` Greg Kroah-Hartman
2021-03-03 16:49 ` Krzysztof Kozlowski
2021-03-03 16:50 ` Krzysztof Kozlowski
2021-03-03 16:56 ` Greg Kroah-Hartman
2021-03-03 19:40 ` Arnd Bergmann
2021-03-03 15:44 ` Krzysztof Kozlowski
2021-03-03 17:51 ` Arnd Bergmann
2021-03-03 13:12 ` taehyun cho
2021-03-03 13:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCEnE4/Pf8P/CCID@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=taehyun.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).