From: Krzysztof Kozlowski <krzk@kernel.org>
To: taehyun cho <taehyun.cho@samsung.com>, balbi@kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent
Date: Wed, 3 Mar 2021 11:24:01 +0100 [thread overview]
Message-ID: <c9ac155c-56c2-4025-d1ae-d0c6c95533b8@kernel.org> (raw)
In-Reply-To: <20210303022628.6540-1-taehyun.cho@samsung.com>
On 03/03/2021 03:26, taehyun cho wrote:
> 'ARCH_EXYNOS' is not suitable for DWC3_EXYNOS config.
> 'USB_DWC3_EXYNOS' is glue layer which can be used with
> Synopsys DWC3 controller on Exynos SoCs. USB_DWC3_EXYNOS'
> can be used from Exynos5 to Exynos9.
>
> Signed-off-by: taehyun cho <taehyun.cho@samsung.com>
NACK because you ignored comments from March. Please respond to them
instead of resending the same patch.
Anyway, when resending you need to version your patches and explain the
differences. Please also Cc reviewers and other maintainers. I pointed
out this before:
scripts/get_maintainer.pl -f drivers/usb/dwc3/dwc3-exynos.c
The driver - in current form - should not be available for other
architectures. It would clutter other platforms and kernel config
selection. If you want to change this, you need to provide rationale
(usually by adding support to new non-Exynos platform).
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-03-03 10:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210303022537epcas2p1b85ab825ceca3a411a177cc1af8a2c7b@epcas2p1.samsung.com>
2021-03-03 2:26 ` [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent taehyun cho
2021-03-03 10:24 ` Krzysztof Kozlowski [this message]
2021-03-03 10:30 ` Greg Kroah-Hartman
2021-03-03 10:38 ` Krzysztof Kozlowski
2021-03-03 11:01 ` Krzysztof Kozlowski
2021-03-03 12:54 ` Arnd Bergmann
2021-03-03 14:05 ` Greg Kroah-Hartman
2021-03-03 14:56 ` Guenter Roeck
2021-03-03 15:09 ` Greg Kroah-Hartman
2021-03-03 15:46 ` Krzysztof Kozlowski
2021-03-03 16:33 ` Arnd Bergmann
2021-03-03 16:43 ` Greg Kroah-Hartman
2021-03-03 16:49 ` Krzysztof Kozlowski
2021-03-03 16:50 ` Krzysztof Kozlowski
2021-03-03 16:56 ` Greg Kroah-Hartman
2021-03-03 19:40 ` Arnd Bergmann
2021-03-03 15:44 ` Krzysztof Kozlowski
2021-03-03 17:51 ` Arnd Bergmann
2021-03-03 13:12 ` taehyun cho
2021-03-03 13:15 ` Krzysztof Kozlowski
[not found] <taehyun cho>
[not found] ` <CGME20210208112816epcas2p43777bb9740f7307e38cb534f01099126@epcas2p4.samsung.com>
2021-02-08 11:29 ` taehyun cho
2021-02-08 11:39 ` Greg Kroah-Hartman
[not found] ` <CGME20210208114447epcas2p3507f22a555355ac7710c5ca220853e0e@epcas2p3.samsung.com>
2021-02-08 11:45 ` taehyun cho
2021-02-08 11:57 ` Greg Kroah-Hartman
2021-02-08 13:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9ac155c-56c2-4025-d1ae-d0c6c95533b8@kernel.org \
--to=krzk@kernel.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=taehyun.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).