* [PATCH] usb: ohci-s3c2410: Use platform_get_irq() to get the interrupt
@ 2021-12-15 22:53 Rob Herring
2021-12-16 7:38 ` Krzysztof Kozlowski
2021-12-16 16:10 ` Alan Stern
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-15 22:53 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, Krzysztof Kozlowski
Cc: Lad Prabhakar, linux-usb, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Accessing platform device resources directly has long been deprecated for
DT as IRQ resources may not be available at device creation time. Drivers
relying on the static IRQ resources is blocking removing the static setup
from the DT core code.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/usb/host/ohci-s3c2410.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb/host/ohci-s3c2410.c
index 1bec9b585e2d..12264c048601 100644
--- a/drivers/usb/host/ohci-s3c2410.c
+++ b/drivers/usb/host/ohci-s3c2410.c
@@ -356,7 +356,7 @@ static int ohci_hcd_s3c2410_probe(struct platform_device *dev)
{
struct usb_hcd *hcd = NULL;
struct s3c2410_hcd_info *info = dev_get_platdata(&dev->dev);
- int retval;
+ int retval, irq;
s3c2410_usb_set_power(info, 1, 1);
s3c2410_usb_set_power(info, 2, 1);
@@ -388,9 +388,15 @@ static int ohci_hcd_s3c2410_probe(struct platform_device *dev)
goto err_put;
}
+ irq = platform_get_irq(dev, 0);
+ if (irq < 0) {
+ retval = irq;
+ goto err_put;
+ }
+
s3c2410_start_hc(dev, hcd);
- retval = usb_add_hcd(hcd, dev->resource[1].start, 0);
+ retval = usb_add_hcd(hcd, irq, 0);
if (retval != 0)
goto err_ioremap;
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: ohci-s3c2410: Use platform_get_irq() to get the interrupt
2021-12-15 22:53 [PATCH] usb: ohci-s3c2410: Use platform_get_irq() to get the interrupt Rob Herring
@ 2021-12-16 7:38 ` Krzysztof Kozlowski
2021-12-16 16:10 ` Alan Stern
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-16 7:38 UTC (permalink / raw)
To: Rob Herring, Alan Stern, Greg Kroah-Hartman
Cc: Lad Prabhakar, linux-usb, linux-arm-kernel, linux-samsung-soc,
linux-kernel
On 15/12/2021 23:53, Rob Herring wrote:
> Accessing platform device resources directly has long been deprecated for
> DT as IRQ resources may not be available at device creation time. Drivers
> relying on the static IRQ resources is blocking removing the static setup
> from the DT core code.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/usb/host/ohci-s3c2410.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: ohci-s3c2410: Use platform_get_irq() to get the interrupt
2021-12-15 22:53 [PATCH] usb: ohci-s3c2410: Use platform_get_irq() to get the interrupt Rob Herring
2021-12-16 7:38 ` Krzysztof Kozlowski
@ 2021-12-16 16:10 ` Alan Stern
1 sibling, 0 replies; 3+ messages in thread
From: Alan Stern @ 2021-12-16 16:10 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Krzysztof Kozlowski, Lad Prabhakar,
linux-usb, linux-arm-kernel, linux-samsung-soc, linux-kernel
On Wed, Dec 15, 2021 at 04:53:57PM -0600, Rob Herring wrote:
> Accessing platform device resources directly has long been deprecated for
> DT as IRQ resources may not be available at device creation time. Drivers
> relying on the static IRQ resources is blocking removing the static setup
> from the DT core code.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/ohci-s3c2410.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb/host/ohci-s3c2410.c
> index 1bec9b585e2d..12264c048601 100644
> --- a/drivers/usb/host/ohci-s3c2410.c
> +++ b/drivers/usb/host/ohci-s3c2410.c
> @@ -356,7 +356,7 @@ static int ohci_hcd_s3c2410_probe(struct platform_device *dev)
> {
> struct usb_hcd *hcd = NULL;
> struct s3c2410_hcd_info *info = dev_get_platdata(&dev->dev);
> - int retval;
> + int retval, irq;
>
> s3c2410_usb_set_power(info, 1, 1);
> s3c2410_usb_set_power(info, 2, 1);
> @@ -388,9 +388,15 @@ static int ohci_hcd_s3c2410_probe(struct platform_device *dev)
> goto err_put;
> }
>
> + irq = platform_get_irq(dev, 0);
> + if (irq < 0) {
> + retval = irq;
> + goto err_put;
> + }
> +
> s3c2410_start_hc(dev, hcd);
>
> - retval = usb_add_hcd(hcd, dev->resource[1].start, 0);
> + retval = usb_add_hcd(hcd, irq, 0);
> if (retval != 0)
> goto err_ioremap;
>
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-16 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 22:53 [PATCH] usb: ohci-s3c2410: Use platform_get_irq() to get the interrupt Rob Herring
2021-12-16 7:38 ` Krzysztof Kozlowski
2021-12-16 16:10 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).