Re: [PATCH 2/2] extcon: usbc-tusb320: Add USB TYPE-C support

[Peter Rosin <peda@axentia.se>]

Hi!

2022-11-13 at 19:48, Marek Vasut wrote:
> On 11/13/22 17:59, Peter Rosin wrote:
>> On Sat, Jul 30, 2022 at 08:05:00PM +0200, Marek Vasut wrote:
>>> The TI TUSB320 seems like a better fit for USB TYPE-C subsystem,
>>> which can expose details collected by the TUSB320 in a far more
>>> precise way than extcon. Since there are existing users in the
>>> kernel and in DT which depend on the extcon interface, keep it
>>> for now.
>>>
>>> Add TYPE-C interface and expose the supported supply current,
>>> direction and connector polarity via the TYPE-C interface.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>
>> Hi!
>>
>> I'm very sad to report that this patch has caused a severe
>> regression for our devices. They can no longer be powered by simply
>> sticking a USB cable into their USB ports (they keep resetting
>> when the tusb320 driver probes), and they reset (and keep resetting)
>> if a USB cable is connected while the device is powered by other
>> means.
>>
>> We have no connector node nor any typec-power-opmode property
>> in the device tree, so the mere touching of the new registers
>> happening in this patch is enough to cause the resets.
>>
>> The devices were fine before this patch, and reverting on top
>> of a recent linus master (4bbf3422df78, from 11/11) makes the
>> problem go away.
>>
>> Any suggestions?
> 
> Can you test:
> 
> 341fd15e2e18c ("extcon: usbc-tusb320: Call the Type-C IRQ handler only if a port is registered")
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-linus&id=341fd15e2e18c24d5c738496cfc3d7a272241201
> 
> ?

Yup, that solves it. Thanks!

Cheers,
Peter