* [PATCH] watchdog: cadence: Skip printing pointer value
@ 2019-12-20 6:58 Srinivas Neeli
2019-12-20 18:52 ` Guenter Roeck
2020-01-04 16:34 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Srinivas Neeli @ 2019-12-20 6:58 UTC (permalink / raw)
To: linux, shubhraj, sgoud, michal.simek
Cc: wim, linux-watchdog, linux-kernel, git, Srinivas Neeli
"%p" is not printing the pointer value.
In driver, printing pointer value is not useful so avoiding print.
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
---
drivers/watchdog/cadence_wdt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
index 06bd4e1a5923..672b184da875 100644
--- a/drivers/watchdog/cadence_wdt.c
+++ b/drivers/watchdog/cadence_wdt.c
@@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev)
return ret;
platform_set_drvdata(pdev, wdt);
- dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
- wdt->regs, cdns_wdt_device->timeout,
- nowayout ? ", nowayout" : "");
+ dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n",
+ cdns_wdt_device->timeout, nowayout ? ", nowayout" : "");
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: cadence: Skip printing pointer value
2019-12-20 6:58 [PATCH] watchdog: cadence: Skip printing pointer value Srinivas Neeli
@ 2019-12-20 18:52 ` Guenter Roeck
2020-01-04 16:34 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-12-20 18:52 UTC (permalink / raw)
To: Srinivas Neeli
Cc: shubhraj, sgoud, michal.simek, wim, linux-watchdog, linux-kernel, git
On Fri, Dec 20, 2019 at 12:28:16PM +0530, Srinivas Neeli wrote:
> "%p" is not printing the pointer value.
> In driver, printing pointer value is not useful so avoiding print.
>
> Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/cadence_wdt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 06bd4e1a5923..672b184da875 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev)
> return ret;
> platform_set_drvdata(pdev, wdt);
>
> - dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> - wdt->regs, cdns_wdt_device->timeout,
> - nowayout ? ", nowayout" : "");
> + dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n",
> + cdns_wdt_device->timeout, nowayout ? ", nowayout" : "");
>
> return 0;
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: cadence: Skip printing pointer value
2019-12-20 6:58 [PATCH] watchdog: cadence: Skip printing pointer value Srinivas Neeli
2019-12-20 18:52 ` Guenter Roeck
@ 2020-01-04 16:34 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2020-01-04 16:34 UTC (permalink / raw)
To: Srinivas Neeli, shubhraj, sgoud, michal.simek
Cc: wim, linux-watchdog, linux-kernel, git
On 12/19/19 10:58 PM, Srinivas Neeli wrote:
> "%p" is not printing the pointer value.
> In driver, printing pointer value is not useful so avoiding print.
>
> Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/cadence_wdt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 06bd4e1a5923..672b184da875 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev)
> return ret;
> platform_set_drvdata(pdev, wdt);
>
> - dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> - wdt->regs, cdns_wdt_device->timeout,
> - nowayout ? ", nowayout" : "");
> + dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n",
> + cdns_wdt_device->timeout, nowayout ? ", nowayout" : "");
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-04 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-20 6:58 [PATCH] watchdog: cadence: Skip printing pointer value Srinivas Neeli
2019-12-20 18:52 ` Guenter Roeck
2020-01-04 16:34 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).