From: <sean.wang@mediatek.com>
To: <sam.shih@mediatek.com>
Cc: <robh+dt@kernel.org>, <sean.wang@kernel.org>,
<linus.walleij@linaro.org>, <matthias.bgg@gmail.com>,
<mpm@selenic.com>, <herbert@gondor.apana.org.au>,
<gregkh@linuxfoundation.org>, <wim@linux-watchdog.org>,
<linux@roeck-us.net>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <hsinyi@chromium.org>,
<enric.balletbo@collabora.com>, <fparent@baylibre.com>,
<seiya.wang@mediatek.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-crypto@vger.kernel.org>, <linux-serial@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<john@phrozen.org>, <Ryder.Lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>
Subject: Re: [v2, 04/12] pinctrl: mediatek: moore: check if pin_desc is valid before use
Date: Fri, 20 Aug 2021 15:01:13 +0800 [thread overview]
Message-ID: <1629442873-24655-1-git-send-email-sean.wang@mediatek.com> (raw)
In-Reply-To: <20210817074557.30953-5-sam.shih@mediatek.com--annotate>
From: Sean Wang <sean.wang@mediatek.com>
>Certain SoC are missing the middle part gpios in consecutive pins, it's better to check if mtk_pin_desc is a valid pin for the extensibility
>
>Signed-off-by: Sam Shih <sam.shih@mediatek.com>
>
>---
>v2: applied the comment suggested by reviewers:
> - for the pins not ballout, we can fill .name in struct mtk_pin_desc
> as NULL and return -ENOTSUPP in gpio/pinconf ops.
Thanks for take the suggestion and the improvement.
Acked-by: Sean Wang <sean.wang@mediatek.com>
>
>---
> drivers/pinctrl/mediatek/pinctrl-moore.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
>diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.c b/drivers/pinctrl/mediatek/pinctrl-moore.c
>index 3a4a23c40a71..ad3b67163973 100644
>--- a/drivers/pinctrl/mediatek/pinctrl-moore.c
>+++ b/drivers/pinctrl/mediatek/pinctrl-moore.c
>@@ -60,6 +60,8 @@ static int mtk_pinmux_set_mux(struct pinctrl_dev *pctldev,
> int pin = grp->pins[i];
>
> desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin];
>+ if (!desc->name)
>+ return -ENOTSUPP;
>
> mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_MODE,
> pin_modes[i]);
>@@ -76,6 +78,8 @@ static int mtk_pinmux_gpio_request_enable(struct pinctrl_dev *pctldev,
> const struct mtk_pin_desc *desc;
>
> desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin];
>+ if (!desc->name)
>+ return -ENOTSUPP;
<snip>
next parent reply other threads:[~2021-08-20 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210817074557.30953-5-sam.shih@mediatek.com--annotate>
2021-08-20 7:01 ` sean.wang [this message]
2021-08-20 7:50 ` [v2,06/12] pinctrl: mediatek: add support for MT7986 SoC sean.wang
2021-08-17 7:45 [v2,00/12] Add basic SoC support for mediatek mt7986 Sam Shih
2021-08-17 7:45 ` [v2,04/12] pinctrl: mediatek: moore: check if pin_desc is valid before use Sam Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629442873-24655-1-git-send-email-sean.wang@mediatek.com \
--to=sean.wang@mediatek.com \
--cc=Ryder.Lee@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=fparent@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=hsinyi@chromium.org \
--cc=john@phrozen.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=mpm@selenic.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sam.shih@mediatek.com \
--cc=sboyd@kernel.org \
--cc=sean.wang@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).