* Re: [PATCH] watchdog: mt7621: Fix compiler error, missing include
[not found] <20190114211719.11461-1-opensource@vdorst.com>
@ 2019-01-15 15:16 ` Matthias Brugger
2019-01-15 15:29 ` René van Dorst
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Brugger @ 2019-01-15 15:16 UTC (permalink / raw)
To: René van Dorst, linux-watchdog, linux-mediatek
On 14/01/2019 22:17, René van Dorst wrote:
> drivers/watchdog/mt7621_wdt.c:174:34: error: array type has incomplete element type 'struct of_device_id'
> static const struct of_device_id mt7621_wdt_match[] = {
> ^~~~~~~~~~~~~~~~
> drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in record or union initializer
> { .compatible = "mediatek,mt7621-wdt" },
> ^
> drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for 'mt7621_wdt_match')
> drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match' defined but not used [-Wunused-variable]
> static const struct of_device_id mt7621_wdt_match[] = {
> ^~~~~~~~~~~~~~~~
>
Did this work in the past?
I suppose so. Could you provide a fixes tag for stable.
Thanks,
Matthias
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> ---
> drivers/watchdog/mt7621_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
> index 5c4a764717c4..a3be7db9d76f 100644
> --- a/drivers/watchdog/mt7621_wdt.c
> +++ b/drivers/watchdog/mt7621_wdt.c
> @@ -16,6 +16,7 @@
> #include <linux/kernel.h>
> #include <linux/watchdog.h>
> #include <linux/moduleparam.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
>
> #include <asm/mach-ralink/ralink_regs.h>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: mt7621: Fix compiler error, missing include
2019-01-15 15:16 ` [PATCH] watchdog: mt7621: Fix compiler error, missing include Matthias Brugger
@ 2019-01-15 15:29 ` René van Dorst
0 siblings, 0 replies; 2+ messages in thread
From: René van Dorst @ 2019-01-15 15:29 UTC (permalink / raw)
To: Matthias Brugger; +Cc: linux-watchdog, linux-mediatek
Quoting Matthias Brugger <matthias.bgg@gmail.com>:
> On 14/01/2019 22:17, René van Dorst wrote:
>> drivers/watchdog/mt7621_wdt.c:174:34: error: array type has
>> incomplete element type 'struct of_device_id'
>> static const struct of_device_id mt7621_wdt_match[] = {
>> ^~~~~~~~~~~~~~~~
>> drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in
>> record or union initializer
>> { .compatible = "mediatek,mt7621-wdt" },
>> ^
>> drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for
>> 'mt7621_wdt_match')
>> drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match'
>> defined but not used [-Wunused-variable]
>> static const struct of_device_id mt7621_wdt_match[] = {
>> ^~~~~~~~~~~~~~~~
>>
>
> Did this work in the past?
> I suppose so. Could you provide a fixes tag for stable.
I see that I am not the first who spotted this.
https://patchwork.kernel.org/patch/10745049/
So better drop this one.
Greats,
René
> Thanks,
> Matthias
>
>> Signed-off-by: René van Dorst <opensource@vdorst.com>
>> ---
>> drivers/watchdog/mt7621_wdt.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
>> index 5c4a764717c4..a3be7db9d76f 100644
>> --- a/drivers/watchdog/mt7621_wdt.c
>> +++ b/drivers/watchdog/mt7621_wdt.c
>> @@ -16,6 +16,7 @@
>> #include <linux/kernel.h>
>> #include <linux/watchdog.h>
>> #include <linux/moduleparam.h>
>> +#include <linux/of.h>
>> #include <linux/platform_device.h>
>>
>> #include <asm/mach-ralink/ralink_regs.h>
>>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-15 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190114211719.11461-1-opensource@vdorst.com>
2019-01-15 15:16 ` [PATCH] watchdog: mt7621: Fix compiler error, missing include Matthias Brugger
2019-01-15 15:29 ` René van Dorst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).