* [PATCH] drivers: watchdog: Kconfig: pedantic cleanups
@ 2019-03-06 15:15 Enrico Weigelt, metux IT consult
2019-03-06 16:15 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-06 15:15 UTC (permalink / raw)
To: linux-kernel; +Cc: wim, linux, linux-watchdog
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/watchdog/Kconfig | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 57f017d..38509d5 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG
select MFD_SYSCON
select WATCHDOG_CORE
help
- Say Y here to include support for the watchdog timer found on
- Marvell Armada 37xx SoCs.
- To compile this driver as a module, choose M here: the
- module will be called armada_37xx_wdt.
+ Say Y here to include support for the watchdog timer found on
+ Marvell Armada 37xx SoCs.
+ To compile this driver as a module, choose M here: the
+ module will be called armada_37xx_wdt.
config ASM9260_WATCHDOG
tristate "Alphascale ASM9260 watchdog"
@@ -606,10 +606,10 @@ config MAX77620_WATCHDOG
tristate "Maxim Max77620 Watchdog Timer"
depends on MFD_MAX77620 || COMPILE_TEST
help
- This is the driver for the Max77620 watchdog timer.
- Say 'Y' here to enable the watchdog timer support for
- MAX77620 chips. To compile this driver as a module,
- choose M here: the module will be called max77620_wdt.
+ This is the driver for the Max77620 watchdog timer.
+ Say 'Y' here to enable the watchdog timer support for
+ MAX77620 chips. To compile this driver as a module,
+ choose M here: the module will be called max77620_wdt.
config IMX2_WDT
tristate "IMX2+ Watchdog"
@@ -1632,10 +1632,10 @@ config BCM7038_WDT
depends on HAS_IOMEM
depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
help
- Watchdog driver for the built-in hardware in Broadcom 7038 and
- later SoCs used in set-top boxes. BCM7038 was made public
- during the 2004 CES, and since then, many Broadcom chips use this
- watchdog block, including some cable modem chips.
+ Watchdog driver for the built-in hardware in Broadcom 7038 and
+ later SoCs used in set-top boxes. BCM7038 was made public
+ during the 2004 CES, and since then, many Broadcom chips use this
+ watchdog block, including some cable modem chips.
config IMGPDC_WDT
tristate "Imagination Technologies PDC Watchdog Timer"
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: watchdog: Kconfig: pedantic cleanups
2019-03-06 15:15 [PATCH] drivers: watchdog: Kconfig: pedantic cleanups Enrico Weigelt, metux IT consult
@ 2019-03-06 16:15 ` Guenter Roeck
2019-03-06 21:48 ` Enrico Weigelt, metux IT consult
2019-03-06 21:52 ` [PATCH v2] drivers: watchdog: Kconfig: pedantic formatting Enrico Weigelt, metux IT consult
0 siblings, 2 replies; 5+ messages in thread
From: Guenter Roeck @ 2019-03-06 16:15 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult, linux-kernel; +Cc: wim, linux-watchdog
On 3/6/19 7:15 AM, Enrico Weigelt, metux IT consult wrote:
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Checkpatch says:
WARNING: Missing commit description - Add an appropriate one
There needs to be some kind of description of those pedantic cleanups.
On top of that, while the affected Kconfig file generates 42 checkpatch
warnings, this patch doesn't fix a single one of them. I don't really
see the point of this patch.
Thanks,
Guenter
> ---
> drivers/watchdog/Kconfig | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 57f017d..38509d5 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG
> select MFD_SYSCON
> select WATCHDOG_CORE
> help
> - Say Y here to include support for the watchdog timer found on
> - Marvell Armada 37xx SoCs.
> - To compile this driver as a module, choose M here: the
> - module will be called armada_37xx_wdt.
> + Say Y here to include support for the watchdog timer found on
> + Marvell Armada 37xx SoCs.
> + To compile this driver as a module, choose M here: the
> + module will be called armada_37xx_wdt.
>
> config ASM9260_WATCHDOG
> tristate "Alphascale ASM9260 watchdog"
> @@ -606,10 +606,10 @@ config MAX77620_WATCHDOG
> tristate "Maxim Max77620 Watchdog Timer"
> depends on MFD_MAX77620 || COMPILE_TEST
> help
> - This is the driver for the Max77620 watchdog timer.
> - Say 'Y' here to enable the watchdog timer support for
> - MAX77620 chips. To compile this driver as a module,
> - choose M here: the module will be called max77620_wdt.
> + This is the driver for the Max77620 watchdog timer.
> + Say 'Y' here to enable the watchdog timer support for
> + MAX77620 chips. To compile this driver as a module,
> + choose M here: the module will be called max77620_wdt.
>
> config IMX2_WDT
> tristate "IMX2+ Watchdog"
> @@ -1632,10 +1632,10 @@ config BCM7038_WDT
> depends on HAS_IOMEM
> depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> help
> - Watchdog driver for the built-in hardware in Broadcom 7038 and
> - later SoCs used in set-top boxes. BCM7038 was made public
> - during the 2004 CES, and since then, many Broadcom chips use this
> - watchdog block, including some cable modem chips.
> + Watchdog driver for the built-in hardware in Broadcom 7038 and
> + later SoCs used in set-top boxes. BCM7038 was made public
> + during the 2004 CES, and since then, many Broadcom chips use this
> + watchdog block, including some cable modem chips.
>
> config IMGPDC_WDT
> tristate "Imagination Technologies PDC Watchdog Timer"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: watchdog: Kconfig: pedantic cleanups
2019-03-06 16:15 ` Guenter Roeck
@ 2019-03-06 21:48 ` Enrico Weigelt, metux IT consult
2019-03-06 21:52 ` [PATCH v2] drivers: watchdog: Kconfig: pedantic formatting Enrico Weigelt, metux IT consult
1 sibling, 0 replies; 5+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-06 21:48 UTC (permalink / raw)
To: Guenter Roeck, Enrico Weigelt, metux IT consult, linux-kernel
Cc: wim, linux-watchdog
On 06.03.19 17:15, Guenter Roeck wrote:
> On top of that, while the affected Kconfig file generates 42 checkpatch
> warnings, this patch doesn't fix a single one of them. I don't really
> see the point of this patch.
Well, it's just about making the identions more consistent, nothing
else. I admin, I didn't run checkpatch.pl on that.
I'll rework it.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drivers: watchdog: Kconfig: pedantic formatting
2019-03-06 16:15 ` Guenter Roeck
2019-03-06 21:48 ` Enrico Weigelt, metux IT consult
@ 2019-03-06 21:52 ` Enrico Weigelt, metux IT consult
2019-03-20 13:39 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-06 21:52 UTC (permalink / raw)
To: linux-kernel; +Cc: wim, linux, linux-watchdog
Formatting of Kconfig files doesn't look so pretty, so just
take damp cloth and clean it up.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/watchdog/Kconfig | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 57f017d..38509d5 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG
select MFD_SYSCON
select WATCHDOG_CORE
help
- Say Y here to include support for the watchdog timer found on
- Marvell Armada 37xx SoCs.
- To compile this driver as a module, choose M here: the
- module will be called armada_37xx_wdt.
+ Say Y here to include support for the watchdog timer found on
+ Marvell Armada 37xx SoCs.
+ To compile this driver as a module, choose M here: the
+ module will be called armada_37xx_wdt.
config ASM9260_WATCHDOG
tristate "Alphascale ASM9260 watchdog"
@@ -606,10 +606,10 @@ config MAX77620_WATCHDOG
tristate "Maxim Max77620 Watchdog Timer"
depends on MFD_MAX77620 || COMPILE_TEST
help
- This is the driver for the Max77620 watchdog timer.
- Say 'Y' here to enable the watchdog timer support for
- MAX77620 chips. To compile this driver as a module,
- choose M here: the module will be called max77620_wdt.
+ This is the driver for the Max77620 watchdog timer.
+ Say 'Y' here to enable the watchdog timer support for
+ MAX77620 chips. To compile this driver as a module,
+ choose M here: the module will be called max77620_wdt.
config IMX2_WDT
tristate "IMX2+ Watchdog"
@@ -1632,10 +1632,10 @@ config BCM7038_WDT
depends on HAS_IOMEM
depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
help
- Watchdog driver for the built-in hardware in Broadcom 7038 and
- later SoCs used in set-top boxes. BCM7038 was made public
- during the 2004 CES, and since then, many Broadcom chips use this
- watchdog block, including some cable modem chips.
+ Watchdog driver for the built-in hardware in Broadcom 7038 and
+ later SoCs used in set-top boxes. BCM7038 was made public
+ during the 2004 CES, and since then, many Broadcom chips use this
+ watchdog block, including some cable modem chips.
config IMGPDC_WDT
tristate "Imagination Technologies PDC Watchdog Timer"
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drivers: watchdog: Kconfig: pedantic formatting
2019-03-06 21:52 ` [PATCH v2] drivers: watchdog: Kconfig: pedantic formatting Enrico Weigelt, metux IT consult
@ 2019-03-20 13:39 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2019-03-20 13:39 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult; +Cc: linux-kernel, wim, linux-watchdog
On Wed, Mar 06, 2019 at 10:52:05PM +0100, Enrico Weigelt, metux IT consult wrote:
> Formatting of Kconfig files doesn't look so pretty, so just
> take damp cloth and clean it up.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Having said that, I would really discourage this kind of cleanup,
and I was quite close to NACKing it. It doesn't fix a single checkpatch
issue in the affected Kconfig file, and that file currently reports 42
checkpatch warnings. Those would be more important issues to fix than
vertical help text alignments.
I won't apply this patch to my branch, and will leave it up to Wim to decide
what to do with it.
Guenter
> ---
> drivers/watchdog/Kconfig | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 57f017d..38509d5 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG
> select MFD_SYSCON
> select WATCHDOG_CORE
> help
> - Say Y here to include support for the watchdog timer found on
> - Marvell Armada 37xx SoCs.
> - To compile this driver as a module, choose M here: the
> - module will be called armada_37xx_wdt.
> + Say Y here to include support for the watchdog timer found on
> + Marvell Armada 37xx SoCs.
> + To compile this driver as a module, choose M here: the
> + module will be called armada_37xx_wdt.
>
> config ASM9260_WATCHDOG
> tristate "Alphascale ASM9260 watchdog"
> @@ -606,10 +606,10 @@ config MAX77620_WATCHDOG
> tristate "Maxim Max77620 Watchdog Timer"
> depends on MFD_MAX77620 || COMPILE_TEST
> help
> - This is the driver for the Max77620 watchdog timer.
> - Say 'Y' here to enable the watchdog timer support for
> - MAX77620 chips. To compile this driver as a module,
> - choose M here: the module will be called max77620_wdt.
> + This is the driver for the Max77620 watchdog timer.
> + Say 'Y' here to enable the watchdog timer support for
> + MAX77620 chips. To compile this driver as a module,
> + choose M here: the module will be called max77620_wdt.
>
> config IMX2_WDT
> tristate "IMX2+ Watchdog"
> @@ -1632,10 +1632,10 @@ config BCM7038_WDT
> depends on HAS_IOMEM
> depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> help
> - Watchdog driver for the built-in hardware in Broadcom 7038 and
> - later SoCs used in set-top boxes. BCM7038 was made public
> - during the 2004 CES, and since then, many Broadcom chips use this
> - watchdog block, including some cable modem chips.
> + Watchdog driver for the built-in hardware in Broadcom 7038 and
> + later SoCs used in set-top boxes. BCM7038 was made public
> + during the 2004 CES, and since then, many Broadcom chips use this
> + watchdog block, including some cable modem chips.
>
> config IMGPDC_WDT
> tristate "Imagination Technologies PDC Watchdog Timer"
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-20 13:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-06 15:15 [PATCH] drivers: watchdog: Kconfig: pedantic cleanups Enrico Weigelt, metux IT consult
2019-03-06 16:15 ` Guenter Roeck
2019-03-06 21:48 ` Enrico Weigelt, metux IT consult
2019-03-06 21:52 ` [PATCH v2] drivers: watchdog: Kconfig: pedantic formatting Enrico Weigelt, metux IT consult
2019-03-20 13:39 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).