* [PATCH] watchdog: renesas_wdt: drop superfluous glob pattern
@ 2019-04-14 10:03 Wolfram Sang
2019-04-14 14:15 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2019-04-14 10:03 UTC (permalink / raw)
To: linux-watchdog; +Cc: linux-renesas-soc, Simon Horman, Wolfram Sang
If we want to match all revisions, it is enough to leave the field
empty.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Only build tested, no HW. Found by code review.
drivers/watchdog/renesas_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
index 94cd8830ba9a..565dbc1ec638 100644
--- a/drivers/watchdog/renesas_wdt.c
+++ b/drivers/watchdog/renesas_wdt.c
@@ -151,7 +151,6 @@ static const struct soc_device_attribute rwdt_quirks_match[] = {
.data = (void *)1, /* needs single CPU */
}, {
.soc_id = "r8a7792",
- .revision = "*",
.data = (void *)0, /* needs SMP disabled */
},
{ /* sentinel */ }
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] watchdog: renesas_wdt: drop superfluous glob pattern
2019-04-14 10:03 [PATCH] watchdog: renesas_wdt: drop superfluous glob pattern Wolfram Sang
@ 2019-04-14 14:15 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2019-04-14 14:15 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-watchdog, linux-renesas-soc, Simon Horman
On Sun, Apr 14, 2019 at 12:03:06PM +0200, Wolfram Sang wrote:
> If we want to match all revisions, it is enough to leave the field
> empty.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Only build tested, no HW. Found by code review.
>
> drivers/watchdog/renesas_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> index 94cd8830ba9a..565dbc1ec638 100644
> --- a/drivers/watchdog/renesas_wdt.c
> +++ b/drivers/watchdog/renesas_wdt.c
> @@ -151,7 +151,6 @@ static const struct soc_device_attribute rwdt_quirks_match[] = {
> .data = (void *)1, /* needs single CPU */
> }, {
> .soc_id = "r8a7792",
> - .revision = "*",
> .data = (void *)0, /* needs SMP disabled */
> },
> { /* sentinel */ }
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-14 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-14 10:03 [PATCH] watchdog: renesas_wdt: drop superfluous glob pattern Wolfram Sang
2019-04-14 14:15 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).