From: Guenter Roeck <linux@roeck-us.net>
To: Maxime Ripard <mripard@kernel.org>
Cc: wim@linux-watchdog.org, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>, Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH RESEND v2 2/6] dt-bindings: watchdog: Convert Allwinner watchdog to a schema
Date: Fri, 30 Aug 2019 09:48:21 -0700 [thread overview]
Message-ID: <20190830164821.GB7911@roeck-us.net> (raw)
In-Reply-To: <20190821143835.7294-2-mripard@kernel.org>
On Wed, Aug 21, 2019 at 04:38:31PM +0200, Maxime Ripard wrote:
> From: Maxime Ripard <maxime.ripard@bootlin.com>
>
> The Allwinner SoCs have a watchdog supported in Linux, with a matching
> Device Tree binding.
>
> Now that we have the DT validation in place, let's convert the device tree
> bindings for that controller over to a YAML schemas.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Changes from v1:
> - Use generic watchdog schema
> - Use unevaluatedProperties instead of additionalProperties
> ---
> .../watchdog/allwinner,sun4i-a10-wdt.yaml | 48 +++++++++++++++++++
> .../bindings/watchdog/sunxi-wdt.txt | 22 ---------
> 2 files changed, 48 insertions(+), 22 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> new file mode 100644
> index 000000000000..dc7553f57708
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/allwinner,sun4i-a10-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner A10 Watchdog Device Tree Bindings
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
> +
> +maintainers:
> + - Chen-Yu Tsai <wens@csie.org>
> + - Maxime Ripard <maxime.ripard@bootlin.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: allwinner,sun4i-a10-wdt
> + - const: allwinner,sun6i-a31-wdt
> + - items:
> + - const: allwinner,sun50i-a64-wdt
> + - const: allwinner,sun6i-a31-wdt
> + - items:
> + - const: allwinner,sun50i-h6-wdt
> + - const: allwinner,sun6i-a31-wdt
> + - items:
> + - const: allwinner,suniv-f1c100s-wdt
> + - const: allwinner,sun4i-a10-wdt
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + wdt: watchdog@1c20c90 {
> + compatible = "allwinner,sun4i-a10-wdt";
> + reg = <0x01c20c90 0x10>;
> + timeout-sec = <10>;
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
> deleted file mode 100644
> index e65198d82a2b..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Allwinner SoCs Watchdog timer
> -
> -Required properties:
> -
> -- compatible : should be one of
> - "allwinner,sun4i-a10-wdt"
> - "allwinner,sun6i-a31-wdt"
> - "allwinner,sun50i-a64-wdt","allwinner,sun6i-a31-wdt"
> - "allwinner,sun50i-h6-wdt","allwinner,sun6i-a31-wdt"
> - "allwinner,suniv-f1c100s-wdt", "allwinner,sun4i-a10-wdt"
> -- reg : Specifies base physical address and size of the registers.
> -
> -Optional properties:
> -- timeout-sec : Contains the watchdog timeout in seconds
> -
> -Example:
> -
> -wdt: watchdog@1c20c90 {
> - compatible = "allwinner,sun4i-a10-wdt";
> - reg = <0x01c20c90 0x10>;
> - timeout-sec = <10>;
> -};
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-08-30 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:38 [PATCH RESEND v2 1/6] dt-bindings: watchdog: Add YAML schemas for the generic watchdog bindings Maxime Ripard
2019-08-21 14:38 ` [PATCH RESEND v2 2/6] dt-bindings: watchdog: Convert Allwinner watchdog to a schema Maxime Ripard
2019-08-30 16:48 ` Guenter Roeck [this message]
2019-08-21 14:38 ` [PATCH RESEND v2 3/6] dt-bindings: watchdog: sun4i: Add the watchdog interrupts Maxime Ripard
2019-08-30 16:48 ` Guenter Roeck
2019-08-21 14:38 ` [PATCH RESEND v2 4/6] dt-bindings: watchdog: sun4i: Add the watchdog clock Maxime Ripard
2019-08-30 16:48 ` Guenter Roeck
2019-08-21 14:38 ` [PATCH RESEND v2 5/6] ARM: dts: sunxi: Add missing watchdog interrupts Maxime Ripard
2019-08-21 14:38 ` [PATCH RESEND v2 6/6] ARM: dts: sunxi: Add missing watchdog clocks Maxime Ripard
2019-08-28 8:18 ` [PATCH RESEND v2 1/6] dt-bindings: watchdog: Add YAML schemas for the generic watchdog bindings Maxime Ripard
2019-08-30 16:48 ` Guenter Roeck
2019-09-02 11:46 ` Maxime Ripard
2019-09-03 0:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830164821.GB7911@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).