From: Rob Herring <robh@kernel.org> To: Michael Walle <michael@walle.cc> Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Linus Walleij" <linus.walleij@linaro.org>, "Bartosz Golaszewski" <bgolaszewski@baylibre.com>, "Jean Delvare" <jdelvare@suse.com>, "Guenter Roeck" <linux@roeck-us.net>, "Lee Jones" <lee.jones@linaro.org>, "Thierry Reding" <thierry.reding@gmail.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Wim Van Sebroeck" <wim@linux-watchdog.org>, "Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Jason Cooper" <jason@lakedaemon.net>, "Marc Zyngier" <maz@kernel.org> Subject: Re: [PATCH 04/18] dt-bindings: mfd: Add bindings for sl28cpld Date: Mon, 30 Mar 2020 16:35:35 -0600 Message-ID: <20200330223535.GA31402@bogus> (raw) In-Reply-To: <20200317205017.28280-5-michael@walle.cc> On Tue, Mar 17, 2020 at 09:50:03PM +0100, Michael Walle wrote: > This adds device tree bindings for the board management controller found > on the Kontron SMARC-sAL28 board. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > .../bindings/mfd/kontron,sl28cpld.yaml | 143 ++++++++++++++++++ > 1 file changed, 143 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > new file mode 100644 > index 000000000000..3b9cca49d2d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > @@ -0,0 +1,143 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/kontron,sl28cpld.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kontron's sl28cpld board management controller > + > +maintainers: > + - Michael Walle <michael@walle.cc> > + > +description: | > + The board management controller may contain different IP blocks like > + watchdog, fan monitoring, PWM controller, interrupt controller and a > + GPIO controller. > + > +properties: > + compatible: > + const: kontron,sl28cpld > + > + reg: > + description: > + I2C device address. > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + "#interrupt-cells": > + const: 2 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > +patternProperties: > + "^gp(io|i|o)(@[0-9]+)?$": Just 'gpio'. We don't need that level of distinguishing in node names. > + $ref: ../gpio/kontron,sl28cpld-gpio.yaml > + > + "^hwmon(@[0-9]+)?$": > + $ref: ../hwmon/kontron,sl28cpld-hwmon.yaml > + > + "^pwm(@[0-9]+)?$": > + $ref: ../pwm/kontron,sl28cpld-pwm.yaml > + > + "^watchdog(@[0-9]+)?$": > + $ref: ../watchdog/kontron,sl28cpld-wdt.yaml The patches for these files need to come first or validating this file fails. Really, you can just make all five files 1 patch. > + > +required: > + - "#address-cells" > + - "#size-cells" > + - compatible > + - reg > + - "#interrupt-cells" > + - interrupt-controller > + > +oneOf: > + - required: > + - interrupts > + - required: > + - interrupts-extended Don't need to do this. Just make 'interrupts' required and you'll get interrupts-extended for free. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sl28cpld@4a { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "kontron,sl28cpld"; > + reg = <0x4a>; > + interrupts-extended = <&gpio2 6 IRQ_TYPE_EDGE_FALLING>; > + > + #interrupt-cells = <2>; > + interrupt-controller; > + > + gpio@0 { > + compatible = "kontron,sl28cpld-gpio"; > + reg = <0>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpio@1 { > + compatible = "kontron,sl28cpld-gpio"; > + reg = <1>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpo { > + compatible = "kontron,sl28cpld-gpo"; > + > + gpio-controller; > + #gpio-cells = <2>; > + gpio-line-names = "a", "b", "c"; > + }; > + > + gpi { > + compatible = "kontron,sl28cpld-gpi"; > + > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + hwmon { > + compatible = "kontron,sl28cpld-fan"; > + }; > + > + pwm@0 { You already used the '0' address. You can't have 2 things at the same address. There's only one number space at a given level. All these child devices don't have any DT resources, so you don't really need them. The parent node could be a gpio and pwm provider and that's all you need in DT. Aside from DT resources, the only other reason to have all these child nodes are if the child blocks are going to get assembled in different combinations across a variety of h/w. Rob
next prev parent reply index Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-17 20:49 [PATCH 00/18] Add support for Kontron sl28cpld Michael Walle 2020-03-17 20:50 ` [PATCH 01/18] include/linux/ioport.h: add helper to define REG resource constructs Michael Walle 2020-03-17 20:50 ` [PATCH 02/18] mfd: mfd-core: Don't overwrite the dma_mask of the child device Michael Walle 2020-03-17 20:50 ` [PATCH 03/18] mfd: mfd-core: match device tree node against reg property Michael Walle 2020-03-17 20:50 ` [PATCH 04/18] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle 2020-03-30 22:35 ` Rob Herring [this message] 2020-03-31 7:40 ` Michael Walle 2020-03-17 20:50 ` [PATCH 05/18] mfd: Add support for Kontron sl28cpld management controller Michael Walle 2020-03-18 3:28 ` Guenter Roeck 2020-03-18 16:38 ` Michael Walle 2020-03-17 20:50 ` [PATCH 06/18] irqchip: add sl28cpld interrupt controller support Michael Walle 2020-03-18 16:53 ` Guenter Roeck 2020-03-18 17:06 ` Michael Walle 2020-03-18 20:35 ` Guenter Roeck 2020-03-17 20:50 ` [PATCH 07/18] dt-bindings: watchdog: Add bindings for sl28cpld watchdog Michael Walle 2020-03-17 20:50 ` [PATCH 08/18] watchdog: add support " Michael Walle 2020-03-18 3:17 ` Guenter Roeck 2020-03-17 20:50 ` [PATCH 09/18] dt-bindings: pwm: Add bindings for sl28cpld PWM controller Michael Walle 2020-03-17 20:50 ` [PATCH 10/18] pwm: add support " Michael Walle 2020-03-17 20:50 ` [PATCH 11/18] dt-bindings: gpio: Add bindings for sl28cpld GPIO controller Michael Walle 2020-03-17 20:50 ` [PATCH 12/18] gpio: add support for the " Michael Walle 2020-03-18 9:14 ` Bartosz Golaszewski 2020-03-18 12:45 ` Michael Walle 2020-03-25 11:50 ` Bartosz Golaszewski 2020-03-26 20:05 ` Michael Walle 2020-03-27 10:20 ` Linus Walleij 2020-03-27 15:28 ` Michael Walle 2020-03-27 19:01 ` Linus Walleij 2020-03-30 11:21 ` Bartosz Golaszewski 2020-03-30 11:48 ` Michael Walle 2020-03-28 12:04 ` Michael Walle 2020-03-28 17:20 ` Michael Walle 2020-03-17 20:50 ` [PATCH 13/18] dt-bindings: hwmon: Add bindings for sl28cpld hardware monitoring Michael Walle 2020-03-17 20:50 ` [PATCH 14/18] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle 2020-03-18 3:27 ` Guenter Roeck 2020-03-18 16:32 ` Michael Walle 2020-03-17 20:50 ` [PATCH 15/18] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle 2020-03-17 20:50 ` [PATCH 16/18] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle 2020-03-17 20:50 ` [PATCH 17/18] arm64: dts: freescale: sl28: enable LED support Michael Walle 2020-03-17 20:50 ` [PATCH 18/18] arm64: dts: freescale: sl28: enable fan support Michael Walle
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200330223535.GA31402@bogus \ --to=robh@kernel.org \ --cc=bgolaszewski@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=jason@lakedaemon.net \ --cc=jdelvare@suse.com \ --cc=lee.jones@linaro.org \ --cc=leoyang.li@nxp.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=maz@kernel.org \ --cc=michael@walle.cc \ --cc=shawnguo@kernel.org \ --cc=tglx@linutronix.de \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Watchdog Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \ linux-watchdog@vger.kernel.org public-inbox-index linux-watchdog Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog AGPL code for this site: git clone https://public-inbox.org/public-inbox.git